Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 15 May 2023 15:05:38 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Zhengchao Shao <shaozhengchao@huawei.com>
Cc:     linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        johannes@sipsolutions.net, kvalo@kernel.org, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        jaewan@google.com, steen.hegelund@microchip.com,
        weiyongjun1@huawei.com, yuehaibing@huawei.com,
        syzbot+904ce6fbb38532d9795c@syzkaller.appspotmail.com
Subject: Re: [PATCH net-next,v2] mac80211_hwsim: fix memory leak in
 hwsim_new_radio_nl
Message-ID: <ZGIuImVBq+CTMs9r@corigine.com>
References: <20230515092227.2691437-1-shaozhengchao@huawei.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230515092227.2691437-1-shaozhengchao@huawei.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?D7vn+Zu9AjRinJHmrpw5URNyWC4iSDq6iCSlzVYE+o04su5gNAMY+zOpffds?=
 =?us-ascii?Q?B5jSJrq2WPY7xByQodKV4vTw3spWkCDbTlbgEzlVvn9GRIUN4l5EgOHhs7u+?=
 =?us-ascii?Q?KeiOidT/2wtz0UFxuavVgNDRfCFmIoYHfUEy1IyulB184OJDx6mALVwCsNXi?=
 =?us-ascii?Q?quE9jUp2nB+hL16j+vOppvzDAKHYU2DcbR+ZML5yMJ/q2vteJUIGAkLAl1zY?=
 =?us-ascii?Q?P2qC27i95jEE2RliZSWjcc9VBb17GwMRhWWjMidv0zY/p/+/ppfzGibXhwsu?=
 =?us-ascii?Q?1zQsfqtu6Rxc6K645gG5u6dXqMYOEj2VI2wNUmp25wJ9aB7ru4kg2fXEhmZS?=
 =?us-ascii?Q?7StbOI9CE9kpxdBEbBz0eWxNZn/2OG9a4qHa5GunuOxOR4AEPTzEUDhiBUGk?=
 =?us-ascii?Q?n3nCUC1oG/Jq04eGmeVRlYkrDlHwkGSDr5YyS2VI/Fnn07rRsxYYbyIPVlcl?=
 =?us-ascii?Q?GTxEDORVT5CKMGB9Fa02sP3R+ACMh9Uy0ixnagu942RcSsv5MbXuchEJiGT2?=
 =?us-ascii?Q?BY8GpXZH+1PPB/6JZfaVVE90TA8JbOk1G6N+D42AGo4/CZdL5dkhTRHbTgcO?=
 =?us-ascii?Q?Rhmkh1v+du1w6uciQ59S0n0UwWPl8lG/rB+w2149zF60aDz3vqrJBsG1ejyH?=
 =?us-ascii?Q?h6/EEzSb0ZPjbkyX1p8JARL4hC9VJukHjNk3yjM/CpE/1CJVtszyvLacAx5X?=
 =?us-ascii?Q?ELNwjcTLdSxSM8KuqmV1qWZwwTWBJyuUSoN7XoPqQexiVqHsQNgNT5TuekBd?=
 =?us-ascii?Q?kpcRH3tMV9LYxgBVc2Q0V/ysuD0s45kwv6+E3Pe3ZVSQZkRnfadMsBpyfvgd?=
 =?us-ascii?Q?n3e3/tW7EskEXMEH3G+EGnZP/rsLBqN9r+CALI7fHTFED+I361VIQgnwZfJM?=
 =?us-ascii?Q?85R9AYUbZhhIrbMYAYNwX98GH+8tx3jXFHAesxvCOkL9Ha8ZLiuQLScfHtDB?=
 =?us-ascii?Q?1DuAAPe2tnvgG0jCtY1vkBFvsHYKKkuZWYZlSx9utWjcDim5LcLHCQB7yAiM?=
 =?us-ascii?Q?QwQPzPbggUzykUI4IqCwBSSC4ZQ/57znTrGB1hm3a2Nj9m/WwIfchsQS6vLS?=
 =?us-ascii?Q?V3X4rjzifZC2RiI+TTsxQ92FJErH1YoNGm3u0PZ+TB8hHxWX0RAgVJMRaZwC?=
 =?us-ascii?Q?xu4pr37+kyTJvEkDvDcUBaolfDvg2cwb0y84sDnLt8hyEZFOqGlUlZaWrhGM?=
 =?us-ascii?Q?IWmUXETMgjDkBmsmWkJW4h7uxFg4p51UjZx3wp76j6UAx12w8jCTs5z3KqwU?=
 =?us-ascii?Q?nOn46imWaERIGFzRRk+btSN+Fwo/abcPJw1dLbcD2RkmQFK3lOs3av8N+rFd?=
 =?us-ascii?Q?34esGR8kNngeQPQ24vU8alqrEWfcGxDhRJJ2NlO0vYlR9MzWi4W7L17vKyIr?=
 =?us-ascii?Q?AZo6uOsKiU3Xo2ICNj4dLHQdmInu6QdZ8Nm5NmLMvFqhFnul8lhYk+Rp436r?=
 =?us-ascii?Q?+Fn3mIGsV+9zqO28Vzn7RPMOGFpjUYhEHzAbpHk/WCKtADh2pzpnMinTcxmu?=
 =?us-ascii?Q?KtyHDJqRrgNhYOhrS5l+fVGFxXFooKoE5Ucb3Dxgl0bTNudHCocFY9A5/czO?=
 =?us-ascii?Q?RK7535LyhC9L0PxWsbLTGyr+rbsmmCbis0NbU/BFKr9uMYUZ1A3DJnAnrKkB?=
 =?us-ascii?Q?MDS/PSBJSOtpvFNOJNE0HMo3lHJk6E8Rd2pfPJfOEZASyICqvx/GfA7WaqBz?=
 =?us-ascii?Q?hpO39A=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2baaae22-1a8a-4d00-4474-08db55451888
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2023 13:05:45.7906
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ha17PRDY0sBtnfSGifF2HdNxCEDU/8Vua2TEy96dPFZSSzT4MEV/Mb1hXTOrYcbFF0YsbkByy9uhBO/rMuC+q6pPzlCYwIjoOidxf/M2UQk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR13MB6343
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Mon, May 15, 2023 at 05:22:27PM +0800, Zhengchao Shao wrote:
> When parse_pmsr_capa failed in hwsim_new_radio_nl, the memory resources
> applied for by pmsr_capa are not released. Add release processing to the
> incorrect path.
> 
> Fixes: 92d13386ec55 ("mac80211_hwsim: add PMSR capability support")
> Reported-by: syzbot+904ce6fbb38532d9795c@syzkaller.appspotmail.com
> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
> ---
> v2: move the value assigned to pmsr_capa before parse_pmsr_capa

Reviewed-by: Simon Horman <simon.horman@corigine.com>