Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp2417349rwd; Mon, 15 May 2023 11:21:12 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7GvC9UUAlXiEht/3eoWq/VXO6C8NAwOQJ3clq1P85XQr48Jq0w6EoWVCKnQXOdc0HvGeAZ X-Received: by 2002:a05:6a00:2313:b0:64a:fa71:a98f with SMTP id h19-20020a056a00231300b0064afa71a98fmr12372773pfh.13.1684174872090; Mon, 15 May 2023 11:21:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684174872; cv=none; d=google.com; s=arc-20160816; b=w7YCiAj9wwmbCIG/IFi6ATSDYno0lYeMATrD413P9gLjx9R0h16GVXTnqBr/R3N0H6 nIi2SeERD/ncq9DT5EFeibE38h4LHdDJBPcyuhqqghZrd6dnaPvHABp1uZ/rcaJJe7ML l4Tr+IYgPQatmvu4MUkdhAEhAWMDlgXTsA2DsfPpDToxp31RstFuY1rJf/6Or+WLU638 dms8EstuLlxnPTBE655hoQmcVI6bnlwc9lAHc2X3/F+dRumvBt/4c6fIknQV+JmaUZ3a H3bPWf7FR+O38qZdzomj5Olc2wXcxyijemOZYvUcQUjYeSSWdfe1zb4wIL82lXYfG/Wi gWjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=qLPcR4Qazf4XLSgypZ1ziNnNWlYnwQHWTMpDWWm6pvA=; b=m6cwKwUrcIXsQCvktqWOEN7Rmlo3q2ye0Ee1vc0whrvl7F0Bhol29eTwzjoem+ma4F ebnUin/vHBjaU0wwj2TyKAGBOD3IVc+BfItyp2A90hTstTeZFzDwIoNmomxOF/xPjdYa QEzBPJLQ0oubjOCI3r/z8Ek5tGDmjGzhHW/1iDp0uaLT9p3FOQ5GmuMmgQRbv1ndt0BZ QFHyiKzOXWYDHOHvVoniwv05aDq+JB1IT3yv6vAWJd+1liFgcWHOakzTy2RvjM1bW9Oa l40KYy8lHw1QPao336jUc8lLfxs7UL7mOTD79yMQxrN9bu7cvXEHCTVQ43XG9C+ofVX6 2d1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oG9Leaa4; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e9-20020a63aa09000000b0052c68c1d88asi15842264pgf.597.2023.05.15.11.21.01; Mon, 15 May 2023 11:21:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oG9Leaa4; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245220AbjEOSSZ (ORCPT + 61 others); Mon, 15 May 2023 14:18:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55728 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245178AbjEOSSE (ORCPT ); Mon, 15 May 2023 14:18:04 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6AE9819F0E; Mon, 15 May 2023 11:16:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EE64B63141; Mon, 15 May 2023 18:16:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0A56AC4339B; Mon, 15 May 2023 18:16:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684174594; bh=4x6kdBVXh0JiUR2vxk9aj3HYu4Rdy4cNvtGxm+3H7ds=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=oG9Leaa4njnenoDMSWTo311gXHQAGF8dRNYyRdagtu2UEFZWHSYzZtBlWJrYG9R3e mQKkFGZF5L/ys9e9aXwogUruv9DQYHE4jQJPXIT0uYwOY+2+iVfq8dJFp03zzjQj6I /sgrQWeN4M45LJ2JdiQQdgVaKIOsmpfqS8ZJTkCWcVW2vkRujo7IhYiEDRDHapObWX 4UFfk7RvSTlFECipOBVVYndU48qAtBB4EuHIfCU9e5vgzYGIfXR6UnlIH/ATxPr0I3 5niEIsHSibW+YZgbfBFJ7skZNbMunOOKQGu36EMmeUQQUkm/j1ipkpA6OkWqEgcFeP LZ9/Rb0e26OpQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: rtw88: correct qsel_to_ep[] type as int From: Kalle Valo In-Reply-To: <20230508085539.46795-1-pkshih@realtek.com> References: <20230508085539.46795-1-pkshih@realtek.com> To: Ping-Ke Shih Cc: , , , , User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <168417458623.32723.2980034936740722446.kvalo@kernel.org> Date: Mon, 15 May 2023 18:16:32 +0000 (UTC) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Ping-Ke Shih wrote: > qsel_to_ep[] can be assigned negative value, so change type from 'u8' to > 'int'. Otherwise, Smatch static checker warns: > drivers/net/wireless/realtek/rtw88/usb.c:219 rtw_usb_parse() warn: > assigning (-22) to unsigned variable 'rtwusb->qsel_to_ep[8]' > > Cc: stable@vger.kernel.org > Fixes: a6f187f92bcc ("wifi: rtw88: usb: fix priority queue to endpoint mapping") > Reported-by: Dan Carpenter > Link: https://lore.kernel.org/linux-wireless/c3f70197-829d-48ed-ae15-66a9de80fa90@kili.mountain/ > Cc: Sascha Hauer > Signed-off-by: Ping-Ke Shih > Acked-by: Sascha Hauer > Tested-by: Larry Finger Patch applied to wireless.git, thanks. 8e4942db5f5e wifi: rtw88: correct qsel_to_ep[] type as int -- https://patchwork.kernel.org/project/linux-wireless/patch/20230508085539.46795-1-pkshih@realtek.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches