Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <72a8eeb1-c91c-80a7-5a09-1b7963e0996b@lwfinger.net>
 <3162376.5fSG56mABF@jernej-laptop> <cee4e4f8-78e9-1bf7-c1a9-8ae5c662c785@lwfinger.net>
 <1855371.CQOukoFCf9@jernej-laptop>
In-Reply-To: <1855371.CQOukoFCf9@jernej-laptop>
From:   Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Date:   Mon, 15 May 2023 23:11:11 +0200
Message-ID: <CAFBinCCjzLH7ZZJ9Siw1Lp49qneO+qRJp-g8rGwAYuRwNj2Oyw@mail.gmail.com>
Subject: Re: Driver for rtw8723ds
To:     =?UTF-8?Q?Jernej_=C5=A0krabec?= <jernej.skrabec@gmail.com>
Cc:     Larry Finger <Larry.Finger@lwfinger.net>,
        linux-wireless <linux-wireless@vger.kernel.org>
Content-Type: multipart/mixed; boundary="00000000000093699a05fbc1e5b9"
Precedence: bulk

--00000000000093699a05fbc1e5b9
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Jernej,

On Mon, May 15, 2023 at 10:37=E2=80=AFPM Jernej =C5=A0krabec
<jernej.skrabec@gmail.com> wrote:
[...]
> > With aggregation disabled, we still get "Invalid RX packet size!" messa=
ges. I am
> > changing the statement to log (curr_pkt_len + pkt_desc_sz) > rx_len. I =
will let
> > you know when the OP responds.
>
> Yeah, I saw. I just find another possible reason, which fits nicely in cu=
rrent
> situation. Vendor driver parses drv_info_sz and shift fields only if pack=
et
> is normal, e.g. not c2h type. However, rtw88 always parses those fields. =
It's
> possible that they have some value which should be ignored on 8723ds. I
> appended another patch to test.
I tried that patch and it didn't work for me (I can't get the card to
assoc to my AP with that patch).
Additionally I tried a simplified version (attached) and it didn't work.

I'm out of time for today though so I cannot continue testing.


Best regards,
Martin

--00000000000093699a05fbc1e5b9
Content-Type: text/x-patch; charset="US-ASCII"; name="sdio-check-is-c2h.diff"
Content-Disposition: attachment; filename="sdio-check-is-c2h.diff"
Content-Transfer-Encoding: base64
Content-ID: <f_lhpcad3a0>
X-Attachment-Id: f_lhpcad3a0

ZGlmZiAtLWdpdCBhL2RyaXZlcnMvbmV0L3dpcmVsZXNzL3JlYWx0ZWsvcnR3ODgvc2Rpby5jIGIv
ZHJpdmVycy9uZXQvd2lyZWxlc3MvcmVhbHRlay9ydHc4OC9zZGlvLmMKaW5kZXggMDZmY2U3YzNh
ZGRhLi5mOTZlOTg4MTgxODQgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvbmV0L3dpcmVsZXNzL3JlYWx0
ZWsvcnR3ODgvc2Rpby5jCisrKyBiL2RyaXZlcnMvbmV0L3dpcmVsZXNzL3JlYWx0ZWsvcnR3ODgv
c2Rpby5jCkBAIC05NjEsOCArOTYxLDEwIEBAIHN0YXRpYyB2b2lkIHJ0d19zZGlvX3J4Zmlmb19y
ZWN2KHN0cnVjdCBydHdfZGV2ICpydHdkZXYsIHUzMiByeF9sZW4pCiAJCXJ4X2Rlc2MgPSBza2It
PmRhdGE7CiAJCWNoaXAtPm9wcy0+cXVlcnlfcnhfZGVzYyhydHdkZXYsIHJ4X2Rlc2MsICZwa3Rf
c3RhdCwKIAkJCQkJICZyeF9zdGF0dXMpOwotCQlwa3Rfb2Zmc2V0ID0gcGt0X2Rlc2Nfc3ogKyBw
a3Rfc3RhdC5kcnZfaW5mb19zeiArCi0JCQkgICAgIHBrdF9zdGF0LnNoaWZ0OworCisJCXBrdF9v
ZmZzZXQgPSBwa3RfZGVzY19zejsKKwkJaWYgKCFwa3Rfc3RhdC5pc19jMmgpCisJCQlwa3Rfb2Zm
c2V0ICs9IHBrdF9zdGF0LmRydl9pbmZvX3N6ICsgcGt0X3N0YXQuc2hpZnQ7CiAKIAkJY3Vycl9w
a3RfbGVuID0gQUxJR04ocGt0X29mZnNldCArIHBrdF9zdGF0LnBrdF9sZW4sCiAJCQkJICAgICBS
VFdfU0RJT19EQVRBX1BUUl9BTElHTik7Cg==
--00000000000093699a05fbc1e5b9--