Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp297342rwd; Tue, 16 May 2023 00:53:41 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6Bp3JR2/asUw2mkAgWIudS4ydIlbqnA5xWRtiRD0Xh/aynZq44SyFt1lo31u+cB9EB9OFC X-Received: by 2002:a05:6a20:9192:b0:f2:cc6a:932 with SMTP id v18-20020a056a20919200b000f2cc6a0932mr44073722pzd.49.1684223621083; Tue, 16 May 2023 00:53:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684223621; cv=none; d=google.com; s=arc-20160816; b=uNgvum2FT27ZOvodFgfTrRpfo7LHDrQBKjQHQg+sRGw4IeqnLSOw+Y97X+W9udFTBt cms9fUJ1k40k+FqoDOpdF8pMgbiNauvgMEabVrygtvlorOYQlbwJGvR/wADtwW6WYfua WLDMmRjmULFaUeKzihkYUDjNk1gGTV48P7Ega27Nf8jn33duV8SvnVcITB9zQu1kFqbq TORkVbLQ1uBCqTQ62XqMOlvA7F2TPOFPRPsRfWXhTZrVVjqIs668v7AwJoxeJUJj0yBk crmbsI2kw8Y6f+u7jKV4dNvEyf0aBX82quE2/KMUW926uytCc3+Cmsl/ewf/+ZMlkw3/ 4w0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Hzhq2e8PVhFVZ2SPOG8NzqYoZ2H8ZlyME3XL/awojHQ=; b=mgMCe5TgFx3W3lrMLYHAz4tQOUIMqzUS9rxtsKAE1f9D6yiemnSgjdN7XGoHf+hVvl ec8yXiDXZ2U3l5HLEeu6i3w5H4dD6jOVBhDbkSl9nRgWG63rrp1zMQHrQdMzsM/JSMe6 EpSQR3yjaGIasPx2aNaXLydMP0q/2Hd3z3es4rd88w4CbbegdCjnnQZ1IKtjYtQkhp1u 1Y7ONdRiaMYW3v7VIo4wlj8KsLz9PyQhxc/f96uO/77Opd2cNRRn3SAp0kJRll3bVa8w bgs3nbr0AxOOsxfHgrgI4rWq74X7W8u6StxsSDdetWn2clbPoiebBc2Tn35SPgJcFvjA rIYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=c4Tkzftt; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g126-20020a636b84000000b0050ac7d1b32asi16711603pgc.603.2023.05.16.00.53.33; Tue, 16 May 2023 00:53:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=c4Tkzftt; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231452AbjEPHqH (ORCPT + 62 others); Tue, 16 May 2023 03:46:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231324AbjEPHqF (ORCPT ); Tue, 16 May 2023 03:46:05 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F2D3449B; Tue, 16 May 2023 00:46:01 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 18E3662850; Tue, 16 May 2023 07:46:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8CE33C433D2; Tue, 16 May 2023 07:45:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684223160; bh=DWVQGg8BOQg1TC5mQhyL5M5QVn3UeUKSLvymNtkvcT4=; h=From:To:Cc:Subject:Date:From; b=c4TkzfttZpQk0Ptc+5OqMy617FPzeTD+h9izO2F78CbvIexZDfGN86mXf7dEkoxa9 h+lGw7DZfar/rMhiBdMV4WCAtrfSzoEHviL4BQsivRZF2nzHS6ZauNO62pFMsNyyFL AteyHMEc3rleqpNvRDnhzy77+P+WDF7n10KIosEBEWyuPIDs9/UsoqZh4aj3MMuZza bJM3xkdKlERWL9lHGePfDyU0EOfg70bLlL5XYtvIJalyVwTF6WxBKZ/z8Zb6jT28xc VAay31rGQE1qLGmb8S1LUUoYgAhMPhbg/2H3rsouC0ngqss5jB13ErcvDHW8pvuGMV nc42AQEJ4z8Hg== From: Arnd Bergmann To: Kalle Valo Cc: Arnd Bergmann , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Nathan Chancellor , Nick Desaulniers , Tom Rix , linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: [PATCH] wifi: b43: fix incorrect __packed annotation Date: Tue, 16 May 2023 09:45:42 +0200 Message-Id: <20230516074554.1674536-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Arnd Bergmann clang warns about an unpacked structure inside of a packed one: drivers/net/wireless/broadcom/b43/b43.h:654:4: error: field data within 'struct b43_iv' is less aligned than 'union (unnamed union at /home/arnd/arm-soc/drivers/net/wireless/broadcom/b43/b43.h:651:2)' and is usually due to 'struct b43_iv' being packed, which can lead to unaligned accesses [-Werror,-Wunaligned-access] The problem here is that the anonymous union has the default alignment from its members, apparently because the original author mixed up the placement of the __packed attribute by placing it next to the struct member rather than the union definition. As the struct itself is also marked as __packed, there is no need to mark its members, so just move the annotation to the inner type instead. Signed-off-by: Arnd Bergmann --- drivers/net/wireless/broadcom/b43/b43.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/broadcom/b43/b43.h b/drivers/net/wireless/broadcom/b43/b43.h index 9fc7c088a539..67b4bac048e5 100644 --- a/drivers/net/wireless/broadcom/b43/b43.h +++ b/drivers/net/wireless/broadcom/b43/b43.h @@ -651,7 +651,7 @@ struct b43_iv { union { __be16 d16; __be32 d32; - } data __packed; + } __packed data; } __packed; -- 2.39.2