Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <72a8eeb1-c91c-80a7-5a09-1b7963e0996b@lwfinger.net>
 <3162376.5fSG56mABF@jernej-laptop> <cee4e4f8-78e9-1bf7-c1a9-8ae5c662c785@lwfinger.net>
 <1855371.CQOukoFCf9@jernej-laptop> <CAFBinCCjzLH7ZZJ9Siw1Lp49qneO+qRJp-g8rGwAYuRwNj2Oyw@mail.gmail.com>
In-Reply-To: <CAFBinCCjzLH7ZZJ9Siw1Lp49qneO+qRJp-g8rGwAYuRwNj2Oyw@mail.gmail.com>
From:   Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Date:   Tue, 16 May 2023 12:22:32 +0200
Message-ID: <CAFBinCAD-7Mi06z-RGVREDQ3bYsDUOyDkBgoNW5mDLuKM8H7sg@mail.gmail.com>
Subject: Re: Driver for rtw8723ds
To:     =?UTF-8?Q?Jernej_=C5=A0krabec?= <jernej.skrabec@gmail.com>
Cc:     Larry Finger <Larry.Finger@lwfinger.net>,
        linux-wireless <linux-wireless@vger.kernel.org>
Content-Type: multipart/mixed; boundary="000000000000a7ee2b05fbccf3f6"
Precedence: bulk

--000000000000a7ee2b05fbccf3f6
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, May 15, 2023 at 11:11=E2=80=AFPM Martin Blumenstingl
<martin.blumenstingl@googlemail.com> wrote:
>
> Hi Jernej,
>
> On Mon, May 15, 2023 at 10:37=E2=80=AFPM Jernej =C5=A0krabec
> <jernej.skrabec@gmail.com> wrote:
> [...]
> > > With aggregation disabled, we still get "Invalid RX packet size!" mes=
sages. I am
> > > changing the statement to log (curr_pkt_len + pkt_desc_sz) > rx_len. =
I will let
> > > you know when the OP responds.
> >
> > Yeah, I saw. I just find another possible reason, which fits nicely in =
current
> > situation. Vendor driver parses drv_info_sz and shift fields only if pa=
cket
> > is normal, e.g. not c2h type. However, rtw88 always parses those fields=
. It's
> > possible that they have some value which should be ignored on 8723ds. I
> > appended another patch to test.
> I tried that patch and it didn't work for me (I can't get the card to
> assoc to my AP with that patch).
> Additionally I tried a simplified version (attached) and it didn't work.
>
> I'm out of time for today though so I cannot continue testing.
I took time during my lunch break for some more experiments and came
up with the attached patch (the vendor driver does something similar
and I only noticed that after I observed some rtw_rx_pkt_stat with
pkt_len being zero).
It survived 30 minutes of uptime, updating my system and several
iperf3 runs (in both directions).
iperf results:
- RX: 48 Mbit/s
- TX: 33 Mbit/s

And to be clear, those results are with:
- the word IO bugfix
- the initial two patches from this series
- Larry's addition of the second RTL8723DS SDIO ID
- the attached patch


Best regards,
Martin

--000000000000a7ee2b05fbccf3f6
Content-Type: text/x-patch; charset="US-ASCII"; 
	name="rtw88-sdio-rx-isr-check-rx-request-bit.diff"
Content-Disposition: attachment; 
	filename="rtw88-sdio-rx-isr-check-rx-request-bit.diff"
Content-Transfer-Encoding: base64
Content-ID: <f_lhq4iol50>
X-Attachment-Id: f_lhq4iol50

ZGlmZiAtLWdpdCBhL2RyaXZlcnMvbmV0L3dpcmVsZXNzL3JlYWx0ZWsvcnR3ODgvc2Rpby5jIGIv
ZHJpdmVycy9uZXQvd2lyZWxlc3MvcmVhbHRlay9ydHc4OC9zZGlvLmMKaW5kZXggMDZmY2U3YzNh
ZGRhLi5hOTRjNGUxNTIwNGIgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvbmV0L3dpcmVsZXNzL3JlYWx0
ZWsvcnR3ODgvc2Rpby5jCisrKyBiL2RyaXZlcnMvbmV0L3dpcmVsZXNzL3JlYWx0ZWsvcnR3ODgv
c2Rpby5jCkBAIC05OTgsNyArOTk4LDcgQEAgc3RhdGljIHZvaWQgcnR3X3NkaW9fcnhmaWZvX3Jl
Y3Yoc3RydWN0IHJ0d19kZXYgKnJ0d2RldiwgdTMyIHJ4X2xlbikKIAogc3RhdGljIHZvaWQgcnR3
X3NkaW9fcnhfaXNyKHN0cnVjdCBydHdfZGV2ICpydHdkZXYpCiB7Ci0JdTMyIHJ4X2xlbiwgdG90
YWxfcnhfYnl0ZXMgPSAwOworCXUzMiByeF9sZW4sIGhpc3IsIHRvdGFsX3J4X2J5dGVzID0gMDsK
IAogCXdoaWxlICh0b3RhbF9yeF9ieXRlcyA8IFNaXzY0SykgewogCQlpZiAocnR3X2NoaXBfd2Nw
dV8xMW4ocnR3ZGV2KSkKQEAgLTEwMTIsNiArMTAxMiwxOCBAQCBzdGF0aWMgdm9pZCBydHdfc2Rp
b19yeF9pc3Ioc3RydWN0IHJ0d19kZXYgKnJ0d2RldikKIAkJcnR3X3NkaW9fcnhmaWZvX3JlY3Yo
cnR3ZGV2LCByeF9sZW4pOwogCiAJCXRvdGFsX3J4X2J5dGVzICs9IHJ4X2xlbjsKKworCQkvKiBT
dG9wIGlmIG5vIG1vcmUgUlggcmVxdWVzdHMgYXJlIHBlbmRpbmcsIGV2ZW4gaWYgcnhfbGVuCisJ
CSAqIGNvdWxkIGJlIGdyZWF0ZXIgdGhhbiB6ZXJvIGluIHRoZSBuZXh0IGl0ZXJhdGlvbi4gVGhp
cyBpcworCQkgKiBuZWVkZWQgYmVjYXVzZSB0aGUgUlggYnVmZmVyIG1heSBhbHJlYWR5IGNvbnRh
aW4gZGF0YSB3aGlsZQorCQkgKiB0aGUgY2hpcCBpcyBub3QgZG9uZSBmaWxsaW5nIHRoYXQgYnVm
ZmVyIHlldC4gU3RpbGwgcmVhZGluZworCQkgKiB0aGUgYnVmZmVyIGNhbiByZXN1bHQgaW4gZW1w
dHkgcGFja2V0cyBvciByZWFkaW5nIHBhY2tldHMKKwkJICogd2hlcmUgcnR3X3J4X3BrdF9zdGF0
LnBrdF9sZW4gcG9pbnRzIGJleW9uZCB0aGUgZW5kIG9mIHRoZQorCQkgKiBidWZmZXIuCisJCSAq
LworCQloaXNyID0gcnR3X3JlYWQzMihydHdkZXYsIFJFR19TRElPX0hJU1IpOworCQlpZiAoISho
aXNyICYgUkVHX1NESU9fSElTUl9SWF9SRVFVRVNUKSkKKwkJCWJyZWFrOwogCX0KIH0KIAo=
--000000000000a7ee2b05fbccf3f6--