Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 16 May 2023 13:00:54 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Arnd Bergmann <arnd@kernel.org>
Cc:     Kalle Valo <kvalo@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Tom Rix <trix@redhat.com>, linux-wireless@vger.kernel.org,
        b43-dev@lists.infradead.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] wifi: b43: fix incorrect __packed annotation
Message-ID: <ZGNiZtG38Kr5M2uW@corigine.com>
References: <20230516074554.1674536-1-arnd@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230516074554.1674536-1-arnd@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OuoNnM5b2PD1zqkejDEok07By4V0XdsM92fAHBzoUPxrbmiY4TQGVkUKoifg?=
 =?us-ascii?Q?XoBviWkQ/HcrB+BJkaCLEZ+edEafyNaVsnrlRuc0aQ0r64JAOcWwo0so0naE?=
 =?us-ascii?Q?yu5puYBgHKJZwcZycEfksVnAxT8F/87XbNnBGgQc+pTbu6vQZzDE06Ky0bUQ?=
 =?us-ascii?Q?xgxCDDJRrxcYcCTzg5H8OtYDzQybBL0IygL0WHJGNESD+S8Ktkucl01kOInm?=
 =?us-ascii?Q?L5eeGiK7GWjkx/W2zMWW6LTam3w9GjJmhiMVYIkD586SgFUiWs6mrL1Jn9fK?=
 =?us-ascii?Q?AWIuzqP3gcZ1+mccGK1cSa90cp+2N06EW181uVn8AMUW/iQNKpXWy8O8MeBK?=
 =?us-ascii?Q?fhH4H+m8lhuKf9mNqrkdi66t9yrwMqJhm1Qm7IiFmiHgVuQ6a6R7uF3cm56Z?=
 =?us-ascii?Q?+DHbFkHWmYGwVrFEZiO/9Xe56Y02PB/qspQfLp9LMqQxvwIG3Shj1Zp1krVS?=
 =?us-ascii?Q?veg1he7MDRaNf+gurXkxQBCKUKfoRFArzn737PPHJ9K82B1DZC6EP6/fTDQV?=
 =?us-ascii?Q?nSXG1KeM9UEjgbzCAnydSBNgb2cZxkhqPIcPXsVVCoslowLtBIBPEyhxNkVs?=
 =?us-ascii?Q?Tt7Oj+Pot/53Cu5L7ZwDPcrd/3aGtrY6xFj0o8xjRt1w66GcekDkOk8hZiYT?=
 =?us-ascii?Q?gqwP9VtQ0jPybrA95sPUCwUBW8mWlsBp+sny5O1DWFhdEv9iCS45oNAagkcJ?=
 =?us-ascii?Q?uPyu2PZd3RJYYBd/3F43IAKW2QEPenNthNx9DRlSuwnfS/vXPXmleG0knSFM?=
 =?us-ascii?Q?6F1GkUuAB4uBu/gZwGQ80djoY5OceJwsINz3v5oUAAG8LdRbUqNbA3nMQXkh?=
 =?us-ascii?Q?WLOoKLi3IgV7sf6iYmLJD4wLXnE6u1N1YG2FhEmwL1+5kYXhK/2sLz7/aF+4?=
 =?us-ascii?Q?Mpk1C9W8fvxX2qdNYlFbXgIecpI4kxmJ2NL1S5jaJTDkXxYDtTt4TH3b0fiZ?=
 =?us-ascii?Q?D+lx/64H5Vrt093qe+QcY/jmo/XlFNijpHz2OwbZKpSqCx+3xzvFeC0i5DZY?=
 =?us-ascii?Q?Lv5zW5IZpcJjHEFcBw95Gdgkc6+D1vy+M8GvsrZQtZvMNF//hZ4tAOSFG0Dp?=
 =?us-ascii?Q?z7CIN5vVc3No2RKN8OkYyNjMpVmjrOjNALyaY+UmlSVBFF9PhjFMASp6qZKq?=
 =?us-ascii?Q?wLpHJJ0I00qDBowYncRCSflPcH8UrF9GMBp9WwS9YAB1zqtYQSjEBYU5bLj2?=
 =?us-ascii?Q?hGhxeU0nzgfGj3whpoPanMlbGtK6zaVlRohQRheBtWuvMq+iN5LLIkWEdEvh?=
 =?us-ascii?Q?ZgPflJmNlJAjwLRvnGSJZfRzueU1zBmo0KWox7igsKSmsgyKf2vuM0kNrfxE?=
 =?us-ascii?Q?bRyQoLHhKjEM7kCcAeR8Ug+rgL7ubMSHlhgKj/5ZCYklEzvDJGmfkxN/PFA3?=
 =?us-ascii?Q?0h+WStf2m98L3+KK3lbJEov4wfxXM3kLdk35X5gDZnVB2XBqVujM+wN87Fp5?=
 =?us-ascii?Q?Mdvm0A2Bq2RENaMe2lJMC3311yLdsOjedaQV8stwdn7CCaPdyWvtrXzREyKz?=
 =?us-ascii?Q?zCUvM7HxH3GnlereU5KYSFgOLu8FZN94zdM06jvWj8aTdNT5VWe27vDAOIsT?=
 =?us-ascii?Q?VRC1Kh/q2FehajNy5JDxcSKmUdLTDGmgvKWSL38FjpAmOVHeJAPBpY2sEfiO?=
 =?us-ascii?Q?EcEC0EiZ4Fe5xFHf5bdGeDqxP6rl7OAIxbsorHYFDci3alwBrt4LhIWVK19g?=
 =?us-ascii?Q?2fjmsA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dd1f70b7-b42f-46e7-faee-08db55fcd5b7
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2023 11:01:01.0655
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yvdLRinW8ZZk26eZSGrI0ZZe7vTAO78P6dQDbF0TDKx+PVQAGM1LnFwcnbfyrQ2OCIqFlUXy4aOMXjMKLJOmoIj3G/so5tsAVP8mXFUXpiQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR13MB6367
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Tue, May 16, 2023 at 09:45:42AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> clang warns about an unpacked structure inside of a packed one:
> 
> drivers/net/wireless/broadcom/b43/b43.h:654:4: error: field data within 'struct b43_iv' is less aligned than 'union (unnamed union at /home/arnd/arm-soc/drivers/net/wireless/broadcom/b43/b43.h:651:2)' and is usually due to 'struct b43_iv' being packed, which can lead to unaligned accesses [-Werror,-Wunaligned-access]
> 
> The problem here is that the anonymous union has the default alignment
> from its members, apparently because the original author mixed up the
> placement of the __packed attribute by placing it next to the struct
> member rather than the union definition. As the struct itself is
> also marked as __packed, there is no need to mark its members, so just
> move the annotation to the inner type instead.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Simon Horman <simon.horman@corigine.com>