Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <72a8eeb1-c91c-80a7-5a09-1b7963e0996b@lwfinger.net>
 <3162376.5fSG56mABF@jernej-laptop> <cee4e4f8-78e9-1bf7-c1a9-8ae5c662c785@lwfinger.net>
 <1855371.CQOukoFCf9@jernej-laptop> <CAFBinCCjzLH7ZZJ9Siw1Lp49qneO+qRJp-g8rGwAYuRwNj2Oyw@mail.gmail.com>
 <CAFBinCAD-7Mi06z-RGVREDQ3bYsDUOyDkBgoNW5mDLuKM8H7sg@mail.gmail.com> <7106ab11-197d-e0d1-f54a-f56d438a022d@lwfinger.net>
In-Reply-To: <7106ab11-197d-e0d1-f54a-f56d438a022d@lwfinger.net>
From:   Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Date:   Tue, 16 May 2023 20:48:07 +0200
Message-ID: <CAFBinCDbY5_xs7eNv5M-GyYGGFSwwTUtRSQSi9R9wZFzumiE5Q@mail.gmail.com>
Subject: Re: Driver for rtw8723ds
To:     Larry Finger <Larry.Finger@lwfinger.net>
Cc:     =?UTF-8?Q?Jernej_=C5=A0krabec?= <jernej.skrabec@gmail.com>,
        linux-wireless <linux-wireless@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Larry,

On Tue, May 16, 2023 at 8:31=E2=80=AFPM Larry Finger <Larry.Finger@lwfinger=
.net> wrote:
[...]
> >> I'm out of time for today though so I cannot continue testing.
> > I took time during my lunch break for some more experiments and came
> > up with the attached patch (the vendor driver does something similar
> > and I only noticed that after I observed some rtw_rx_pkt_stat with
> > pkt_len being zero).
> > It survived 30 minutes of uptime, updating my system and several
> > iperf3 runs (in both directions).
> > iperf results:
> > - RX: 48 Mbit/s
> > - TX: 33 Mbit/s
> >
> > And to be clear, those results are with:
> > - the word IO bugfix
> > - the initial two patches from this series
> > - Larry's addition of the second RTL8723DS SDIO ID
> > - the attached patch
>
> Martin,
>
> Please send me a copy of the version of sdio.c that works. It seems likel=
y that
> I got mine all messed up as the OP at GitHub is getting lots of warnings =
from
> net/mac80211/rx.c:803.
Please take the file from [0] - this is how I successfully tested it.


Best regards,
Martin


[0] https://github.com/xdarklight/linux/commits/mangopi-mq-quad-20230516