Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1171480rwd; Tue, 16 May 2023 12:56:15 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5Bf3se0sHzyYyIFIjPWGp/2Gy9ZfhUNdTBqsmbI/d4FtELLjFKevfleyoPTtgy/+bNIH7A X-Received: by 2002:a05:6a21:339a:b0:106:a78f:be22 with SMTP id yy26-20020a056a21339a00b00106a78fbe22mr5096816pzb.31.1684266975122; Tue, 16 May 2023 12:56:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684266975; cv=none; d=google.com; s=arc-20160816; b=W4UFk3xXKzvzXP1UI72+MvPvCbKffC2ZoegbsPYbXLK+682IIsysJCV55WeuHK1EbG FLT35gXZeHlJw3DHNGVX+3khaPj65oAH4/qsu/UEjOR8hixwHxs1ij5Y2XDVaMequBvH WFEqs3p51P5vS9MIa94P72K+YeLPIwi7LXSWPJDmW1Qti5xw1Z9wplnn7RuQKgmlQlq7 9Jo8NeBjUxp/SrTb9Dmll4bQa2ogm/T3QJDLhlaBSvBYWqwrCy5pdroXliiKR9lVEwI5 Ip3d9IFQzYFY8g2DJfPKl1Nc+zMpyE+yF+cluRadIwo8ktf2kxhpxmXqE0OCtHwHkd6g HVSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:references:in-reply-to:subject:cc:to:dkim-signature :from; bh=kS06qhDO4SuIPjXTCQd5ri72irx1DJTv1Uk+i6GpwGs=; b=q7DwJTLJWzdZlyRKmLRrsDv4chqehk3niKPrY0QEihQAYDjilNu+KymDuQcKCI/toO QKOcjGQw7xA71iB4Hp3fGqAZNJtEZSetpBQnGK/HtAccVZS1VRONgeR1zpODT+18orvi GPVM+d88zme5qgOk/Y4FqrYXywK8TWOvEFD0d3Bx5yW+eW2vBQiw7vYigG+lIvQSJyX1 QiNGubuCL+jl2QhQst//ex0MZbn8al2ePR6bLv54gFI6AXUx5e3CNSIUeSKZHRLQzvSf LGhocnxSgxkX7XWNyYUCkRDZfE/8EOgD7gOzAyzPctGW3sO1Yqy+SucwF8bRXCrqerGU AMAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@toke.dk header.s=20161023 header.b="xn/yjWqq"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=toke.dk Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r12-20020aa7988c000000b0063b8b3519besi19909476pfl.32.2023.05.16.12.56.03; Tue, 16 May 2023 12:56:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@toke.dk header.s=20161023 header.b="xn/yjWqq"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=toke.dk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230055AbjEPTr3 (ORCPT + 63 others); Tue, 16 May 2023 15:47:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229502AbjEPTr2 (ORCPT ); Tue, 16 May 2023 15:47:28 -0400 Received: from mail.toke.dk (mail.toke.dk [45.145.95.4]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79467BE; Tue, 16 May 2023 12:47:13 -0700 (PDT) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1684266429; bh=kS06qhDO4SuIPjXTCQd5ri72irx1DJTv1Uk+i6GpwGs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=xn/yjWqqhVOfJWo4wMwSsEXEfyJYKmZgxCmzubpJMDYJ5QRJLaRzPUd3tuhdHHtHH JCkDKPZpK8XjTtu/EztjVbyyKmEeROQBjF6HFojbg1sWdeJdivxBJ7VpTNjv03idRf oqsqVbcNcl9IW8kV/amAEV2RaOV+n8bOMefnCVGGRrmtQhWoXHQUolGO6+pp+vdjRU ZPs87cck+2eOr/VVJUqj1Q+WP34dJsUDPmxbF2OF5Aiw7NzIylnxMEC8joCYobU7h7 TTr1dyWNh39FcMBho/IMJ1Fn5yQPdllpQqd0hhx5rBq3hEDPIpjOrlnboQB9g9LIoU JGliQsv/mrhCg== To: Fedor Pchelkin Cc: Fedor Pchelkin , Kalle Valo , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Takeshi Misawa , Alexey Khoroshilov , lvc-project@linuxtesting.org, syzbot+b68fbebe56d8362907e8@syzkaller.appspotmail.com Subject: Re: [PATCH v2] wifi: ath9k: don't allow to overwrite ENDPOINT0 attributes In-Reply-To: <20230516150427.79469-1-pchelkin@ispras.ru> References: <20230516150427.79469-1-pchelkin@ispras.ru> Date: Tue, 16 May 2023 21:47:08 +0200 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <871qjgcb43.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fedor Pchelkin writes: > A bad USB device is able to construct a service connection response > message with target endpoint being ENDPOINT0 which is reserved for > HTC_CTRL_RSVD_SVC and should not be modified to be used for any other > services. > > Reject such service connection responses. > > Found by Linux Verification Center (linuxtesting.org) with Syzkaller. > > Fixes: fb9987d0f748 ("ath9k_htc: Support for AR9271 chipset.") > Reported-by: syzbot+b68fbebe56d8362907e8@syzkaller.appspotmail.com > Signed-off-by: Fedor Pchelkin Acked-by: Toke H=C3=B8iland-J=C3=B8rgensen