Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1390187rwd; Tue, 16 May 2023 16:56:51 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6QxWgSJGC2h5IpNyF+iQtqPb8OzNBD3d2Xb1YIA5xueS8b9g2hiutHp+7upGcotimT7SIi X-Received: by 2002:a17:90b:3505:b0:250:4f32:54b2 with SMTP id ls5-20020a17090b350500b002504f3254b2mr35349689pjb.19.1684281411068; Tue, 16 May 2023 16:56:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684281411; cv=none; d=google.com; s=arc-20160816; b=HCL4xeUVpwGrVrF3P0EHwQSKMaUujr2BGMQSfWtIh5GeBBTAF97TZjxu/SknA9wT4B RvUwxNBSSQdm1twBuiEPmBZRgy4eDqbseOYuOuq3oouQPfV63R4sbrFsghKntBvdjOxY RWsrT8A1CKQ3TBFJRXoyWLiKXu/ifdX4oIz0Is/HR80dPHy+zAfFphMWnoeZDr5HADBU OcRO6MTZVkhZU0tdMcpVmqtLn7ph1R3t8/9DUjjrFR7okgHB8mxqaSR6OoKA7waDnFcm Ws02cLDa5XECTptBXo7RihVKTwbqEBKhKKam94EnTR2ispCzINIXlV9lL0axs+T28s1b k8ZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:sender:dkim-signature; bh=5OqbjUWSPQ7aIaIGQbhH/u54X9htzzqfehRPAy3oeVA=; b=Dm01G6AMcXjGgQQH4yY8f+dfLZAAPO8lil6loGARr6tr3aYwFfbwwI5DJhpkB4TSwE Qovt1AT3lTByqTEdm8fx9Sxw1FIRYlGEzecrthPICaKbZp0EP9WkwR2wlP/G5X0C4BQ1 EIAq84saNcwrwqTNmm8aIXC/zTBMbExG/ZZOYD9XIbOHJ2B/Nn9rAxmvkp9FK92utXLd 5WsSARWNmLeTM/VPmjcujHySs6kcuNj05sC2jDw5Fh1RD7RdHetNqeRN6XULrcyYEZP8 31Yt2IsGg/SE85BE8cUfKQ32QmUeSV8mExcF1MHauFdlM34TLqkY+wLIOvtdBlwJ2r5M C0BQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=N+se8bLz; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lw4-20020a17090b180400b002528f40700dsi375313pjb.153.2023.05.16.16.56.36; Tue, 16 May 2023 16:56:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=N+se8bLz; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231367AbjEPXly (ORCPT + 63 others); Tue, 16 May 2023 19:41:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231261AbjEPXlx (ORCPT ); Tue, 16 May 2023 19:41:53 -0400 Received: from mail-ot1-x32e.google.com (mail-ot1-x32e.google.com [IPv6:2607:f8b0:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4231B527C for ; Tue, 16 May 2023 16:41:52 -0700 (PDT) Received: by mail-ot1-x32e.google.com with SMTP id 46e09a7af769-6ab0967093dso153425a34.3 for ; Tue, 16 May 2023 16:41:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684280511; x=1686872511; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=5OqbjUWSPQ7aIaIGQbhH/u54X9htzzqfehRPAy3oeVA=; b=N+se8bLzasUMFYIFs97h3VFz3zzu0j2jcCToV1hJtrNOZ0g5SlmO9a16b+olY7jhH5 /fKkwvd7fcY5ijoDD63iRVeHXyRuZ/rVvDLQhuyFTxcbH5IMI+uuHpPjtWMcCvf7LLMd P5Wc9hcAUABa1OlFvdBhgvPp9I8QN39FzQcrTeL1nQFt32arKkqD/AkHo2EdxrhLjZlF XJXR1RStzeMdHrGMgc4VyiuaiIcp7SWQq+1Xnk5du3rffXdw3FS/f55AuJQsfgUz3Nop QJkmpEbr8yoncTjwRd9C3GqgJqhq7viRkmDx4hfNuKovt5jAx9AUaIMpWIQiCgDreOVW VTYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684280511; x=1686872511; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5OqbjUWSPQ7aIaIGQbhH/u54X9htzzqfehRPAy3oeVA=; b=e8SlCl5Yie9yceXzkYZ5db5d6tGluE4f4k0/YuI4yKD6qGmyDZGDXrHx55/HQWIlKL nrSpaTLdeQU9wmYF3KxfgRATWYSKcuWleMi3Q81KzxkCKbDuIP1/8zt1u5Fqk1IZp+Nx 0udeGHrFunw9Ltm7o2Sh0NVdJPMvLr2V41VDROwy5MU1okq19VF3rKqC4jc8cKdGvOPR mTGt1WYaQtb2UnMR9AsnRyX7Dm2o66rrblNsYvuEiIkRoshC/4gsdLoLBiyQN55WsnJ6 Ymv1YffQTZhqAnl5bzOcoGCm4yDwYPayFppcfX5oZX2taZQLKCBHUEbcFEG8IoKHIj2S Smfw== X-Gm-Message-State: AC+VfDyp1XFPREoohqjPQUujcAiZzxE/WRtf/K/s6O66oktltPctCM55 z+VDdHsh44kIT0Ya5zw0j10= X-Received: by 2002:a9d:6e0f:0:b0:6ab:75a1:ee1b with SMTP id e15-20020a9d6e0f000000b006ab75a1ee1bmr10504385otr.36.1684280511406; Tue, 16 May 2023 16:41:51 -0700 (PDT) Received: from [192.168.0.200] ([216.130.59.33]) by smtp.gmail.com with ESMTPSA id o13-20020a9d5c0d000000b006864b5f4650sm13036695otk.46.2023.05.16.16.41.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 May 2023 16:41:50 -0700 (PDT) Sender: Larry Finger Message-ID: Date: Tue, 16 May 2023 18:41:50 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: Driver for rtw8723ds Content-Language: en-US To: Martin Blumenstingl Cc: =?UTF-8?Q?Jernej_=c5=a0krabec?= , linux-wireless References: <72a8eeb1-c91c-80a7-5a09-1b7963e0996b@lwfinger.net> <3162376.5fSG56mABF@jernej-laptop> <1855371.CQOukoFCf9@jernej-laptop> <7106ab11-197d-e0d1-f54a-f56d438a022d@lwfinger.net> From: Larry Finger In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 5/16/23 13:48, Martin Blumenstingl wrote: > Hi Larry, > > On Tue, May 16, 2023 at 8:31 PM Larry Finger wrote: > [...] >>>> I'm out of time for today though so I cannot continue testing. >>> I took time during my lunch break for some more experiments and came >>> up with the attached patch (the vendor driver does something similar >>> and I only noticed that after I observed some rtw_rx_pkt_stat with >>> pkt_len being zero). >>> It survived 30 minutes of uptime, updating my system and several >>> iperf3 runs (in both directions). >>> iperf results: >>> - RX: 48 Mbit/s >>> - TX: 33 Mbit/s >>> >>> And to be clear, those results are with: >>> - the word IO bugfix >>> - the initial two patches from this series >>> - Larry's addition of the second RTL8723DS SDIO ID >>> - the attached patch >> >> Martin, >> >> Please send me a copy of the version of sdio.c that works. It seems likely that >> I got mine all messed up as the OP at GitHub is getting lots of warnings from >> net/mac80211/rx.c:803. > Please take the file from [0] - this is how I successfully tested it. Thanks. I got it and replaced the one in rtw88. Speedtest shows him getting a little over 40 Mbps. Thanks for the help from both of you, Larry