Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <351be742-6b4d-c9fd-5583-2a8b2b296d98@quicinc.com>
Date:   Wed, 17 May 2023 19:29:34 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: [PATCH] wifi: ath11k: Add rx histogram stats
To:     Ben Greear <greearb@candelatech.com>, <ath11k@lists.infradead.org>
CC:     <linux-wireless@vger.kernel.org>,
        Manikanta Pubbisetty <quic_mpubbise@quicinc.com>,
        Abinaya Kalaiselvan <quic_akalaise@quicinc.com>
References: <20230405132804.226681-1-quic_mkenna@quicinc.com>
 <1e0de6cd-4e43-273f-2222-1c52d2b6d95e@candelatech.com>
Content-Language: en-US
From:   Maharaja Kennadyrajan <quic_mkenna@quicinc.com>
In-Reply-To: <1e0de6cd-4e43-273f-2222-1c52d2b6d95e@candelatech.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 4/5/2023 7:05 PM, Ben Greear wrote:
> On 4/5/23 6:28 AM, Maharaja Kennadyrajan wrote:
>> Add peer specific debugfs support to store and
>> display peer rx stats info like HE, VHT, HT,
>> legacy and NSS.
>> Also, add a debugfs knob to reset rx stats
>> specific to the peer.
>>
>> This helps  to debug the throughput related
>> issues in the UL traffic(STA to AP) by getting
>> the segregated rx_stats info like HE, VHT, HT etc,.
>>
>> There is no addition of new debugfs_file here to get
>> these segregated stats. The exising rx_stats is enhanced
>> to get these stats.
>
> I'm a big fan of stats, so nice to see you adding this.
>
> I'd also suggest adding histogram for ampdu length if you can,
> as a sta sending series of 2 frames in ampdu vs sta sending a series
> of 64 frames in ampdu will get significantly different throughput.
>
> Thanks,
> Ben
>
Hi Ben,

Thanks for your feedback and we take your request.

We will send the patch later on your requirement.


Regards,

Maharaja