Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <43d01aa8-b594-2770-59d0-13e6388c5758@candelatech.com>
Date:   Thu, 18 May 2023 14:01:11 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH] wifi: mt76: mt7921: Support temp sensor.
Content-Language: en-US
To:     Lorenzo Bianconi <lorenzo@kernel.org>
Cc:     linux-wireless@vger.kernel.org
References: <20230518200718.1367381-1-greearb@candelatech.com>
 <ZGaNm8mMfbqdtWa0@lore-desk>
From:   Ben Greear <greearb@candelatech.com>
Organization: Candela Technologies
In-Reply-To: <ZGaNm8mMfbqdtWa0@lore-desk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 5/18/23 13:42, Lorenzo Bianconi wrote:
>> From: Ben Greear <greearb@candelatech.com>
>>
>> Allow sensors tool to read radio's temperature, example:
>>
>> mt7921_phy17-pci-1800
>> Adapter: PCI adapter
>> temp1:        +72.0°C
>>
>> Signed-off-by: Ben Greear <greearb@candelatech.com>
>> ---
>>   .../net/wireless/mediatek/mt76/mt7921/init.c  | 53 +++++++++++++++++++
>>   .../net/wireless/mediatek/mt76/mt7921/mcu.c   | 17 ++++++
>>   .../wireless/mediatek/mt76/mt7921/mt7921.h    |  1 +
>>   3 files changed, 71 insertions(+)
>>
>> diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/init.c b/drivers/net/wireless/mediatek/mt76/mt7921/init.c
>> index c15ce1a19000..18f0f2dfbbcf 100644
>> --- a/drivers/net/wireless/mediatek/mt76/mt7921/init.c
>> +++ b/drivers/net/wireless/mediatek/mt76/mt7921/init.c
>> @@ -2,6 +2,9 @@
>>   /* Copyright (C) 2020 MediaTek Inc. */
>>   
>>   #include <linux/etherdevice.h>
>> +#include <linux/hwmon.h>
>> +#include <linux/hwmon-sysfs.h>
>> +#include <linux/thermal.h>
>>   #include <linux/firmware.h>
>>   #include "mt7921.h"
>>   #include "../mt76_connac2_mac.h"
>> @@ -58,6 +61,50 @@ static const struct ieee80211_iface_combination if_comb_chanctx[] = {
>>   	}
>>   };
>>   
>> +static ssize_t mt7921_thermal_temp_show(struct device *dev,
>> +					struct device_attribute *attr,
>> +					char *buf)
>> +{
>> +	struct mt7921_phy *phy = dev_get_drvdata(dev);
>> +	int i = to_sensor_dev_attr(attr)->index;
>> +	int temperature;
>> +
>> +	switch (i) {
> 
> nit: you can drop i and just use to_sensor_dev_attr(attr)->index
> 
>> +	case 0:
> 
> I think you need to wake the device up here running mt7921_mutex_acquire
> before sending the mcu command.

I need to wake it up and acquire a mutex, or does acquiring the mutex wake it
automatically?

And, mt7915 has some other logic in this area.  I left the switch logic in
to match that, thinking maybe later we can add the other options to 7921?

Do you know if 7921 supports the other options like 7915?

Thanks,
Ben


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com