Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 19 May 2023 16:19:47 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     greearb@candelatech.com
Cc:     linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wifi: mt76: mt7921:  Support temp sensor.
Message-ID: <ZGeFgxR7OUkhPvTB@corigine.com>
References: <20230518200718.1367381-1-greearb@candelatech.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230518200718.1367381-1-greearb@candelatech.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y2tSc3VnaDRJUlpqSXNHNnpkTU5hbWhINHRGUDFxMnNla2l2QjBxNWNwTThV?=
 =?utf-8?B?a1p0NmRZNHBVanZKOC9URjNBOVVzSzNhS2JJRndKREhlMGtOeWdXaXgwSmlP?=
 =?utf-8?B?b0ZtMmNCS2V6ZmJUWDZtU0tJZFhJa0ZUWGJQTk8xL05aTmU1MFpzZjVPWllk?=
 =?utf-8?B?dXcxOFFhclIyRWNrZnpseDd1UHRqSlNQeCs5eWdOY3NvMXNTUjV0YVhLRjhs?=
 =?utf-8?B?K3k5NzdIbGtYelFpOUVMT1BlSmZVSHdqZG1rV3hJMEV1a1I5a1RydENSaE0w?=
 =?utf-8?B?NFF1dHNaQXNoQ2doZjI2T1ZwbVBuR0lPV1pEdW1xWEkrMGNudGhKOU5OZ0FZ?=
 =?utf-8?B?REJSRk5vQ1lmMlg5WS8zd24zZTczTVMvWnhmNG4yRFRuWEU1M2s1RFhGVnNS?=
 =?utf-8?B?cXF0bnZaZDZVYUlZK0lqbGRpdWtqMXI3NTFuV3NZZlFTSVIycm1xTWJaNVk3?=
 =?utf-8?B?bW1rNkJuUzdwMFJFRjF3TjNudHo3M0dTWlhtOTR0TTlQc0N6S3hTNHBFWmtO?=
 =?utf-8?B?b0VYNlZVeGxWbld5cGpoRmVmVCs4MmhtQ0NsdkhJK2hDZ0JWc3VjTHhTdmg1?=
 =?utf-8?B?aHhSbWFXQjhLWWRpVUNqb05nS3VJRGh6cTZNcng4Rm5uWTJpMzJwSHdJeVAw?=
 =?utf-8?B?aWU1UGdINDU3b0swbVV0Qkt1OVozdnNaMDVjdTE1SnZ4cG16bmh4ZUFSOTlp?=
 =?utf-8?B?MkhGL1luMkZ6N1o2MHErMXJtcXZWdlZJcUtHVFhOWTJNQ3pZTFRUTWhsWWJw?=
 =?utf-8?B?dVBJVXFMTXJVc0ZMbXNjbks2RjZyNW4yQXhVUUo0eDQ4YVAvejVaYU93SWhk?=
 =?utf-8?B?a2NNYVJkUUpVKzQzL2RhMnhvWjdnREN2V090dlFYaEdSWjhIVm5ITk55cHky?=
 =?utf-8?B?UWpJTklvSDZoekJKbUdMVnhqV2t2QzVVWXZpZ21DL0tVTkZuSEpDRTl0cVlD?=
 =?utf-8?B?SGFWMERJYWFGMStWTjU0LzM0RGlIVENZaGdaR1NibmcrZHhXdk56NWU5WThz?=
 =?utf-8?B?UHU2MHg2LzBEc1ZVbHp6ZzJxcmQ0VVpaaWMzMjBqb2dVTHNIKytqb1VVS0JS?=
 =?utf-8?B?RGVVV0JxeENoVlFXWkp3dGx3L09YaGYwVDNjdGVtMDl2b2dROTluR2t2OUcy?=
 =?utf-8?B?L3NKcVEyR2ZuNlo1VkNVR2hEN0czYTZ0VmdTdG04QjBJT2dZV3JKakwrK2pv?=
 =?utf-8?B?dmVLcm9qZ3JJK25SOUJhdGZlVmtTb1dKNURRUE1QVXozMUVlNG1UQ0xxQzU4?=
 =?utf-8?B?SVJTT09lR29EWndmOEJEVkZnaDI3OXQ4UG9GVlNaOEI3dzBBVUdQTHRRTWg3?=
 =?utf-8?B?aEVtY1daWi9YRVFNS2JoZnpPaVRiOEdvWldJcEs4eWY0NjFjcmlSR2wxRUtp?=
 =?utf-8?B?bVZISEFsVmtJK2lpcDg0VENpWDVVVlRaUlMyRjJ0bUErVW5KV0xJSGRmNjVB?=
 =?utf-8?B?V1UwcW1mQ0RDOHp3bi9nVkJQUS84Sm9Md0V1TkVjU3p2K0ErT3JCcUlwd3Jo?=
 =?utf-8?B?MXBKTHo4Z2U0RmRqQi8zRGFBUEJzaytmaExSRjdqUm81Vzh1eWVBRVEvaGNL?=
 =?utf-8?B?cW1DZEUrckVhd1R3NUZrRUE0QVQyUFpZRm1Id2NqNDhZcXpMaWU0MmZ6d0dn?=
 =?utf-8?B?WlU5SWo0TnUwL1kwdm42SUIwYzR4UEtrNFBXVkFtTjdOZENpbk5mTEV5bHRE?=
 =?utf-8?B?ZGRKWU11K2RMQythRU9obFRncHRYeStQWXUxYjZNOEZEZEVwcXhjU3dUUVMx?=
 =?utf-8?B?UDRxaXQyYk1zL0hYLzZCWW1NNU1EaGkwWnVmcDB6QXRVRXJVNlpydHVBaVFL?=
 =?utf-8?B?b3YrV3ZpYksvZzEzaEVqR1FLazlCQWdUU3VXUkoyeGdkaVFweVNtUHpscC9s?=
 =?utf-8?B?M25aRVArOWc3elJLVU43QXBYUjlpMnFVTFVQZ1FTVU4wWnZNeXdxUGQ1SGVN?=
 =?utf-8?B?ZWgvSDJaRGNmZ3d1ckxweVZGdkVTMURJSFJtU3JlY2dSaGp4Q3VJbkRsRUVC?=
 =?utf-8?B?Q1dscTYwR1FUYjl3WTRBYVY4clBLTkcwOFhFUDNCTnFzczVNdUh3OFRESFM2?=
 =?utf-8?B?VGdCZ3UrbUo1UVFsSlVZbU1pNFFDOW4rUGl4ZXVsbUpTRVhHbmNPL2hDUSta?=
 =?utf-8?B?cDNPUS9XRnJ3blVpU2JzQ09XVjFoY0dYNVQxdS9qN3pqL2FhZVdxV1hkOWxq?=
 =?utf-8?B?eitNaG9LRUhqRW9yV1l0R2kzZkZmYVZ0Qi9nN0t4VlBwY1FkUnh6TXVYQnRZ?=
 =?utf-8?B?dytDMTIyWDRoZ2U5ZGloZkc1NWhRPT0=?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 69e845ee-dd18-4a2b-598f-08db58741ced
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2023 14:19:52.9584
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QoGkEaTv3kg4UAwEI+jCv1Us/rk1wgzcYst7vzfx9+bp0BQmw9Q4PHwUI8Wpm97hZKSq9hrzPJdVctNrJ71LuzeTt0B90x81OeKKjAvcsGk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR13MB4739
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Thu, May 18, 2023 at 01:07:18PM -0700, greearb@candelatech.com wrote:
> From: Ben Greear <greearb@candelatech.com>
> 
> Allow sensors tool to read radio's temperature, example:
> 
> mt7921_phy17-pci-1800
> Adapter: PCI adapter
> temp1:        +72.0°C
> 
> Signed-off-by: Ben Greear <greearb@candelatech.com>
> ---
>  .../net/wireless/mediatek/mt76/mt7921/init.c  | 53 +++++++++++++++++++
>  .../net/wireless/mediatek/mt76/mt7921/mcu.c   | 17 ++++++
>  .../wireless/mediatek/mt76/mt7921/mt7921.h    |  1 +
>  3 files changed, 71 insertions(+)
> 
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/init.c b/drivers/net/wireless/mediatek/mt76/mt7921/init.c
> index c15ce1a19000..18f0f2dfbbcf 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7921/init.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7921/init.c
> @@ -2,6 +2,9 @@
>  /* Copyright (C) 2020 MediaTek Inc. */
>  
>  #include <linux/etherdevice.h>
> +#include <linux/hwmon.h>
> +#include <linux/hwmon-sysfs.h>
> +#include <linux/thermal.h>
>  #include <linux/firmware.h>
>  #include "mt7921.h"
>  #include "../mt76_connac2_mac.h"
> @@ -58,6 +61,50 @@ static const struct ieee80211_iface_combination if_comb_chanctx[] = {
>  	}
>  };
>  
> +static ssize_t mt7921_thermal_temp_show(struct device *dev,
> +					struct device_attribute *attr,
> +					char *buf)
> +{
> +	struct mt7921_phy *phy = dev_get_drvdata(dev);
> +	int i = to_sensor_dev_attr(attr)->index;
> +	int temperature;
> +
> +	switch (i) {
> +	case 0:
> +		temperature = mt7921_mcu_get_temperature(phy);
> +		if (temperature < 0)
> +			return temperature;
> +		/* display in millidegree celcius */

Hi Ben,

a minor nit from my side: s/celcius/Celsius/

> +		return sprintf(buf, "%u\n", temperature * 1000);
> +	default:
> +		return -EINVAL;
> +	}
> +}

...