Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230518161749.1311949-1-martin.blumenstingl@googlemail.com>
 <20230518161749.1311949-5-martin.blumenstingl@googlemail.com> <c52c11c712e24e1fb783c2ce1251aba5@realtek.com>
In-Reply-To: <c52c11c712e24e1fb783c2ce1251aba5@realtek.com>
From:   Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Date:   Mon, 22 May 2023 22:13:26 +0200
Message-ID: <CAFBinCC+Lz7uGBAuK5gQ-2ngutcgNG5EN4TTdM5tdFQB5uXtqw@mail.gmail.com>
Subject: Re: [PATCH wireless-next v1 4/4] wifi: rtw88: Add support for the
 SDIO based RTL8723DS chipset
To:     Ping-Ke Shih <pkshih@realtek.com>
Cc:     "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
        "kvalo@kernel.org" <kvalo@kernel.org>,
        "tony0620emma@gmail.com" <tony0620emma@gmail.com>,
        Peter Robinson <pbrobinson@gmail.com>,
        "jernej.skrabec@gmail.com" <jernej.skrabec@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, May 22, 2023 at 3:49=E2=80=AFAM Ping-Ke Shih <pkshih@realtek.com> w=
rote:
>
>
>
> > -----Original Message-----
> > From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> > Sent: Friday, May 19, 2023 12:18 AM
> > To: linux-wireless@vger.kernel.org
> > Cc: linux-mmc@vger.kernel.org; linux-kernel@vger.kernel.org; ulf.hansso=
n@linaro.org; kvalo@kernel.org;
> > tony0620emma@gmail.com; Peter Robinson <pbrobinson@gmail.com>; Ping-Ke =
Shih <pkshih@realtek.com>;
> > jernej.skrabec@gmail.com; Martin Blumenstingl <martin.blumenstingl@goog=
lemail.com>
> > Subject: [PATCH wireless-next v1 4/4] wifi: rtw88: Add support for the =
SDIO based RTL8723DS chipset
> >
> > Wire up RTL8723DS chipset support using the rtw88 SDIO HCI code as well
> > as the existing RTL8723D chipset code.
> >
> > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>
> I'm so surprised that this small patchset can support an new chip. Nice j=
ob. :-)
Please also take it as feedback/learning for yourself and to your team
at Realtek:
In my opinion the rtw88 driver is a good piece of software and it
shows why it is the first choice that Jernej and I had in mind when
thinking about future RTL8723BS support.

> Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>
Thank you!


Best regards,
Martin