Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 23 May 2023 12:32:34 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     greearb@candelatech.com
Cc:     linux-wireless@vger.kernel.org
Subject: Re: [PATCH v3] wifi: iwlwifi: add ethtool tx and rx stats.
Message-ID: <ZGyWQpFs9DDAlsx6@corigine.com>
References: <20230522233743.3058844-1-greearb@candelatech.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230522233743.3058844-1-greearb@candelatech.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hPaRB6yoLm+bYj4GgY9dG9IEuCNR25LQ2ixA+jdo2Y53FnnrcACiX+i6+fCL?=
 =?us-ascii?Q?/6X8G28yshpCyyiIThTEiT6hp9UMPxktWUYsRXWWzslldDMo0k0pK5LtMVVd?=
 =?us-ascii?Q?yz4wxg+OUiDEL0/DLrZIRhiVqzHKfL9WNLOxyAItCO8bhG5T4Jzy4ntJV+W8?=
 =?us-ascii?Q?6wuWs/u+RDqNvWex/U462luO0SWpbI+P5+0GC1LeuU2q5PPW7oIqEUlxA+vg?=
 =?us-ascii?Q?07CorGjKD9vhbd1abG84hoUFpa5zRFP4kQfmd2SzW9V9orvnwOhD1eR+psfi?=
 =?us-ascii?Q?kjjJ9aKPiqKTDxOerxDsu4WiqGjOoGFRB8yP84OZ//6EK7Q4Y/Wh5yQCtrhl?=
 =?us-ascii?Q?DitI0AT7nHFTXqSKuDKUgLRCLJFlph2qhZRkqJ5alojSjeSoj6L1HhqDJvWI?=
 =?us-ascii?Q?PklCG7uUxc0KBP4Pzwjm/GNc25f5if3LVRMQlTRyFK2L0DbBRpLwRHISMuGQ?=
 =?us-ascii?Q?OuPyHsVstxI9g3fYKQSntJpE82+cMn0lXlEg+km1PrxQ/ZuhRdKhcDNBkZi/?=
 =?us-ascii?Q?fBBuJJYgM5cBCboAfc5IP2lDN9/TdXS4jHvU0epCxwIx3QpImZa4zuzjVw1/?=
 =?us-ascii?Q?/BUIUQ94Mz83iaT/AqS+DniaJHpC8HjBtzIcX5cdTjMIFZbIP+DIgsx/GzSf?=
 =?us-ascii?Q?+9yfJN41NFA9AHriMfQwPm3jN7W5+NqkObIyNry6i51286vPwcrsXw+Y78ir?=
 =?us-ascii?Q?1+jQfcxFUViMVgUWyZQDwmWU4pV87+FiER8bX2n0bGCkYiHDcpuhHN3t9XU+?=
 =?us-ascii?Q?QKHBK9NhilDeUWdOoea9Wn3l3auCSScDjnef3HXOjZpcqYwKIzRDkxLLWmlF?=
 =?us-ascii?Q?ITWKpG7NUIzjmDGsAhuU1W03FMjaMo4xrOKZeCqc7Zn3zRSDV5RxOpGTwjxR?=
 =?us-ascii?Q?d4VBUQVzABN6jV7SjYO6T9s/KgGBf/0wmLP56ZkHEH6a8YP0JkF9O5XwyF8T?=
 =?us-ascii?Q?3g/w7VdsVaeQxRD0HPmVlA97OOu83CEGljSDBiJrzXRgw2zb6Yki2hGlLtMx?=
 =?us-ascii?Q?3X6GrGJ56cEtV0ddbsTwGgBR4YcN/FQP/jUwA5uc1pyyhd1VEyJtK1mZCRVK?=
 =?us-ascii?Q?1VeqL+CbcQ1EsG892P0d9x4vs2LuWnZobl/rWGT2ZjsY1ybRLHViU3fcqJJt?=
 =?us-ascii?Q?a2p+jN0ks37kA5nuRXMzdg1CkXI4qrbBHmhVp8U5Tjg/N8B5fBFQgWusZnLA?=
 =?us-ascii?Q?bbSul/Q9PT9cHnwK1zp5QuvTyyMraCrE9fxFU5MSKqtVUu/rmSou4BEZoyqv?=
 =?us-ascii?Q?XwjuHuNm0epruXcsfPg/tHC1+Ap8jVkF/vUuvFGTSGmZMm3qOZygy7lBru9Z?=
 =?us-ascii?Q?g3PVbnwvoe2KxRkWugmRx0WzJBx4OI6LlD4V0FwGjjJXxx80EdVpSB+6Km2P?=
 =?us-ascii?Q?yWUURiZnWYZwQj4sjieYHxo+WDe2O3yrcc0w3kXyHX2mqtrvLgkeeLSzabqp?=
 =?us-ascii?Q?Nk25WW1+4q9c3XSYyug5I+9O7zxFt5E9+bhTjTv3pAVbqcxVlXNLY8QYDhaM?=
 =?us-ascii?Q?MBWWHgBEEN2SFn9h0DGXW1ZB3IeK+YkGla6tEqtTw2QN2V7Hq7ddEZ1GszT8?=
 =?us-ascii?Q?Z2IDct5Kexw2dKEtPEh0hD3EPgj5tSQWjpfzY15oEC9UtCvfCO1Ff9CcXzZE?=
 =?us-ascii?Q?FyG348KvZFIBxun3UlOkF7EE2MFB3H5/Zcd7ZA6UneY+blNr5Yi+hXFfaTVP?=
 =?us-ascii?Q?C587HQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6c112a62-1691-4733-daa6-08db5b790893
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2023 10:32:39.7296
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3685X4EmnodGidU9ulnPMtNsLLSX4o9E5vb4WiaPxZe3oZCH2WAu6OHN2i6eN5deDkbmS7++RhhB/qq8zQXsppC5lM6jcBTggECU7ZFWJVc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR13MB4523
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Mon, May 22, 2023 at 04:37:43PM -0700, greearb@candelatech.com wrote:
> From: Ben Greear <greearb@candelatech.com>
> 
> Report tx/rx error codes, nss, mcs, bandwidth, mode, he types,
> tx ampdu length histogram.
> 
> To provide some clues about how transmit and receive path is
> actually working.
> 
> Signed-off-by: Ben Greear <greearb@candelatech.com>
> ---
> 
> v3:  Combine tx and rx ethtool patches into single patch.
> Fix some stats calculations, especially the path that consumes
> tx frames based on block-ack receipt.
> 
> Comparing the stats with expected values now matches better, but
> hard to verify everything exactly.

Hi Ben,

I am a little (lot) confused about what tree/branch this patch applies to.