Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp4448230rwd; Tue, 23 May 2023 07:53:47 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6ER1nRlXm2W+ZyvLdoPpomFF4jVpiodBpiXzB6qInxHtgAQ90w/689gFTArlC2rskpDx+e X-Received: by 2002:a05:6a20:7f83:b0:10b:4e9c:ee25 with SMTP id d3-20020a056a207f8300b0010b4e9cee25mr9339059pzj.16.1684853627311; Tue, 23 May 2023 07:53:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684853627; cv=none; d=google.com; s=arc-20160816; b=itV3J7GnDIIsKVDGEbDkHURA4ZfbvTQg86RMpPNQO1ja6REfLJbccTxqThDNoXUQ9w o0cRex7GiZ2eemjXxe/2VGtB4FyFXyuHRCMvnmxTxQ7YHu9XzQvKnLM/poakQoS/BI3G tFLOlAEm75lRNc6/e8VAzZtAaNjS3kvPOW3xV6n4ODKCiy4bvVD5KeF9d09fR4d/fJdn 8UjaPL4JFj9Slh21SyCDnxUOfqVOwoWs86V1T3tVi1iUocvg3o8yMYasUur+E3e+0l19 N4lm1b91N5+AX3nEY8Gk2z7EtzrFk/ahb6HpXJGLaB1+mKLppyniVfxfVGSrQRzF9dXG Byjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:organization :from:references:cc:to:subject:dkim-signature:dkim-filter; bh=X15Gqcxd/klDdbMDIc22BEqAVzpy+pYKCpkdrmN6gZ0=; b=ElgblyiwNU3y2vBgveOmlJ9F5b+TmcDfU6o6CwTJjTRDme7TO4YrvZKwhLrV65PwQ9 JR4y3tFauaeuNwXT8WlVmEvCLBbUczm/tiCwu74RFVg2DuabhVTl/zdmKDEXscpCgosL Z4t/++XjBrIwIiSLlvcNkob4f7LCnJj9lTM/CGX8iSDnID+tAMOoH4oHwWl8qs3PEOHA IkhgulpzYFk1ACoeuSQcCNTVkFwLyK9SeuhR1KTGM4lhS1rH1XqBn3+kiPW9aBZNz8lX Uc3yqsLe3dgXWdz9BuLjloFLG74bm5DgN/UznzaenTP2UTnjakWlgmetFFI8PPk34jVp 0nrQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@candelatech.com header.s=default header.b=NDu9Qbcu; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=candelatech.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s11-20020a63770b000000b0050f6925a400si2454551pgc.589.2023.05.23.07.53.35; Tue, 23 May 2023 07:53:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@candelatech.com header.s=default header.b=NDu9Qbcu; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=candelatech.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236608AbjEWOu1 (ORCPT + 63 others); Tue, 23 May 2023 10:50:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232592AbjEWOu0 (ORCPT ); Tue, 23 May 2023 10:50:26 -0400 Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B83EDFA for ; Tue, 23 May 2023 07:50:25 -0700 (PDT) X-Virus-Scanned: Proofpoint Essentials engine Received: from mail3.candelatech.com (mail2.candelatech.com [208.74.158.173]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id DE1F1100081; Tue, 23 May 2023 14:50:23 +0000 (UTC) Received: from [192.168.1.115] (unknown [98.97.34.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail3.candelatech.com (Postfix) with ESMTPSA id 2EEAD13C2B0; Tue, 23 May 2023 07:50:23 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 mail3.candelatech.com 2EEAD13C2B0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=candelatech.com; s=default; t=1684853423; bh=+SorzLhpXWInbWLa8bxDTJvLV8FwBoLKmmxV9TKds3Y=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=NDu9QbcuZDVCsulAEawdyRuF8hVtAYR751pWCvk+5/bc10dT1hCZn21DZsWFCpWy4 Pb0yeFhxPq/b4nKR/p0qGdHdN10UV+hPRU/AWraSqOu+POTHr5QjBj51xgV5L1SjXQ 4Ga6xx0LwEhh83xt3mEtowtyjKZik+QaGij//trg= Subject: Re: [PATCH v3] wifi: iwlwifi: add ethtool tx and rx stats. To: Simon Horman Cc: linux-wireless@vger.kernel.org References: <20230522233743.3058844-1-greearb@candelatech.com> From: Ben Greear Organization: Candela Technologies Message-ID: Date: Tue, 23 May 2023 07:50:22 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-MW Content-Transfer-Encoding: 7bit X-MDID: 1684853424-62Ko2f9vYKje X-MDID-O: us5;ut7;1684853424;62Ko2f9vYKje;;49bee47f74cdb6ff280383f8e23073c8 X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 5/23/23 3:32 AM, Simon Horman wrote: > On Mon, May 22, 2023 at 04:37:43PM -0700, greearb@candelatech.com wrote: >> From: Ben Greear >> >> Report tx/rx error codes, nss, mcs, bandwidth, mode, he types, >> tx ampdu length histogram. >> >> To provide some clues about how transmit and receive path is >> actually working. >> >> Signed-off-by: Ben Greear >> --- >> >> v3: Combine tx and rx ethtool patches into single patch. >> Fix some stats calculations, especially the path that consumes >> tx frames based on block-ack receipt. >> >> Comparing the stats with expected values now matches better, but >> hard to verify everything exactly. > > Hi Ben, > > I am a little (lot) confused about what tree/branch this patch applies to. > It is against upstream iwlwifi-backports driver. I need to use that to use latest Intel radio, and in general flow of patches seems to be iwlwif-backports -> kernel, so I was hoping the patch had a chance that way. I'm sure it could also be patched into the kernel with a bit of work, and I'll be happy to do that work if that will make patch acceptable. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com