Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     Larry Finger <Larry.Finger@lwfinger.net>
Cc:     Jernej =?utf-8?Q?=C5=A0krabec?= <jernej.skrabec@gmail.com>,
        Ping-Ke Shih <pkshih@realtek.com>,
        Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
        "linux-wireless\@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "tony0620emma\@gmail.com" <tony0620emma@gmail.com>
Subject: Re: wifi: rtw88: questions about adding support for RTL8723DS/RTL8723BS
References: <CAFBinCD=HVyedXpqRfAC=m3A=wstDbtQfLDZqjHufSawdLKwiw@mail.gmail.com>
        <5a47af41569c4f0b91d6d2bc054586d0@realtek.com>
        <CAFBinCD3nPPHUmtoqRch87SOXpLcfrzOT7SDdsJdGe-KGOK9Mg@mail.gmail.com>
        <5673351.DvuYhMxLoT@jernej-laptop>
        <e2dc78fd-014a-14d1-9b4e-9ad251e1d9e1@lwfinger.net>
Date:   Wed, 24 May 2023 12:53:49 +0300
In-Reply-To: <e2dc78fd-014a-14d1-9b4e-9ad251e1d9e1@lwfinger.net> (Larry
        Finger's message of "Thu, 18 May 2023 13:48:28 -0500")
Message-ID: <87lehekqc2.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Larry Finger <Larry.Finger@lwfinger.net> writes:

>>>> To make rtlwifi support SDIO is another way. It seems like add a HCI is
>>>> easier than an new chip, and we can have a simple support list of rtlwifi
>>>> and rtw88 eventually, like
>>>>
>>>>          rtlwifi       rtw88
>>>> 8723BE    o
>>>> 8723BS    o?
>>>> 8723DE                  o
>>>> 8723DS                  o
>>> Per chip support matrix is:
>>> 8723BE: rtlwifi
>>> 8723BU: rtl8xxxu
>>> 8723BS: staging driver which I'd like to replace
>>> 8723DE/U/S: rtw88
>>>
>>> HCI support matrix:
>>> rtlwifi: PCIe, USB
>>> rtl8xxxu: USB
>>> rtw88: PCIe, USB and SDIO
>>>
>>> So it seems you are right: I should consider whether adding RTL8723BS
>>> support to rtw88 is the right choice.
>>
>> While rtw88 might not be best choice by above matrix, it seems to be most
>> featureful, stable and at least from what I saw, easiest to add new variants.
>>
>> I'll do a bit of experiment with rtw88 to see how hard it would be...
>>
>> Best regards,
>> Jernej
>
> Now that RTL8192CU is being handled, the USB part of rtlwifi is being
> considered for deletion. If you decide in terms of adding RTL8723BS to
> rtlwifi, please let me know.

From higher level point of view I would prefer rtlwifi going away in the
long run and the development focus be on rtl8xxxu, rtw88 and rtw89. So
if at all possible, please avoid adding new hardware support to rtlwifi.

But of course I'm not familiar with Realtek designs so please do correct
if I'm missing something :)

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches