Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 24 May 2023 13:34:52 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Sascha Hauer <s.hauer@pengutronix.de>
Cc:     linux-wireless <linux-wireless@vger.kernel.org>,
        Hans Ulli Kroll <linux@ulli-kroll.de>,
        Larry Finger <Larry.Finger@lwfinger.net>,
        Pkshih <pkshih@realtek.com>, Tim K <tpkuester@gmail.com>,
        "Alex G ." <mr.nuke.me@gmail.com>,
        Nick Morrow <morrownr@gmail.com>,
        Viktor Petrenko <g0000ga@gmail.com>,
        Andreas Henriksson <andreas@fatal.se>,
        ValdikSS <iam@valdikss.org.ru>, kernel@pengutronix.de,
        petter@technux.se
Subject: Re: [PATCH] wifi: rtw88: usb: silence log flooding error message
Message-ID: <ZG32XKBsAub+Y+bO@corigine.com>
References: <20230524103934.1019096-1-s.hauer@pengutronix.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230524103934.1019096-1-s.hauer@pengutronix.de>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7WSYJVz9qUMetMBBjKxUz+bo5iThPCsUOLdtsRveEOrDq+GDSSH/B7KBAkuL?=
 =?us-ascii?Q?ArGtK+KJ1wMdQQe2YZS2z3x/4IeIrygfPP6TXF1hpqmfxH8+60EhHVzi3MGX?=
 =?us-ascii?Q?AwLd95P58CMNKabwVgLV6O6TgMy0lOJOksvnCPiAtfdiHTppXiRyxFQwhNc5?=
 =?us-ascii?Q?RIvZa97YmA0Nm36f2u3I1NMvpBtFeicWxqgJ46Vzp7JAEdXfJR4sl4tcX7RZ?=
 =?us-ascii?Q?3x9aSKqo059n1lRX9d6yriXlR9AusgyPwj6IgMsVNCLURJKoxW4G7YkFzAof?=
 =?us-ascii?Q?h43JcW+r8M42OxCM1BnGo4l6v92CdRZ7OJkYfTzFZtqJWRvwq56NDa1OX+T3?=
 =?us-ascii?Q?pbe9jux3Uc3q/DxM3sQJvRmXGH9c3/HlItiNEXJc9sAycDu6+NmQr2rsftnM?=
 =?us-ascii?Q?oNbr/Jj4KIpjRi+IAnHZueIsgfqw3m88wpRGTMbCXU5ZizQJgB5D5KXI7k8H?=
 =?us-ascii?Q?fn6yMg75hBgHeafdCH+yGtZwMJ0sHzlSpFM7Cih3VF8/zGmWwarE74xdb9rV?=
 =?us-ascii?Q?Gp9BCf+5K0B1WzxUcxpWgYHFDlFU9WGFy6i4isz3f5ICHoa7WD4s09Jena4I?=
 =?us-ascii?Q?chF+vT6dQdlQOiFXzn5GYQ3M1PpGVGkp0JnDL291QSPR9rZ54AMkFmWNLezp?=
 =?us-ascii?Q?aCHoEBQWvdd0hUIwhd74/2CPS2qXlpxMD9aGyrwuD8YTQDDw17HUr/1oxe9A?=
 =?us-ascii?Q?G8j2KkW7BEh22C4USwT608O4wj/ArrDu6WfAq1fXRuVlTHF8guVpl/aqMpuU?=
 =?us-ascii?Q?R9KJeBQp2BYUjzhsMwHY1lVGtLkkk4fK/M+FPou5VEtS2Xms9ulszkiZc9Ph?=
 =?us-ascii?Q?VjnIAcgs6xMNGD4aaT6neo4/PXB18cvFIiXjNRY/h2bysXDNUwDTPoI2rL4J?=
 =?us-ascii?Q?bHzNONNs0xjnWgU2eMgj7VdXAgqZO7LGQ9W1JXiQkPiB7u3FVUddmlT5bsf4?=
 =?us-ascii?Q?Rij4hONC4LLrl3a0FFIlcVKLA4mnijK2j+BRBdc9A50UBpDJyO+9hpdz3+sR?=
 =?us-ascii?Q?aoYQfqt6aeArudqTMuKiszvQ4XXdBy6M1yvrkITXpVspGkl36d5bGX92lQ6I?=
 =?us-ascii?Q?0fcsQV8EPQQYP9GmfhC16gt1ArXbfTfzOq6oYGfu+pO9uKH6kwbTBK1HQ/gJ?=
 =?us-ascii?Q?qf1u1R/mvzSLOvIQsLqw00qsKKtRju/1nIEDb+Cg3tP02EJO9l9DpAboGYgh?=
 =?us-ascii?Q?rvcnAmCmcLTU6skTk3VDyudUWRXhxg//1tRFI1U4xh0GgxRvubWewnQ0bfhn?=
 =?us-ascii?Q?iIvv6iF18GVYqhPZQA65fyHCleoHlBxCIndllW7yoy/3FNAVlsJ8jpM0fR/b?=
 =?us-ascii?Q?o5Hq5BXKry52KtL43OSeOH9lHgy0i4TVSA4iTKXi/Y0FGs2p0FtipY6ksnB5?=
 =?us-ascii?Q?0i9+lGEkUfGgZKdpHkCEdcPiV649sRPPBu0yg5Rqu0YjtukrO/ZO9P0xUcRO?=
 =?us-ascii?Q?eQBlVR1KmgaBGQVgUQfBcIuZUWffmJQ+9KymfBxVs/5/mTGaU4YjMpbzk0Z3?=
 =?us-ascii?Q?qCjiKmB5vYrt1cgMbfwO0H7dxBfc0tjzUijatC27Zs9HEby8GsQrkOTMqPlL?=
 =?us-ascii?Q?dG67+evmhHnDXwdo8nQA2p33a+S3lSBgAfk3NP3BdS1y0fKjSYQUGlC3EbGr?=
 =?us-ascii?Q?Q+MMcy590me3q4ZB8PsAeAa76KmsU8nhFEsv9PKLl3CGSUHu6Yo/LcChh71S?=
 =?us-ascii?Q?8ld55g=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3dc1f238-8f2b-4005-fc0c-08db5c4ae7bf
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2023 11:34:59.0866
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xvYRSttN2IDgwXKw+5MQSN21tCTsiUskP62kNJ+tNBVLOOnWUwQpPP726VgZuBvS8hHqW58MogUSo0qxKYGQzvKpE5f3JkdLvyKOuoIL6t4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR13MB5516
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Wed, May 24, 2023 at 12:39:34PM +0200, Sascha Hauer wrote:
> When receiving more rx packets than the kernel can handle the driver
> drops the packets and issues an error message. This is bad for two
> reasons. The logs are flooded with myriads of messages, but then time
> consumed for printing messages in that critical code path brings down
> the device. After some time of excessive rx load the driver responds
> with:
> 
> rtw_8822cu 1-1:1.2: failed to get tx report from firmware
> rtw_8822cu 1-1:1.2: firmware failed to report density after scan
> rtw_8822cu 1-1:1.2: firmware failed to report density after scan
> 
> The device stops working until being replugged.
> 
> Fix this by lowering the priority to debug level and also by
> ratelimiting it.
> 
> Fixes: a82dfd33d1237 ("wifi: rtw88: Add common USB chip support")
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
>  drivers/net/wireless/realtek/rtw88/usb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtw88/usb.c b/drivers/net/wireless/realtek/rtw88/usb.c
> index 44a5fafb99055..976eafa739a2d 100644
> --- a/drivers/net/wireless/realtek/rtw88/usb.c
> +++ b/drivers/net/wireless/realtek/rtw88/usb.c
> @@ -535,7 +535,7 @@ static void rtw_usb_rx_handler(struct work_struct *work)
>  		}
>  
>  		if (skb_queue_len(&rtwusb->rx_queue) >= RTW_USB_MAX_RXQ_LEN) {
> -			rtw_err(rtwdev, "failed to get rx_queue, overflow\n");
> +			dev_dbg_ratelimited(rtwdev->dev, "failed to get rx_queue, overflow\n");

This is certainly an improvement. But as I understand things
it is still somewhat verbose if the condition persists.
Did you consider dev_dbg_once()?

>  			dev_kfree_skb_any(skb);
>  			continue;
>  		}
> -- 
> 2.39.2
>