Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp515474rwd; Sat, 27 May 2023 01:33:59 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5ysBoT86xJ2jr0iD4yVYIEpIJ3VNxr0zLhza8BQN4gMXs1Ja5Y0dD0DdKvyrOMsge7MSqn X-Received: by 2002:a17:90a:1617:b0:250:a4f5:fb34 with SMTP id n23-20020a17090a161700b00250a4f5fb34mr5096190pja.2.1685176438824; Sat, 27 May 2023 01:33:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685176438; cv=none; d=google.com; s=arc-20160816; b=Gm5YVhwg1CHwCvG2ULtYsEXpLr0JQDGVGq6NrRR0im1NiKEhF7C5GANjYyeKel2Nfi LbQlfauL8yDS4TweS0Ebj9tcwsx1sd+/zH86Y0FjmKgqNsST2k6VycgSJSYR35iD+b35 uGIgB/Lzy5r0d7MNlZrT+qaZuKw4FfkOT9J13zzQAHP8wHKXwCqGFpJbkM+dA9Oc6Q4K FnYi/LWPI8BW+fyOFQ6hLQTHsta3630hEYdRhuKYtd9M33cuMFE3xcWWbpz/Q+LfMdd0 FGb1sH5Y2xXWDXuNIyEdeOCPD7zF552UrrFe4EEaR1WTxYa1bEDwMGp6MkxNrYL4olUh Kqdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=7hmZPX8dT7Jueyxxz6a7UZ2ChE4sU6whExavmUoxHs4=; b=iLRmflrkx8+T7ho3h1qME3l7wCRwmJCIustSSL8IKiVo7FXyOdrMfBhEqI+cNa5kVK x61aV4UP8WtoNoRg1B+uiw0kwP0y5YP6LSDacVlPGNgWAxzcuX/NVT1DZvcehmhyq01d 3CZoQevm/EoGeWT9kTCZVbIJTIUrd8+wk9cQ61q+7GHB7UZKqFWWZtosOy+ASTkIscDq 2FqBx/lH7T1w8R9DGO9XH4WfWezIhE46CqnKM/GwKVWZh+n2RIeXO/HWLhiXK+GZHqCx KBWiSRSwDpdCjxDybLL7R67QpZovHSbeY81bhwK0W7zmsR80kLQkUyfE6NPEFtXr7AyW 33Cg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EzD5IXSV; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a12-20020a17090a854c00b0025649fb6758si1234106pjw.170.2023.05.27.01.33.49; Sat, 27 May 2023 01:33:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EzD5IXSV; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231772AbjE0Ibv (ORCPT + 63 others); Sat, 27 May 2023 04:31:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231726AbjE0Ibt (ORCPT ); Sat, 27 May 2023 04:31:49 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58A76F3 for ; Sat, 27 May 2023 01:31:47 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D081F608D5 for ; Sat, 27 May 2023 08:31:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5F407C433EF; Sat, 27 May 2023 08:31:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685176306; bh=547n+5c8K+MDEglbwG9LGEaBa3KvZRN1jnqEom9nLb8=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=EzD5IXSVCJBAi4tj9R7xKETFuyxGbhGcd+fDSr03eUOOdUmM3QFsNSasjUHfa+C9G R6o7ZPSy6bBTTZwzJmadVAYzYLFDpvhAe4tU8fkmgaAVzByNWyAm05jETePBg61rEz hhCWI6szeOcK36sTXDL5wKZPFfsqrqryP5l0a6XHFBT4VdjQFK/D5fpjjDtHmrnSLd 8HCfV3LodXb9YkiIFs7t74fSeZXm3f+rXt5MbnfD7eS+/piOwfXq3ibedhqbPRqvvp i7ibsYce1Ie8Bw4F3u52MdmRsPTnxtZpJ+mWD6gFufBkWMO8Gka4N9CprUkPVM9W0o QhbsJkY3/LD1Q== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: rtw88: usb: silence log flooding error message From: Kalle Valo In-Reply-To: <20230524103934.1019096-1-s.hauer@pengutronix.de> References: <20230524103934.1019096-1-s.hauer@pengutronix.de> To: Sascha Hauer Cc: linux-wireless , Hans Ulli Kroll , Larry Finger , Pkshih , Tim K , "Alex G ." , Nick Morrow , Viktor Petrenko , Andreas Henriksson , ValdikSS , kernel@pengutronix.de, petter@technux.se, Sascha Hauer User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <168517630118.21544.2267680746869698839.kvalo@kernel.org> Date: Sat, 27 May 2023 08:31:43 +0000 (UTC) X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Sascha Hauer wrote: > When receiving more rx packets than the kernel can handle the driver > drops the packets and issues an error message. This is bad for two > reasons. The logs are flooded with myriads of messages, but then time > consumed for printing messages in that critical code path brings down > the device. After some time of excessive rx load the driver responds > with: > > rtw_8822cu 1-1:1.2: failed to get tx report from firmware > rtw_8822cu 1-1:1.2: firmware failed to report density after scan > rtw_8822cu 1-1:1.2: firmware failed to report density after scan > > The device stops working until being replugged. > > Fix this by lowering the priority to debug level and also by > ratelimiting it. > > Fixes: a82dfd33d1237 ("wifi: rtw88: Add common USB chip support") > Signed-off-by: Sascha Hauer > Reviewed-by: Ping-Ke Shih Patch applied to wireless-next.git, thanks. 1f1784a59caf wifi: rtw88: usb: silence log flooding error message -- https://patchwork.kernel.org/project/linux-wireless/patch/20230524103934.1019096-1-s.hauer@pengutronix.de/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches