Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Larry Finger <larry.finger@gmail.com>
Message-ID: <e89ad5e5-1ec9-4d0c-f33c-363169fae8a5@lwfinger.net>
Date:   Sun, 28 May 2023 12:43:15 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH 0/3] wifi: rtw88/89: add PS calculation to repair PS mode
Content-Language: en-US
To:     Ping-Ke Shih <pkshih@realtek.com>, kvalo@kernel.org,
        tony0620emma@gmail.com
Cc:     stable@vger.kernel.org, linux-wireless@vger.kernel.org
References: <20230527082939.11206-1-pkshih@realtek.com>
From:   Larry Finger <Larry.Finger@lwfinger.net>
In-Reply-To: <20230527082939.11206-1-pkshih@realtek.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/27/23 03:29, Ping-Ke Shih wrote:
> The commit 28977e790b5d ("wifi: mac80211: skip powersave recalc if driver SUPPORTS_DYNAMIC_PS")
> introduced by kernel 5.20 will skip to recalculate IEEE80211_CONF_PS
> of hw->conf.flags if driver sets SUPPORTS_DYNAMIC_PS.
> 
> Since this problem was happened since 5.20, patches 1/3 and 2/3 should be
> applied to kernel 6.1+.
> 
> Patch 3/3 is to remove redundant/unnecessary check, so this can be seen as
> an independent patch that can go either wireless or wireless-next tree.
> Note, I can't combine this into patch 2/3, because this redundant check
> is introduced by upcoming kernel 6.4, but patch 2/3 would go kernel 6.1+.
> 
> Ping-Ke Shih (3):
>    wifi: rtw88: correct PS calculation for SUPPORTS_DYNAMIC_PS
>    wifi: rtw89: correct PS calculation for SUPPORTS_DYNAMIC_PS
>    wifi: rtw89: remove redundant check of entering LPS

The patch for rtw88 has been added to the GitHub repo, and fixed the issue. [1]

Thanks Ping-Ke,

Larry

[1] https://github.com/lwfinger/rtw88/issues/129