Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 30 May 2023 09:37:39 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Marek Vasut <marex@denx.de>
Cc:     linux-wireless@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Jilin Yuan <yuanjilin@cdjrlc.com>,
        Kalle Valo <kvalo@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
        netdev@vger.kernel.org
Subject: Re: [PATCH] wifi: rsi: Do not configure WoWlan in shutdown hook if
 not enabled
Message-ID: <ZHWnw9SDkEuEltSk@corigine.com>
References: <20230527222833.273741-1-marex@denx.de>
 <ZHWnfhh26QVBZxi5@corigine.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZHWnfhh26QVBZxi5@corigine.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?XLWrdo2PGqJBTsbdPGb2sU4RfZ0ksuLtQs6bZt7nzDqYm6BG8XtwLpazV7D9?=
 =?us-ascii?Q?VA+tmdRuy2N0NGyS+M2NAQp5FI8rI1wkBb6qSk025/AlZE9bOm10pVejSz1v?=
 =?us-ascii?Q?66W0wbPHwWVxsUxlY5PtSslxOr9y6Ctay9LtWCiEjOAW13MgtfYlHXkbun4n?=
 =?us-ascii?Q?61pXcYFF6laXn3cFCgVMD0UN+j3S4Ai9sVlHlDKnhILO/VORHhg09FOmaOAR?=
 =?us-ascii?Q?ekdmF8WEKU/W8UwC4FTWTBc8A2HW9qdsAUGoPkpyGhxClCZ6OCOiWRiHGHNf?=
 =?us-ascii?Q?WPfeX2/9DZ36fcpVIwMUNcT385MTTBOJU5B8QtdfXieV706OM4eQT0fUuZQG?=
 =?us-ascii?Q?dQTHKTclMiPeIUnqPQDClA2U6IN/wT6U2XSBXlprB/Je9HRjr23qtb6L+9SP?=
 =?us-ascii?Q?vmQo7QNe6Aq9T50/bRrwVx0xUvx398L8kBszS8Utlg8uEd0pWcc9nyxow6TC?=
 =?us-ascii?Q?FoOx7WPAX8BNy+950J1RFYboiHjAJKphGTREI89SRWzR+m+A2C1Y+a3ip2Yo?=
 =?us-ascii?Q?7levHsDS0EuqEqO0RJ3cwPh7z4Ocgz96sQ4OFMvFQc/LWcAVNAn7WPlgjVJp?=
 =?us-ascii?Q?Q1vNTTtTfCt2nkLqP+ReXSdJLkq9ffyxi0UkKz5UxAHOAZ/aWG9JDy2F0UvP?=
 =?us-ascii?Q?roceJrFRziEXGBMuhp6iTg6fh5VfdtFUAkZhvLdHkeckBOaqWHcirTG3CrDv?=
 =?us-ascii?Q?Y2YcAtpssH+EtOHJsXHPN+CjrJjg4GrDEtz0VjDp7GkLPB1CIcZC7aMEhnFP?=
 =?us-ascii?Q?rTaX78rSfMyPW/mzGZji1L93QZyyGG++mdK/xhx3gqAC6CfQ30ot+R7Cimgz?=
 =?us-ascii?Q?jqQ3JTcDuO3523Fv6n7T0wkKlCfwNkcXaQLm/2qt4QCTMiogEskza7Thmoug?=
 =?us-ascii?Q?bYc45x1iaO6tcJskJ11lYu1vik+GHzCOz30noCXIYypOOdKJzy5dO6aEhPCo?=
 =?us-ascii?Q?XP5StY+lKuuA/43QKHi5DGiPZFRdivQ2EYCANJUeA2rOtdp+T8uHxvWoRVbL?=
 =?us-ascii?Q?43HlF6XPgLeWa1KKIKyAcF/UWYFIikWUOMgmO/VOnKyRg08jBLUrOIsGx2CW?=
 =?us-ascii?Q?v/JI2qwFwuAQKqxml8qyQKbaX7e61E77cs4Cv05nxuU/dlwzLUltJsH2UrHt?=
 =?us-ascii?Q?EKA9WOCfRayVMGcUGUZkIaS/C0D7+ljq8Rxl+9Y0t3OVi1HC3x4ki1tEFNjb?=
 =?us-ascii?Q?5c/Wm8MP8uVIEkEwkK3u1MmcYDHQNQb2QI52JVPc3dqfkSGx6mTmajJx2SET?=
 =?us-ascii?Q?g2o7PuVRl557x6+S8BjrYE5yxchpjZHTvQLxPum9tBPbNmskYWpRpbspgtp0?=
 =?us-ascii?Q?VVyg9YRuywJJ+2vhSfthlyOD+oBMVyxVe9YXl1YK4f7mnE7XETr3CEu+/q68?=
 =?us-ascii?Q?PYQ16UiCnX8S8yC/OuPTe2aldSKoiTiC2QB2uCKdUs55hBb57BS8T+HmgwEJ?=
 =?us-ascii?Q?I+3a83b3NDALUguSrvxHxQzoVwxPNkvylvdo9sedVbirA9V30fuw50zZIDZ0?=
 =?us-ascii?Q?6UAnZtHeARrRbfxIwAwoey/Rp5hTLlHuD/7GEjYQ3WUAc1AamwuJ9+1mqpJX?=
 =?us-ascii?Q?oI9wxMv5nq9ksGyjUYxcKJoZU8troLm/2D4MIHhx5VVT6649DMddir0/bKmT?=
 =?us-ascii?Q?sNChNmMvTy05NBHCqdvPUKxDIWZnU7MXLrwS0nZkCB3oLYX3gw4bGKrmjOQx?=
 =?us-ascii?Q?QqWMkg=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ad56d4bb-c729-4581-f136-08db60e0c270
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2023 07:37:45.5007
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Al5wf/zPVERy5hK8SSggFFZIjHqZYtAQZ5ZzRuWZBXJyxAB7xouRqVjjhloytLeHC4PlJjht5+1XL1VsN+Cy9TQtvsM2ctfV9XyIgR/E7Dc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR13MB6046
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Tue, May 30, 2023 at 09:36:36AM +0200, Simon Horman wrote:
> On Sun, May 28, 2023 at 12:28:33AM +0200, Marek Vasut wrote:
> > In case WoWlan was never configured during the operation of the system,
> > the hw->wiphy->wowlan_config will be NULL. rsi_config_wowlan() checks
> > whether wowlan_config is non-NULL and if it is not, then WARNs about it.
> > The warning is valid, as during normal operation the rsi_config_wowlan()
> > should only ever be called with non-NULL wowlan_config. In shutdown this
> > rsi_config_wowlan() should only ever be called if WoWlan was configured
> > before by the user.
> > 
> > Add checks for non-NULL wowlan_config into the shutdown hook. While at it,
> > check whether the wiphy is also non-NULL before accessing wowlan_config .
> > Drop the single-use wowlan_config variable, just inline it into function
> > call.
> > 
> > Fixes: 16bbc3eb8372 ("rsi: fix null pointer dereference during rsi_shutdown()")
> 
> nit: no blank line here

Sigh, there was no blank line here.
Sorry for the noise.

> > Signed-off-by: Marek Vasut <marex@denx.de>
> 
> Reviewed-by: Simon Horman <simon.horman@corigine.com>