Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 30 May 2023 09:36:30 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Marek Vasut <marex@denx.de>
Cc:     linux-wireless@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Jilin Yuan <yuanjilin@cdjrlc.com>,
        Kalle Valo <kvalo@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
        netdev@vger.kernel.org
Subject: Re: [PATCH] wifi: rsi: Do not configure WoWlan in shutdown hook if
 not enabled
Message-ID: <ZHWnfhh26QVBZxi5@corigine.com>
References: <20230527222833.273741-1-marex@denx.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230527222833.273741-1-marex@denx.de>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?u/itf5AbA3ID1BM01QrdbBay6pgtHGaXDfhmG7yD0PCUY/s8VVlgxsKYtqHs?=
 =?us-ascii?Q?932WudgTGfCC0S2xdDjkWt3o5zJqT9VNRPLiO5F6AsxVxHS6oktQ8DN2/9Gu?=
 =?us-ascii?Q?km2o6OUyutmftduxpdD1GLOQ3Cl/P6KMfO25XKOtITPdMc4FhMqS8KcCsSok?=
 =?us-ascii?Q?FJMqERJS77se44mP8D9ivKbBqMyZUMXIYvC8Ddh1369cp2jt8/nVHZNVqKYX?=
 =?us-ascii?Q?OXN0BxCKjztyArO1/681+WgikZEw6Fv+23KLNbcxkzwpbRDzANIElRpFSlrr?=
 =?us-ascii?Q?0plLhwLYWupAMP6vdaHMfBzaR2ZLsc9uWC9H6rL7XW53XNn+bNz5fruY5gss?=
 =?us-ascii?Q?wg7nVrmAeoWhx9zLNtIM27bvCjV0EqNw4OP/sR/myO7p4oP8EslV1TbN0cpQ?=
 =?us-ascii?Q?NEuFGQ+m73+pfUjE4sm785nxiVaooLfek82QzWz5cr4dXsNdXDhsn5YwekhU?=
 =?us-ascii?Q?3OLyoTx3IOrxNbUse6kqjIEXkcf2FqP1n6VO5YCBQpUAwPq1Gw+jxwf+5A42?=
 =?us-ascii?Q?wX0kideCPgvjgK3pLrhCzdU6cjRnCXgz7DV7UOYwIHP6IFpfIRjik8Mg6w/+?=
 =?us-ascii?Q?xu1eailgj+lIUs9f1zt2r1ve2ARTU8Vb9HaxsYEKthCSnty3OmcCMf7hjUL5?=
 =?us-ascii?Q?A44scPMMZzr/ro/m42eeN9hFpiuLKzMlEAKfUo4g0NU0wmiZUZX5RxOaPxI1?=
 =?us-ascii?Q?DHqodSlOG58EMOjis8Uq8Ux91Fgw+tPBb4MGgnuAmSGxwRgXinNem6+I2Mmy?=
 =?us-ascii?Q?m8irUFi3xYreTJhiZ0vHYHirKf8NC5x+z9x8RfwDg1jeu1WoX1m8XTTro/Rr?=
 =?us-ascii?Q?oGqvXqhV6GUrp/AVwdOKH/jvzfVokS3UsXC4NroQtlyWzZOzazdOQEJyN68l?=
 =?us-ascii?Q?a/cv/h2ZvzdLDER1dZbp6V+lZtVtPMQJB3BTZLq2J/9JEIwRb/aNXtFWMjXt?=
 =?us-ascii?Q?yqS+N7MqhAFqSPHfdWf0LDJYaZ0ed0zHKONFZlO1fg7TFCslouilsaT0GqyE?=
 =?us-ascii?Q?zTqSwnrWD550V3QhkT+bHRHvZrQ6ZtgbJh+zk2WSjx+dreFaw4aHHvdeB5ci?=
 =?us-ascii?Q?oE7mPEOnTeBLK3IV3e+LfdjTnRlQDwisPKkCQzqEaedhRe57+GLQzQCdn5xa?=
 =?us-ascii?Q?yDxKdP+DrUrX9RDdDyDuZ9kT+Soh06BRZCaAOOsjAHnqpmCoeUGGcb0XJiWt?=
 =?us-ascii?Q?0VnTVVjjYhfhzVn9IGoAF9gaqBhQMhg66EHhUxxeguFbCdIil9qpTzMZo0s4?=
 =?us-ascii?Q?Dhf1P6gpCGZ9vb/l7oGjI3+dPLblY10NTD4ua3ba0qq6FhPUDNJ2InvYpW6O?=
 =?us-ascii?Q?H+Ucl308odiezU85HtSSqoEleGzEVBPkTkOyMgUtq+/UAB5Jj9VfBiNmRQfV?=
 =?us-ascii?Q?dw+ycqT7hVtW6aK/c/wVkzNg3ehzuDXUpO6tjVD25WUZhJyfsaLTO3mNdYxp?=
 =?us-ascii?Q?Te8XRx+Bcm5rnRYwmOH/U0dcxWlsQButPbdEfUWYSl9/TAwwXvTMJgq/E1Ys?=
 =?us-ascii?Q?cuPoWvNuLQF4of/ANKb1a2jIHaSiN6GC1RJOlzYVWl9w89m/9vxrX0j9xPyN?=
 =?us-ascii?Q?Ps6MfakemwUubORAb8+JfqMCZjeRL1t521C9MDdjHuRcfraGgd4OabnEbC/V?=
 =?us-ascii?Q?ZISeuPENBrqtfrebbMuOMCd1PWLix/hEdsFibPsOSfk76f7N+3Z9To08SH+/?=
 =?us-ascii?Q?fn+pMA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c8d9e3ea-5e48-4f46-f0f7-08db60e0991d
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2023 07:36:36.2129
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3eVPuQ3rC/SY3mIoKF+kMQLY5GTR2/uN/aR4queJfxEFiVn8FF0kxLW88nAPxH1GyCoQxYAe3laR9KeJaPHXX3hAckL5rWKnxIZf5TmjQS8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR13MB6046
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Sun, May 28, 2023 at 12:28:33AM +0200, Marek Vasut wrote:
> In case WoWlan was never configured during the operation of the system,
> the hw->wiphy->wowlan_config will be NULL. rsi_config_wowlan() checks
> whether wowlan_config is non-NULL and if it is not, then WARNs about it.
> The warning is valid, as during normal operation the rsi_config_wowlan()
> should only ever be called with non-NULL wowlan_config. In shutdown this
> rsi_config_wowlan() should only ever be called if WoWlan was configured
> before by the user.
> 
> Add checks for non-NULL wowlan_config into the shutdown hook. While at it,
> check whether the wiphy is also non-NULL before accessing wowlan_config .
> Drop the single-use wowlan_config variable, just inline it into function
> call.
> 
> Fixes: 16bbc3eb8372 ("rsi: fix null pointer dereference during rsi_shutdown()")

nit: no blank line here

> Signed-off-by: Marek Vasut <marex@denx.de>

Reviewed-by: Simon Horman <simon.horman@corigine.com>