Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 30 May 2023 09:39:07 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Marek Vasut <marex@denx.de>
Cc:     linux-wireless@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Jilin Yuan <yuanjilin@cdjrlc.com>,
        Kalle Valo <kvalo@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
        netdev@vger.kernel.org
Subject: Re: [PATCH] wifi: rsi: Do not set MMC_PM_KEEP_POWER in shutdown
Message-ID: <ZHWoG/13NBr3G4jp@corigine.com>
References: <20230527222859.273768-1-marex@denx.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230527222859.273768-1-marex@denx.de>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?SD5oxesgE8czUFk+kqtH9X2JAresA9x9iso6bG/t5y5hVVnY1KOxalJ8adfl?=
 =?us-ascii?Q?gUes+oRzOhExTIjcP+hE37MUKvX/2u3RsIQkriygSxgZ3i6+ytAHKuf/+7x2?=
 =?us-ascii?Q?lgIsKszdDOhYtGafLqgoYOgvbM6c2R8LMYvZ4cVIerWr61kIXuO76BYJbUO8?=
 =?us-ascii?Q?hpWhxCKyuHVKGjzOWSoVtlostEnpEGx9LnomPlOMVbKa5OIvBKG/6z3daFYV?=
 =?us-ascii?Q?G0owcME+IJjxnDpCRyHKlYztgUIDPNJF50IA55TvnUYKJLKec1QU/Xkyp6P+?=
 =?us-ascii?Q?869JSEbyx8WYgL13UDYeeOF3GPjkT8MAj2EG9SNoTZub/QgAGcb7/ZSh787+?=
 =?us-ascii?Q?s6EmNNY/vKo2y3+nQzwi9ZwREpQmM++FK4vPt2aNAEP6ETaT7xvooK/1pPQM?=
 =?us-ascii?Q?ZKUkmIMW4q5DwSducJ9RbumzBV0IJE3qEcEG/AU77tqsrYK1n+rQ4cbHKlxz?=
 =?us-ascii?Q?c+K7MAuzpNN2amHZYjVhbp9yhOkSjTRdSOJi5DSwLGRzzUqUZtK3wGAd5psO?=
 =?us-ascii?Q?vdQbOQuBCDA5j1TE7Pu9Goyphoke2SNNM2GAkklLeDV1op2fKV/tWsF0mORB?=
 =?us-ascii?Q?P5fz91fyTBdgr59iVnalfdliL7r184uHjED9b2VBxkInbUH+/o3w4488lAN+?=
 =?us-ascii?Q?FGNsw1j932llnJAspj7BV+9hSg7BHa+Zx5ybE/AvdOs3Aseor6Ct2ZyFDA09?=
 =?us-ascii?Q?gFlFjF7CoyKyLkL7osQglc864qsgdSwPvzDFfJ1F3atHN0673BO166JyMqLi?=
 =?us-ascii?Q?QT8VpMKt5lt3HNdRIDHFV/QR66DtVu+JpK75j/NKt0yMtmGf5OjdNpcxui82?=
 =?us-ascii?Q?Wu4G6wZM0CbHFI/klxE/6AFFIf92PAiXxxa+AA37kki8myBUEJmOBLIF1xPQ?=
 =?us-ascii?Q?l2wIQL/UYX+dYU3JdEPLxJS4Hs7ndW68GvW35iwSI0WWHz+mRh30uTfYGoV+?=
 =?us-ascii?Q?RORQe9Tn3466qnI8E4NngA5Gr0DvAGjh5xKFf/LXZJk71jMmu59w4a4BTB+J?=
 =?us-ascii?Q?ajKvTFgUTl7FZGThtxip9VIzWjdxHd9wC3BdTw9sQIidD7oSUpJlnCMEEscL?=
 =?us-ascii?Q?HEKVh7unLNchYNilLIPF5fsKWTjjx+kJByBevCYm1ZkQHqcE8juwvW3DrAtE?=
 =?us-ascii?Q?CRrG+xkgVhjyenNLUEcgW0FBmcfDDAdRI1ChM8lNNfC3/w8Mum8doXWVBkqS?=
 =?us-ascii?Q?P8ZhqEjobbhLacm609d7vzF37oKyJ2P0ct4fduR7/VXU2U9N1Hp0S/RE+Kbk?=
 =?us-ascii?Q?fKbVVg6BdSviQhF7uNUPnFn35Yj58NSZmdPP8siMinooVds3Gf+j/qa1/S5s?=
 =?us-ascii?Q?HQ1TEAsK9cECsHTgxUIevHuKE5/JRkXp5udXwAd2l+QiL3KENnwOWdLp1cbD?=
 =?us-ascii?Q?kndhIeTHqQDh6b1xroJLwtlt2TYwjl4+dI+0ygHMP9LetnAxX19iNRrxzUq0?=
 =?us-ascii?Q?oBmJD3+xo0K76YVIIjsTG/pijt6SgQs1j64qYzDtNRQhbq8V3NouJQe/7agX?=
 =?us-ascii?Q?5A68dl07cZMbs1CiWC2brLZ+Tf0JoOE6C/sFyPMhscJ4HWxPJXV5Eyxi0PnU?=
 =?us-ascii?Q?5tD4FjwLPVJXGAEmvSawusxc7HyzC0xfEv9tvIM08pWr2Ox/FivNDJxbDKCl?=
 =?us-ascii?Q?7ahdxPwFCL7LWidtneoCRGOEAexrUUjuBF9hkbe2D3QLjDAWKcAHgMyUNK+B?=
 =?us-ascii?Q?d4quIA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c965e6c6-9dce-46be-5ed1-08db60e0f72e
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2023 07:39:14.0558
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ujci6FjgOCr6fgIYgU8Xgdu5t+6c1d246pvjNeISqls624Mvx/Mkc8ufooI7TvZRixQmWBlO4YW3bP5sjQVRd78y7R7DTqY+O7F12TCec7M=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR13MB6046
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Sun, May 28, 2023 at 12:28:59AM +0200, Marek Vasut wrote:
> It makes no sense to set MMC_PM_KEEP_POWER in shutdown. The flag
> indicates to the MMC subsystem to keep the slot powered on during
> suspend, but in shutdown the slot should actually be powered off.
> Drop this call.
> 
> Fixes: 063848c3e155 ("rsi: sdio: Add WOWLAN support for S5 shutdown state")
> Signed-off-by: Marek Vasut <marex@denx.de>

Reviewed-by: Simon Horman <simon.horman@corigine.com>