Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp4299499rwd; Tue, 30 May 2023 03:31:07 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4eQy5jYRKp3IGu1HtBMbPeDMKaXFja9ZdNtBWVe7icnWnynWAoWKG8eFXqLUfqiimMomfC X-Received: by 2002:a05:6a20:5494:b0:10a:b2a2:a301 with SMTP id i20-20020a056a20549400b0010ab2a2a301mr2284506pzk.12.1685442666998; Tue, 30 May 2023 03:31:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685442666; cv=none; d=google.com; s=arc-20160816; b=Lodr898HsIF8OSoIwcxN8qi4zDdF2PAk3qjbTeyc4/JgMN0mmBBkUsxH5uvCGxUcpp jpcDRR9isnF/siPudOJyUFlFBULRjoPNPIMTAHKAKZ4LW1nMdSHUHGFQlA9Tz/jLxeQs lIGCUnUwnl9HgWk9GoAlpZSuOdcJP2JY1RYhCsZ0LeRx2Vt7EHSvzU2aRFJm1hzLqDJp 7Dru1ackoMLBiDUpHur/L1v3h/iCK/ZHZgoNhEI/om8hDgXKBJGYGidsaPfhlI2w0h3f 5IOOb9WJHCthPJMI92K1+DYgo3DsKQRxXlWDPr8i80TwH0keXbETsJYxyq8DM4j+3nUU FoKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=FiS5c6zZkJ+xAX4VGba307pG2mdpaM2GPSO79PcG6yY=; b=zJByx3kP8ApDTrhVH2HV01Sf+Ah9tcvpjsYwMKkT+i9vpZUH/rXsnaH2IJyDFJtwhg qK61n6WJUsRHw3rBf+R9na42FYUw9beMoOAnEYgZm2I2DacPzTIJBg+2r4Q8lDWcim/Q RhrhiuE8HUv7G/2Pc0DcK3jOiVc/8NC/GTKayRVEofV7cYQbD1nSMK6ybwWIZpi+K1E3 AJ3Hn9+tBDT4aPrO+dP6VbSbAoE+pLrcFIFF1hBxoLc68PEmm3r18FTnvhIplfWrg5kJ EomVBR0rU89xB7bzY+0GkCrVwEGQ3EzjtNiIQ1XS5kCG/qS2EzEhJrKHJfineyiz9NEk VKxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MtphMf9f; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i186-20020a6387c3000000b0053415b1caa8si573885pge.157.2023.05.30.03.30.58; Tue, 30 May 2023 03:31:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MtphMf9f; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229996AbjE3Kag (ORCPT + 63 others); Tue, 30 May 2023 06:30:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231893AbjE3KaT (ORCPT ); Tue, 30 May 2023 06:30:19 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1DFE1198; Tue, 30 May 2023 03:29:43 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AA5B26232F; Tue, 30 May 2023 10:29:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 55CA3C433EF; Tue, 30 May 2023 10:29:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685442582; bh=yaQ1s4zqJX+CR6dLRA+UZTtmUpMxJSpY3TwJ7NIb7pw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=MtphMf9fx4Ckf8MUWsnOC2+KfKZgeU0ZtAT6Nhi/dHL1UBFE+4IIHm3yj1wmROfkS gRMBm/TWmoBooKy7de9GhOr1U5is9vKttU35U12v+0JWKDL9Zi6qQt0Uvf2GyxF3PZ 41o1dB1Ge0DR/YSgun68lWzlnKm4fR8fJXCDGPCW+y8D0D2pVJ8TaPDqZghvc3Zc/c tBOe/l/s/uwLrQ11oJlUhIhILhvTbFAYfuY8PYn8n2AfVRNkCXdDboUOSNvkokQQfL KZ+WAZ6KN8V7iYyfwgyrEPaNUXpeAdm0OlXQwBZ53o9Pxva9DZ7gmdbS1Oh52kYMz4 WLyLk7FAXqC5g== From: Kalle Valo To: Osama Muhammad Cc: nbd@nbd.name, ryder.lee@mediatek.com, lorenzo@kernel.org, shayne.chen@mediatek.com, davem@davemloft.net, linux-wireless@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] debugfs.c: Fix error checking for debugfs_create_dir References: <20230524160352.19704-1-osmtendev@gmail.com> Date: Tue, 30 May 2023 13:29:37 +0300 In-Reply-To: <20230524160352.19704-1-osmtendev@gmail.com> (Osama Muhammad's message of "Wed, 24 May 2023 21:03:52 +0500") Message-ID: <87v8gajeni.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Osama Muhammad writes: > This patch fixes the error checking in debugfs.c in > debugfs_create_dir. The correct way to check if an error occurred > is using 'IS_ERR' inline function. > > Signed-off-by: Osama Muhammad The title is wrong, please see the wiki page below how to create titles. Also no need to say "This patch fixes..", saying "Fix..." is enough. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches