Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <20f02345-fb0a-8ec0-fc4e-1434b5a9466e@amd.com>
Date:   Tue, 30 May 2023 10:34:13 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: [PATCH 0/9] Support Wifi RFI interference mitigation feature
To:     Felix Fietkau <nbd@nbd.name>, Evan Quan <evan.quan@amd.com>,
        rafael@kernel.org, lenb@kernel.org, alexander.deucher@amd.com,
        christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com,
        daniel@ffwll.ch, kvalo@kernel.org, lorenzo@kernel.org,
        ryder.lee@mediatek.com, shayne.chen@mediatek.com,
        sean.wang@mediatek.com, matthias.bgg@gmail.com,
        angelogioacchino.delregno@collabora.com, Lijo.Lazar@amd.com
Cc:     linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-wireless@vger.kernel.org, ath11k@lists.infradead.org,
        ath12k@lists.infradead.org
References: <20230530024227.2139632-1-evan.quan@amd.com>
 <1502188c-c527-3038-2163-5ca4f51ed735@nbd.name>
Content-Language: en-US
From:   "Limonciello, Mario" <mario.limonciello@amd.com>
In-Reply-To: <1502188c-c527-3038-2163-5ca4f51ed735@nbd.name>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QUxBRWpBdnZuekNiU25yRTQ0WXdPdEVHemk4WSt6a2pGd1NSTW5qZWFCT1ov?=
 =?utf-8?B?NHMzUUlrb3pHaWtwUDdlZ2VKWEF6bGZ2ZVpQQ015SC8zellEcXlhT2wwWitq?=
 =?utf-8?B?bDlDcGlqaG5hNzkyR1d3UjRDdTM4ejRIY2NpTWRuSmJWZlArSTRjcXNINHNR?=
 =?utf-8?B?V0RCVlFJN0ljV0xOUTBoaEppNnZ0OWkzcTk1VTdvYjNlTG9ONVRzbVVaYUJk?=
 =?utf-8?B?a1p1cTBIbW51MkJ5TXJRUWhIcG1GYmc1d081R0hPRm5KaXI1aWtOcU4rNXVr?=
 =?utf-8?B?WW5pTjRqNk5ZbkFwb2srNWZxMFF1U0JVOVFVM0ZUUlBGRHF3UG9FKzVYVWYw?=
 =?utf-8?B?aHNhUmdobERnaGxoc29kNWxQYU5rQ2dpRjNaNlFaNm82MEk0YkRFbWxYS01X?=
 =?utf-8?B?eVgrUk4vUGRLaDJSSmttMUwvYU1yeVc4bFk5MitveEtZdk0vRUp0cHpNOVps?=
 =?utf-8?B?MEVoaGVFODhlemlPeGMxcU9mSlYvbllFUVQwckQ0aFloSGpRejVldmNtcHpm?=
 =?utf-8?B?QzFZTXQ4T0U5OVNyOU55ZkdldXI1U0UrY3B4emRHTU9WSGJManZvc1JNRVpi?=
 =?utf-8?B?QVFNUkx2TDFYaStYVjJCQmVTYTV6TDQrakRMMVZNK2lSN0FhVW5nQm0zVEdu?=
 =?utf-8?B?OWhKT0dTb3EzL21aSGRMS0dYWFNQY3VjT3F2MkxzMlBrampIakI5QUNPL2xZ?=
 =?utf-8?B?V1g0SjVFL05Qem5aTHQrUWNBUko5ZzlrbHNMRXZsblZzamxHNEZ1NFhxSEV3?=
 =?utf-8?B?Q2NNMUJyNU9DekVSTUhIeURadWwvc09QYjNwZXJqcFY5amVFYzBUVDFmdUF2?=
 =?utf-8?B?cXpSMm5sM2hBQ002WnYyUW54ZXFpUVJJSEx1VXozcktTL0tqRHZ6aVVPK1lD?=
 =?utf-8?B?YWdnaUpoZFF4Mml0bGN5TE01QUlSdzBncGdMTHBmMjY3cEZsNUhUeGV2aEFK?=
 =?utf-8?B?WVBQclBhR3AxNGVmM0ZTRHp6MmJCQTQzQ3NmcFRIQ0t5VmVQUDIyWlRZNlZD?=
 =?utf-8?B?QlFvNDR4US9iVnp4Y2FrVFlpOFN0TGpEa3U5ZUpXK0NBYUtJY0dDSHU5UlNY?=
 =?utf-8?B?aUxpeWQ3KzJLaVhsK2xGVGJqVS9pOUZ0TzQ3VjRpTzdJKzFuQjNNdUtXRExS?=
 =?utf-8?B?djlvSUhoTExaMTJDaVpMM3NRWTRtSzM2NHA0WUVZNUtIMGljbXdNNVlnUGNn?=
 =?utf-8?B?QnBoYkJiVlFLYzlFUlI5SzA4UU43cmhFKzViRytYZzd5MkVtVXRwcGxxTmpu?=
 =?utf-8?B?TVQzT0hDQitWaDE5d09MUGZjRnVNWXVYZ044VTY1R2ZLY1dUWE9hcUlWZ2lY?=
 =?utf-8?B?eWVHVUlnZHhLRVlqdTdXK0tHWjRkOHllRUJ4OGVmcytXdzBzWFk1QzZDZFh0?=
 =?utf-8?B?RkpxYjJVUmg3aVVoMXlMNmZTeXNSUUQxWGF2aURHNkt5MUV2NUk4MGJIeEl1?=
 =?utf-8?B?djJuTHBtTmpWWHFMUXBuMFBKdUcyd3RvR0pxSHg3STZvc3NGR0IrbjYyck5v?=
 =?utf-8?B?TzBGdzk5Z2hTTWZXY2pqSTNiV3FlL2w4MldKK2p6Rkg1RTN2Sk1VYkZIajJn?=
 =?utf-8?B?QXUvN2wraytRZ0cwZ1FUeXZ1M3EwdlRDSzlnZ0VraURWRzhSaTdrWEN3bXpN?=
 =?utf-8?B?cVcvMkY5UTRiVnZHaGpvMzRFMkt3VkJ6bzR2OUJ0MjRUOW9MNThvSnFHWDJF?=
 =?utf-8?B?ZGpZdVNHVHJNZmxRY3E2ekFYcWhVS0s0eEFYcVVJa3VlZHg2bWJuZm4yR3p6?=
 =?utf-8?B?ZmxnaDBaME42d3ZYWS9MWFJDalBkRGtkc1MrRXB1V0lKWUhFRnJyeXhwUFJY?=
 =?utf-8?B?SnI4TjdoMzlodmQvWFd4blVhQkRGOHhlLzI1MlRpOVlMMlNIamJBRVhsZEZI?=
 =?utf-8?B?L3NWcU5rMDgvWVlRR2FOVUVIck04d3M3bGtoQ3h2MEkwOUJMdVY3Y0dNcEhM?=
 =?utf-8?B?V01JOUpJYVFMRktDeGEyNWpuWG5QNW1yT05UbnpydndzSllPajAyUHNFaGIz?=
 =?utf-8?B?MVd6bzcvOFgxaWp2K0pucDh6dk4rd1RDazZCNVMwZmFyRUQvakFQOXZYTGtw?=
 =?utf-8?B?MG9YK1dISmZ0eXJIQ1QvQXhsbHNWeHRubExBSldrV1U2WEhjQnc5THJwclYy?=
 =?utf-8?Q?uoOCqFxhx8NlGO59Wf0B+XGAE?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: af383cff-fd7d-47d9-53aa-08db612354e0
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2023 15:34:18.1431
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YlROpklVcbIS1fjk468ZoJGGTAwGvc8VjKG/lHykMtepzJy7HrI6y6Vz0q/ysMXIIXzk0w8VILs1RvmymMyJaQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5719
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org


On 5/30/2023 1:22 AM, Felix Fietkau wrote:
> On 30.05.23 04:42, Evan Quan wrote:
>> Due to electrical and mechanical constraints in certain platform 
>> designs there may
>> be likely interference of relatively high-powered harmonics of the 
>> (G-)DDR memory
>> clocks with local radio module frequency bands used by Wifi 6/6e/7. 
>> To mitigate
>> possible RFI interference producers can advertise the frequencies in 
>> use and
>> consumers can use this information to avoid using these frequencies for
>> sensitive features.
>>
>> The whole patch set is based on 6.4-rc3. With some brief 
>> introductions as below:
>> Patch1:     Core ACPI interfaces needed to support WBRF feature.
>> Patch2 - 4: Enable WBRF support for some Mediatek and Qualcomm wifi 
>> drivers.
>> Patch5 - 9: Enable WBRF support for AMD graphics driver.
>>
>> Anson Tsao (1):
>>    wifi: ath11k: Add support to the Qualcomm ath11k for ACPI WBRF
>>
>> Evan Quan (6):
>>    wifi: ath12k: Add support to the Qualcomm ath12k for ACPI WBRF
>>    drm/amd/pm: update driver_if and ppsmc headers for coming wbrf 
>> feature
>>    drm/amd/pm: setup the framework to support Wifi RFI mitigation 
>> feature
>>    drm/amd/pm: add flood detection for wbrf events
>>    drm/amd/pm: enable Wifi RFI mitigation feature support for SMU13.0.0
>>    drm/amd/pm: enable Wifi RFI mitigation feature support for SMU13.0.7
>>
>> Mario Limonciello (2):
>>    drivers/acpi: Add support for Wifi band RF mitigations
>>    mt76: Add support to the Mediatek MT7921 for ACPI WBRF
> Wouldn't it make more sense to put this in mac80211 or cfg80211 
> instead of duplicating the logic in different drivers?
>
> - Felix
>
I think it's generally a sensible proposal, but there are a few things 
that need to be agreed upon to find the right places
for everything.

1) The actual notifying, would it make sense to put it directly into 
these functions?

ieee80211_add_chanctx / ieee80211_del_chanctx

2) "Where" should the WBRF support detection need to happen?

wbrf_supported_producer needs to have an argument of the ACPI companion 
for the device.
What level *should* the ACPI device be found?
Should that still be individual drivers calling a mac80211 helper 
function to indicate they're opting in?
Or should there there be some CONFIG_ACPI_WBRF gated helper as part of a 
driver registration?