Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp4736292rwd; Tue, 30 May 2023 09:09:34 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7PLGxJv1OqTmPuMwb1rTMkGIIcg++IN93Sc/r85BM+OPidwY0I7ronB4lNCHp0+IqltNou X-Received: by 2002:a05:6a20:8425:b0:112:2843:b546 with SMTP id c37-20020a056a20842500b001122843b546mr2271954pzd.58.1685462973756; Tue, 30 May 2023 09:09:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685462973; cv=none; d=google.com; s=arc-20160816; b=CM0Io0mThygKg7FftRahmF19p9GVWjA76Hd1JNGlWXtxyyjnXNAFTnBow5HK7sy1e7 qF6mo8sZg13FhmvzEl9K69uAnaJ+1iv0i/+ygSUxeBmdOSQ5FAHqX0yyGMBEQ7JrGhiH 8ghHqKt42zMxeG/Kk34MMcc3ZdsMawgfYO3yA85TnNp1w0mx7LvQoq+S0U+8w144VH48 Hma1MaxY5jlzd+0jwFOru00E/RPLe1jxbDIK8n4aszD4gMupkO7jB/qFS7UBNg/WmF8L ULcgQAEU9VavE360TjnKoQ9nfyvr/Yzuh0qJVvfitkYjVJv+yOfj7wqGX/TDehwQc2ac DeWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=FXg7yLiycbfyjLeqClI7IJ3duOREDsgEH/POcLoymhc=; b=aEbX0Kq3RxPh9Nx8q8aKXEDk5vq+WsDZiDzk6oh6NDOirvG56lflU8Ontzol9m46Wg fKOqUy+wIfyVbce7QoawuzOI+vvPSxT1RWRf5NYWI77JPpFtLZ96IBIixFef54xYRSow 5ZCnzynM19I0y6QT1zSsdpQr0fR64VukeghqqANYdCzdIJy3Eg3wgdCxmxUQXJHo7E10 fqUbK2iShwvmw4jYMFf4Tb9egGGJnD5DCTzsehrJ877TlqW+6KoNqXrI7ppnS85+mhzM VV8VCw80aJheIGTQgHBQSwhH7nd9pC23KAsEhMAGLnFK+f7ZMJdrG9EhXm4bTMAQflvi eYdA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@yandex.ru header.s=mail header.b=r75qLvQE; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 24-20020a631258000000b00520603e8e25si8171005pgs.67.2023.05.30.09.09.04; Tue, 30 May 2023 09:09:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@yandex.ru header.s=mail header.b=r75qLvQE; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233133AbjE3QEM (ORCPT + 63 others); Tue, 30 May 2023 12:04:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232582AbjE3QEI (ORCPT ); Tue, 30 May 2023 12:04:08 -0400 X-Greylist: delayed 485 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 30 May 2023 09:03:37 PDT Received: from forward206b.mail.yandex.net (forward206b.mail.yandex.net [IPv6:2a02:6b8:c02:900:1:45:d181:d206]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E52CB1B3 for ; Tue, 30 May 2023 09:03:37 -0700 (PDT) Received: from forward100b.mail.yandex.net (forward100b.mail.yandex.net [IPv6:2a02:6b8:c02:900:1:45:d181:d100]) by forward206b.mail.yandex.net (Yandex) with ESMTP id D3DE56011D for ; Tue, 30 May 2023 18:55:33 +0300 (MSK) Received: from mail-nwsmtp-smtp-production-main-31.sas.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-31.sas.yp-c.yandex.net [IPv6:2a02:6b8:c08:d315:0:640:bb64:0]) by forward100b.mail.yandex.net (Yandex) with ESMTP id 91BA160055; Tue, 30 May 2023 18:55:30 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-31.sas.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id HtOZWJVDSSw0-OOF9rDAJ; Tue, 30 May 2023 18:55:30 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1685462130; bh=FXg7yLiycbfyjLeqClI7IJ3duOREDsgEH/POcLoymhc=; h=Message-Id:Date:Cc:Subject:To:From; b=r75qLvQETEJMkGcBBexo7n0M+v7bJwKvniS5t5TJdKv8WI3kpYzsBV/H7+a/sYoqV e9zCc+eqXCJYDAqD5khLfxrxZ9E98/AOm/a8qWJJoM8fd28LeO7MTudlA64mPvEEp5 ubaNOcyBK4ePkccdvuOFtiWXmGQ0zR854a4jwsfg= Authentication-Results: mail-nwsmtp-smtp-production-main-31.sas.yp-c.yandex.net; dkim=pass header.i=@yandex.ru From: Dmitry Antipov To: Ping-Ke Shih Cc: Kalle Valo , linux-wireless@vger.kernel.org, lvc-project@linuxtesting.org, Dmitry Antipov , Dmitriy Antipov Subject: [PATCH] rtlwifi: rtl8188ee: drop RTX_POWER_BEFORE_IQK_A and RTX_POWER_AFTER_IQK_A reads Date: Tue, 30 May 2023 18:54:46 +0300 Message-Id: <20230530155446.555091-1-dmantipov@yandex.ru> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Drop redundant reads from RTX_POWER_BEFORE_IQK_A and RTX_POWER_AFTER_IQK_A registers in _rtl88e_phy_path_a_rx_iqk(). Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Dmitriy Antipov --- drivers/net/wireless/realtek/rtlwifi/rtl8188ee/phy.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/phy.c index 12d0b3a87af7..380a813acda8 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/phy.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/phy.c @@ -1475,8 +1475,6 @@ static u8 _rtl88e_phy_path_a_rx_iqk(struct ieee80211_hw *hw, bool config_pathb) mdelay(IQK_DELAY_TIME); reg_eac = rtl_get_bbreg(hw, RRX_POWER_AFTER_IQK_A_2, MASKDWORD); - reg_e94 = rtl_get_bbreg(hw, RTX_POWER_BEFORE_IQK_A, MASKDWORD); - reg_e9c = rtl_get_bbreg(hw, RTX_POWER_AFTER_IQK_A, MASKDWORD); reg_ea4 = rtl_get_bbreg(hw, RRX_POWER_BEFORE_IQK_A_2, MASKDWORD); if (!(reg_eac & BIT(27)) && -- 2.40.1