Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp4897409rwd; Tue, 30 May 2023 11:28:02 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6tdQogTfjtEbvovdhVPYASwz3oG0Us+6DhmpObZRRbHJs62ihkGzLG/i3zU1qF5VYXIkXf X-Received: by 2002:a05:6a20:9c97:b0:10e:786c:820d with SMTP id mj23-20020a056a209c9700b0010e786c820dmr3015572pzb.32.1685471282070; Tue, 30 May 2023 11:28:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685471282; cv=none; d=google.com; s=arc-20160816; b=mCo+3VtJRuPckUNKLFH8s6e17OOFf3G8ICosFETiZlwNp6RO3h+3Hn4M7f2cmh3Xgc zX71G26KvJR+n2j59TACyTwfeufTyueI4EVEl5hfiyt3dSrM1gye4qrRrv/0Od2qFMk5 olRoSqPu1lWZsJR6y2tZ3eORHZekJmDVIUYDEg/OW28bIOE0EQ5EcWPK/IiQtx7CbRR3 1Yvpxnlh0+bGZkc5Ai2ahmxMallRMAy4QSUiFVOsuJ8pRuNqwEAZEyIpC5MxgKLig5mZ FnSWOrtKjWLR9VgI9EyAd7XzrpLx6C3xDNd7EU3TAVYa126UwHKsGrme3JwHOWNdoLlv Aw6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:subject :autocrypt:from:content-language:references:cc:to:user-agent :mime-version:date:message-id:dkim-signature; bh=nUGRBu/DiicgLZfcYFbNqve4nACPiYegXw1sex8HMRQ=; b=c7z4V3U7ecUAwcaZohrF/hOJyrU+H54eD980wC4jcc9u6A70ZaWtzz5qaZ7b3hXrjn bi5b4jBcdA20puupl+RyD2e+iq4hxivAa+jsORc59PtKHOsmd2nEX0fHgvA6KdUyKZ7t TqzroSfmjfn89e3CxoLPhJ1VARFDQ5KQRGxwovgRyh+lxeM3EbMIvkheSsI3FtAPxfJz Q28FoK9dyFYSZdNwxZj1VCupJk+DCHNozLtSkPCUNNaiZ2wpA4PWCEgEbMgb9gQx1zAg +2I4NR/3UZgOC2fFsW7WHOy6A2uDqrsnQebUWu5ELaepSzpZF5TKYi3q8+fqhipZ7xg0 KsQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@yandex.ru header.s=mail header.b=QYX6WxU4; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x189-20020a6386c6000000b0053fb3688fa9si1719248pgd.714.2023.05.30.11.27.50; Tue, 30 May 2023 11:28:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@yandex.ru header.s=mail header.b=QYX6WxU4; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230367AbjE3S1L (ORCPT + 64 others); Tue, 30 May 2023 14:27:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233271AbjE3S0s (ORCPT ); Tue, 30 May 2023 14:26:48 -0400 X-Greylist: delayed 9048 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 30 May 2023 11:26:22 PDT Received: from forward500a.mail.yandex.net (forward500a.mail.yandex.net [178.154.239.80]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3563F10A for ; Tue, 30 May 2023 11:26:21 -0700 (PDT) Received: from mail-nwsmtp-smtp-production-main-18.vla.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-18.vla.yp-c.yandex.net [IPv6:2a02:6b8:c1f:5f1d:0:640:49bf:0]) by forward500a.mail.yandex.net (Yandex) with ESMTP id B01FF5EC57; Tue, 30 May 2023 21:26:16 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-18.vla.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id EQRBnvNDTOs0-kzpx9pLp; Tue, 30 May 2023 21:26:15 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1685471175; bh=nUGRBu/DiicgLZfcYFbNqve4nACPiYegXw1sex8HMRQ=; h=In-Reply-To:Subject:To:From:Cc:Date:References:Message-ID; b=QYX6WxU483uz2Je7g5ukeRwwM90LcMaVCVjGs34Y3bXk72aHDOndReO21id1CeuGE 5XkwMeJkw+NgW/ioA6IrYySiOq0yDd0vathBY5eBxqWFAMtuXTz9XQKeat1dQATIIS H2Yw7C69Th1E23+n8B5X9T4zMLfaG+dOgOipkDTE= Authentication-Results: mail-nwsmtp-smtp-production-main-18.vla.yp-c.yandex.net; dkim=pass header.i=@yandex.ru Message-ID: <09191d90-c29d-bdf5-4192-19553f8911fd@yandex.ru> Date: Tue, 30 May 2023 21:26:14 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 To: Larry Finger , Ping-Ke Shih Cc: Kalle Valo , linux-wireless@vger.kernel.org, lvc-project@linuxtesting.org, Dmitriy Antipov References: <20230530155446.555091-1-dmantipov@yandex.ru> Content-Language: en-US From: Dmitry Antipov Autocrypt: addr=dmantipov@yandex.ru; keydata= xsDNBGBYjL8BDAC1iFIjCNMSvYkyi04ln+5sTl5TCU9O5Ot/kaKKCstLq3TZ1zwsyeqF7S/q vBVSmkWHQaj80BlT/1m7BnFECMNV0M72+cTGfrX8edesMSzv/id+M+oe0adUeA07bBc2Rq2V YD88b1WgIkACQZVFCo+y7zXY64cZnf+NnI3jCPRfCKOFVwtj4OfkGZfcDAVAtxZCaksBpTHA tf24ay2PmV6q/QN+3IS9ZbHBs6maC1BQe6clFmpGMTvINJ032oN0Lm5ZkpNN+Xcp9393W34y v3aYT/OuT9eCbOxmjgMcXuERCMok72uqdhM8zkZlV85LRdW/Vy99u9gnu8Bm9UZrKTL94erm 0A9LSI/6BLa1Qzvgwkyd2h1r6f2MVmy71/csplvaDTAqlF/4iA4TS0icC0iXDyD+Oh3EfvgP iEc0OAnNps/SrDWUdZbJpLtxDrSl/jXEvFW7KkW5nfYoXzjfrdb89/m7o1HozGr1ArnsMhQC Uo/HlX4pPHWqEAFKJ5HEa/0AEQEAAc0kRG1pdHJ5IEFudGlwb3YgPGRtYW50aXBvdkB5YW5k ZXgucnU+wsEPBBMBCAA5FiEEgi6CDXNWvLfa6d7RtgcLSrzur7cFAmBYjL8FCQWjmoACGwMF CwkIBwIGFQgJCgsCBRYCAwEAAAoJELYHC0q87q+34CEMAKvYwHwegsKYeQokLHXeJVg/bcx9 gVBPj88G+hcI0+3VBdsEU0M521T4zKfS6i7FYWT+mLgf35wtj/kR4akAzU3VyucUqP92t0+T GTvzNiJXbb4a7uxpSvV/vExfPRG/iEKxzdnNiebSe2yS4UkxsVdwXRyH5uE0mqZbDX6Muzk8 O6h2jfzqfLSePNsxq+Sapa7CHiSQJkRiMXOHZJfXq6D+qpvnyh92hqBmrwDYZvNPmdVRIw3f mRFSKqSBq5J3pCKoEvAvJ6b0oyoVEwq7PoPgslJXwiuBzYhpubvSwPkdYD32Jk9CzKEF9z26 dPSVA9l8YJ4o023lU3tTKhSOWaZy2xwE5rYHCnBs5sSshjTYNiXflYf8pjWPbQ5So0lqxfJg 0FlMx2S8cWC7IPjfipKGof7W1DlXl1fVPs6UwCvBGkjUoSgstSZd/OcB/qIcouTmz0Pcd/jD nIFNw/ImUziCdCPRd8RNAddH/Fmx8R2h/DwipNp1DGY251gIJQVO3c7AzQRgWIzAAQwAyZj1 4kk+OmXzTpV9tkUqDGDseykicFMrEE9JTdSO7fiEE4Al86IPhITKRCrjsBdQ5QnmYXcnr3/9 i2RFI0Q7Evp0gD242jAJYgnCMXQXvWdfC55HyppWazwybDiyufW/CV3gmiiiJtUj3d8r8q6l aXMOGky37sRlv1UvjGyjwOxY6hBpB2oXdbpssqFOAgEw66zL54pazMOQ6g1fWmvQhUh0TpKj JZRGF/sib/ifBFHA/RQfAlP/jCsgnX57EOP3ALNwQqdsd5Nm1vxPqDOtKgo7e0qx3sNyk05F FR+f9px6eDbjE3dYfsicZd+aUOpa35EuOPXS0MC4b8SnTB6OW+pmEu/wNzWJ0vvvxX8afgPg lUQELheY+/bH25DnwBnWdlp45DZlz/LdancQdiRuCU77hC4fnntk2aClJh7L9Mh4J3QpBp3d h+vHyESFdWo5idUSNmWoPwLSYQ/evKynzeODU/afzOrDnUBEyyyPTknDxvBQZLv0q3vT0Uiq caL7ABEBAAHCwPwEGAEIACYWIQSCLoINc1a8t9rp3tG2BwtKvO6vtwUCYFiMwAUJBaOagAIb DAAKCRC2BwtKvO6vtwe/C/40zBwVFhiQTVJ5v9heTiIwfE68ZIKVnr+tq6+/z/wrRGNro4PZ fnqumrZtC+nD2Aj5ktNmrwlL2gTauhMT/L0tUrr287D4AHnXfZJT9fra+1NozFm7OeYkcgxh EG2TElxcnXSanQffA7Xx25423FD0dkh2Z5omMqH7cvmh45hBAO/6o9VltTe9T5/6mAqUjIaY 05v2npSKsXqavaiLt4MDutgkhFCfE5PTHWEQAjnXNd0UQeBqR7/JWS55KtwsFcPvyHblW4be 9urNPdoikGY+vF+LtIbXBgwK0qp03ivp7Ye1NcoI4n4PkGusOCD4jrzwmD18o0b31JNd2JAB hETgYXDi/9rBHry1xGnjzuEBalpEiTAehORU2bOVje0FBQ8Pz1C/lhyVW/wrHlW7uNqNGuop Pj5JUAPxMu1UKx+0KQn6HYa0bfGqstmF+d6Stj3W5VAN5J9e80MHqxg8XuXirm/6dH/mm4xc tx98MCutXbJWn55RtnVKbpIiMfBrcB8= Subject: Re: [PATCH] rtlwifi: rtl8188ee: drop RTX_POWER_BEFORE_IQK_A and RTX_POWER_AFTER_IQK_A reads In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 5/30/23 20:42, Larry Finger wrote: > I do not know the answer to this question either, but how does > your tool know that the statements between the first read and > the second have not caused the firmware to change the contents > of the BB registers? This tool is a static analysis software and has no special knowledge about any particular hardware. So I do not strongly insist on this change which should be treated as a subject to more detailed consideration. I've noticed 6c75eab0417b9e5b05a18dbfc373e27a8ef876d8 where rtl_get_bbreg() is preserved but the result is ignored. Would the similar thing be a kind of a cleanup for this case as well? Thanks, Dmitry