Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Larry Finger <larry.finger@gmail.com>
Message-ID: <bee18794-8c4a-2af9-cf1c-807969be3dd2@lwfinger.net>
Date:   Tue, 30 May 2023 13:55:16 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: [PATCH] rtlwifi: rtl8188ee: drop RTX_POWER_BEFORE_IQK_A and
 RTX_POWER_AFTER_IQK_A reads
Content-Language: en-US
To:     Dmitry Antipov <dmantipov@yandex.ru>,
        Ping-Ke Shih <pkshih@realtek.com>
Cc:     Kalle Valo <kvalo@kernel.org>, linux-wireless@vger.kernel.org,
        lvc-project@linuxtesting.org,
        Dmitriy Antipov <Dmitriy.Antipov@softline.com>
References: <20230530155446.555091-1-dmantipov@yandex.ru>
 <b747b45e-e176-4c55-0886-abfcb1e33717@lwfinger.net>
 <09191d90-c29d-bdf5-4192-19553f8911fd@yandex.ru>
From:   Larry Finger <Larry.Finger@lwfinger.net>
In-Reply-To: <09191d90-c29d-bdf5-4192-19553f8911fd@yandex.ru>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/30/23 13:26, Dmitry Antipov wrote:
> On 5/30/23 20:42, Larry Finger wrote:
> 
>> I do not know the answer to this question either, but how does
>> your tool know that the statements between the first read and
>> the second have not caused the firmware to change the contents > of the BB 
>> registers?
> 
> This tool is a static analysis software and has no special knowledge
> about any particular hardware. So I do not strongly insist on this
> change which should be treated as a subject to more detailed consideration.
> 
> I've noticed 6c75eab0417b9e5b05a18dbfc373e27a8ef876d8 where rtl_get_bbreg()
> is preserved but the result is ignored. Would the similar thing be a kind
> of a cleanup for this case as well?
> 

Yes, you could ignore the output from rtl_get_bbreg() for lines 1484 and 1485.

Larry