Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 30 May 2023 21:59:04 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Sascha Hauer <s.hauer@pengutronix.de>
Cc:     Pkshih <pkshih@realtek.com>, Hans Ulli Kroll <linux@ulli-kroll.de>,
        ValdikSS <iam@valdikss.org.ru>,
        linux-wireless <linux-wireless@vger.kernel.org>,
        Tim K <tpkuester@gmail.com>, Nick Morrow <morrownr@gmail.com>,
        Viktor Petrenko <g0000ga@gmail.com>,
        "Alex G ." <mr.nuke.me@gmail.com>, kernel@pengutronix.de,
        petter@technux.se, Andreas Henriksson <andreas@fatal.se>,
        Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH] wifi: rtw88: usb: silence log flooding error message
Message-ID: <ZHZViIRQP0IZGu0r@corigine.com>
References: <20230524103934.1019096-1-s.hauer@pengutronix.de>
 <ZG32XKBsAub+Y+bO@corigine.com>
 <20230526101736.GS17518@pengutronix.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230526101736.GS17518@pengutronix.de>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZnQZsVYEfDo8FIDl2w2dzcr5P8Bc9GC6v0cFzP1UTiFw9riyK+2iAos53OVt?=
 =?us-ascii?Q?eCIizqEbeOBIALFQNW5l12po/SQaakxTnngf7rOFx0OMLVdj5wNwLMz1Cg5i?=
 =?us-ascii?Q?65ahMEdZZolUqIxrJRt6qlqcN8+8hhYqozT4fFr7zxhq5ctPhj028taLQL1m?=
 =?us-ascii?Q?cot7HItx7H1jcrpYdhvKXFF3BEl2Kv9MJMme8xzB89kZS0Vzhj5M4d9KDKPe?=
 =?us-ascii?Q?Y69CDWnX94E1HO6uJoU9CCOTgFEazY8srSRSzqbuBedwC6SJ/p2zhWrqaFra?=
 =?us-ascii?Q?V/CrWT+VmoriIgoYSynZ3IB/TRnY99cf/+UP8bITmmMyalwKmrEXL1E3syRS?=
 =?us-ascii?Q?wQhBlvlhu1kqwyr1fBt/dLL5b39KflUpXPIQFigkUxdyHT0K0W72fa969lgk?=
 =?us-ascii?Q?7YByGwc3w/CSDmE8j942YT4bkpxCCS+NOquN1fyIBgU+qwzXPnp6yN66ngYS?=
 =?us-ascii?Q?atr+pNlehK3FMmGUw2KiN4a/uiAYWBHi7wYxinPvEZYca5i6U3kEnqGofA4W?=
 =?us-ascii?Q?tV0iNAkZkKXuxcopFkPzyMprtrKRigfqdGjyPW7QuxcrOMztnNdc6pvB6l6U?=
 =?us-ascii?Q?2knQkhxu9pS9hYA5u6sdnP0DePKQeOTw44Hjk715EzkAMCll8QF0HV2u2Ng4?=
 =?us-ascii?Q?pzWU7SffO6tXe1q89njieVkGGl3qdNvNC0gAQDQBg2KIsyRMgOvVsVPTTEmy?=
 =?us-ascii?Q?Q+j6pGT4FPwVyJO9r+c1kco/35n9IboVkpPzXTLoghcwXmkmYU5hDtd0n5p/?=
 =?us-ascii?Q?fNjyXnZdORXKbt8IlBtW6mopNTmq2mJbYtP+C6XnVa5RDAwTHpUF0ZIo3F3q?=
 =?us-ascii?Q?zes2ME7WN99bleeSlLGGNEehrdpNcPG9FiiOxHFpilAy3j7V9SBfKIZCsBzY?=
 =?us-ascii?Q?Pux7OsDfUNDUp9qo5/wo6icqf7RXF87v+II6pQsM7hYucO+O05r6xjsWOSXc?=
 =?us-ascii?Q?AQ9FmQYtcKSYHlU1jyUHpF0dMQHfvOblt9Vs+Z24ic9W4NFsBB2LMWdHYqkg?=
 =?us-ascii?Q?4tXQrXnBZIaGaWKlqfE1FmcxnmVwZPrml6NocECGe4YgKp2Xy9brDUvKK0Fp?=
 =?us-ascii?Q?UWsaNtJiWnxPsRXbJInuW5JJctKvWn+r+R/72b3JdTLmtXzYCVzkNSddGRuf?=
 =?us-ascii?Q?2cu8UrEAWgkgILEkIMlpoKUKimQ8twoJsWb+K3hyphGelazpaPQYsQJNff47?=
 =?us-ascii?Q?SWLAKCbPutSPyFtdxpHqG/Oec6JxJfeo2rR7brzZrAyTVPvkv8xr0aDpNViw?=
 =?us-ascii?Q?yC/1WVHiIxW7iOJdaMX2qmOd7JgEkmF6LxCjLUlBpu32f7b91g+1CvFl0mIJ?=
 =?us-ascii?Q?uAudJFeDFofOXvYF16O9uvDMp5UmbIxQGWufGJTgzmITh7u+MjGof4tZnjmB?=
 =?us-ascii?Q?ncf9mehH/vNHfQBd7XZg0hhldB7vY+aaeJsBKoKggBsy/B4fW1O/KmnGFy32?=
 =?us-ascii?Q?1XiLdxhVErPq0czUJwcBQWPd306q+NMbFPESwBc16jwSAsTcFPwxctNs/3Md?=
 =?us-ascii?Q?h+fe0ifZxkNxE+25ROujOxW0DNQR0n/FhHZTS5mi6claleDXDO4vD07lgODj?=
 =?us-ascii?Q?DvjLd2SByO9febOELsxPbJt3txmJ2aCAifYaPJQXvtJzVqyo0RCReAuXoZNk?=
 =?us-ascii?Q?V4m5f0xTivjYyvv5OuCp5Fdml0WSMF6fHzUUfIJYh4ECj/RYNp8KaGFw2Zx+?=
 =?us-ascii?Q?mfo8Pw=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1e7723ec-ed28-4b17-0c38-08db6148560d
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2023 19:59:11.3924
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wonDxq0DS1Sipbn3uch5+KSY0ymNH8YOVeVTcWaC945GyLO22j3ylNg5fjp4RWa/tZjmAmp66PLLOM6AKC/OJQ+nNRR1+JKk1MRD7MMvE9I=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR13MB4839
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Fri, May 26, 2023 at 12:17:36PM +0200, Sascha Hauer wrote:
> On Wed, May 24, 2023 at 01:34:52PM +0200, Simon Horman wrote:
> > On Wed, May 24, 2023 at 12:39:34PM +0200, Sascha Hauer wrote:
> > > When receiving more rx packets than the kernel can handle the driver
> > > drops the packets and issues an error message. This is bad for two
> > > reasons. The logs are flooded with myriads of messages, but then time
> > > consumed for printing messages in that critical code path brings down
> > > the device. After some time of excessive rx load the driver responds
> > > with:
> > > 
> > > rtw_8822cu 1-1:1.2: failed to get tx report from firmware
> > > rtw_8822cu 1-1:1.2: firmware failed to report density after scan
> > > rtw_8822cu 1-1:1.2: firmware failed to report density after scan
> > > 
> > > The device stops working until being replugged.
> > > 
> > > Fix this by lowering the priority to debug level and also by
> > > ratelimiting it.
> > > 
> > > Fixes: a82dfd33d1237 ("wifi: rtw88: Add common USB chip support")
> > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > > ---
> > >  drivers/net/wireless/realtek/rtw88/usb.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/net/wireless/realtek/rtw88/usb.c b/drivers/net/wireless/realtek/rtw88/usb.c
> > > index 44a5fafb99055..976eafa739a2d 100644
> > > --- a/drivers/net/wireless/realtek/rtw88/usb.c
> > > +++ b/drivers/net/wireless/realtek/rtw88/usb.c
> > > @@ -535,7 +535,7 @@ static void rtw_usb_rx_handler(struct work_struct *work)
> > >  		}
> > >  
> > >  		if (skb_queue_len(&rtwusb->rx_queue) >= RTW_USB_MAX_RXQ_LEN) {
> > > -			rtw_err(rtwdev, "failed to get rx_queue, overflow\n");
> > > +			dev_dbg_ratelimited(rtwdev->dev, "failed to get rx_queue, overflow\n");
> > 
> > This is certainly an improvement. But as I understand things
> > it is still somewhat verbose if the condition persists.
> > Did you consider dev_dbg_once()?
> 
> My rationale was that dev_dbg() is normally disabled anyway. With
> CONFIG_DYNAMIC_PRINTK you would still have fine grained control if you
> want to see this message or not.
> 
> Personally I don't care that much, I would switch to dev_dbg_once() if
> that's preferred.

No strong preference from my side.