Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp177325rwd; Wed, 31 May 2023 21:26:28 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6BCiSroM88OX61t4FMnSdGXq5JMNCaLx21yoM369WSju4zxUlf/32Y2M7+ryMx3gTGzxYY X-Received: by 2002:a05:6a00:1746:b0:64f:74d9:eb4f with SMTP id j6-20020a056a00174600b0064f74d9eb4fmr9441531pfc.32.1685593587933; Wed, 31 May 2023 21:26:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685593587; cv=none; d=google.com; s=arc-20160816; b=EXAWjV/1qCKunKXU2DPHU24eSjtXqfavy4AGDo+CC5VTWxVFhFTv2v4yOkJEwKDmnf +8YV2/o+MWw9zbssF/o8xXXfn4I22rfXGyWeopasSfA+T09yN04T3F5GOPA9kvoBXljE 5fYwhFvdSqPnQ1R6vMbSlN1Hay0ri3eynIsKdhYqFm5hNwJdfcR1lr3WMJLIIl9HcPe3 Lz4VOI386Q0E+ho4FPGr4Y0RH5wMQ32H8l6DHv2jPJGT1y2SrJ7CY9e//ncbUtg7TUkW NDJb429NZcsXkvqunlzQ5fc7jIljR8ICGjp9cGkYtEM1GUmSHphWXB80wNwbch/2IBcv kCwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=0hYwtigvGuQpKAdJ9QspU81fiINqHhqpOEH5PxR2z34=; b=A2qyRZcEZG0/pgidnpDg2rSe6IX7eZcyeIafXfn5eYKz+b/xN9+T2zEex9bwOEj3yT wWukbOvrHmDNfbUXnrN0hRSeYo592bAswcdKjRY9K+YDXiHjDE4QiGBYMgF+qlooROET lUBeXt9y0hs11Qrp0sZpSRuyVzPlB6fhaot1kp7e/xZFPv5hg87hp5Xn1k1vA0+PTG2a alBE2qmHcoebHpVhEFpAr23Y4DqpyAkmczQ8y3CWJ6E74dqLUX99+zAaP1FkMTp69LuF 9grwA1Q6DXDJCxVSym7TJ5kDqeCWsxqMxne9QxrO4vOI1M0NoPhoKOoe8rV55Ne0ZHah RDCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KrSwinup; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m9-20020a637109000000b0053b28418dfdsi2102062pgc.193.2023.05.31.21.26.19; Wed, 31 May 2023 21:26:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KrSwinup; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230110AbjFAE0C (ORCPT + 64 others); Thu, 1 Jun 2023 00:26:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229562AbjFAE0B (ORCPT ); Thu, 1 Jun 2023 00:26:01 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0AAA3101 for ; Wed, 31 May 2023 21:26:00 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9D84663689 for ; Thu, 1 Jun 2023 04:25:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 43292C433EF; Thu, 1 Jun 2023 04:25:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685593559; bh=V7fI4XEjnNZk+iN+EP2u/wmo7xyoIyh84s6MyENF4BU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=KrSwinupbKOXFA8VvXcp0Re81B5LQWHZAgo3YQWszpx6rFPMCiIEmQaKhcf3PAQX9 KFcr0DDWS3gfunujmUtODiKvRakiANvY79H8p2HtsINikzbHg9H+QTR8OTM/F7129N W2GTYsxltEjKseTfVY+M5CyMtqJMPZCoF7K1e3V2ePy41ocX1Xrb8pVLCWYR/4IbgX HMjHjpp8CswssPXHXuKM1oNN1aKFWb7lBGiV3uuu86dlks9fD5J6vdCATJGQfM3tz8 vYCf6EuXrR15xUTZzpsjONM7DVSpxmglBkjfz+NJKkUdFjBlZQn0JQv04H+fZTKEy6 9ISLMeo7Yw6aA== From: Kalle Valo To: Neal Sidhwaney Cc: linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com Subject: Re: [PATCH] wifi: brcmfmac: Detect corner error case earlier with log References: Date: Thu, 01 Jun 2023 07:25:54 +0300 In-Reply-To: (Neal Sidhwaney's message of "Wed, 31 May 2023 22:23:48 -0400") Message-ID: <87h6rrkdv1.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Neal Sidhwaney writes: > In some corner cases, an I/O read can fail and return -1, and this > patch detects this slightly earlier than is done today and logs an > appropriate message. > > Signed-off-by: Neal Sidhwaney From looking at patchwork the patch seems to be malformed: https://patchwork.kernel.org/project/linux-wireless/patch/CAJ4cxaQiYWEOmf9sZHsvXqYc_SKSg2dm5jQvifa82+o+W41aNw@mail.gmail.com/ I strongly recommend using git-send-email to submit patches to avoid issues like this, more info in the wiki link below. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches