Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp247863rwd; Wed, 31 May 2023 22:49:40 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4/vxpJJyb5xNHezWewomyugQbagGfgWPBDakUMyJsCXaUpbY6XYZ+Rlmz9Xql2zVsA7LlJ X-Received: by 2002:a05:6358:4411:b0:123:6652:f581 with SMTP id z17-20020a056358441100b001236652f581mr5421951rwc.4.1685598579909; Wed, 31 May 2023 22:49:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685598579; cv=none; d=google.com; s=arc-20160816; b=v0S42xeclZ79bhy6QXCMsR3Y1aY7Vrm/58VqXxDt0ljVdwDyIbu2XTlW2EaPJKZpWA 0qwMdr1hCjcpfOxTYtENvUWUzwsZCnA8rdj1ESPwiqp1mtqjfIagHqMLy2Zjyj07SNoj nn7ip4/SNZj+2q210JsOL2rxLtqmba0EJoX3Ixw0mOi7SK/6iPxbp2Vr5SBXDQmiWWvN BHIvVaotihDn+XlOvs0OENA48OglV20bAiBUC8RkP3jxq4aEFwiL+G/2Vf7W2A3XB14o SPKf6Y6gFPYngqftNl1Wi0rDPa/wjW6x///MlCCDP+3PauiajZfOF4DXSjUdp92Ovx5i uPlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=jTn6xRAeFYV1FkBSB4Lg+6PL5ILEu7rjlQAxqg/3DOw=; b=uJKnWDHDR0w4jTtwXYUrLTumpglLOR7r+SwXEqd+lHBhmRodG/fqWSR411Ab/K5TIo K/54VqezKW8fa3KR4TBMVeiYigaOH9q/9vrHnFo01BuCY7gxTWdItr2Wb3HkHw61zMUY 4JGXm5SH073eOuXiSGdpX/JmqEW8aHNJtJ9P6jh3ZxdVX+hUeYcezQo1bDl2uRGNVhQK sEhfsobx/PmbxVm7S3U8Tu2NSBnb6MQJvXDT3u8EqBiArA5IIrFJ+fBvu6vA77Ct/9YC roMWawWqRA8ZmbnO+tvirKsI2mBJRJUKiQxCKkU1A/4MNSU8L0nAw0BAqijp/enVljrD I+ag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ex8oWCDt; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 89-20020a17090a0fe200b002565804077bsi607771pjz.32.2023.05.31.22.49.30; Wed, 31 May 2023 22:49:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ex8oWCDt; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231649AbjFAFsb (ORCPT + 65 others); Thu, 1 Jun 2023 01:48:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231706AbjFAFrl (ORCPT ); Thu, 1 Jun 2023 01:47:41 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D015193 for ; Wed, 31 May 2023 22:46:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 28EF66410B for ; Thu, 1 Jun 2023 05:46:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 91FCCC433EF; Thu, 1 Jun 2023 05:46:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685598400; bh=XWzczwSVD81gIENTfEhJ4epaujBLX/EjJGMZiLS1eJ0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ex8oWCDtVzR6fdxs3TkWYUA6TdR0kDrTNt+speRSf0rKIXqYPn3dZeMcBT71qs3rz 9SA5XadAMgI55S37eCOVa46WiIJdAuISmOVta+l+tz6KyzmivtyFao9x2xhW6z5pa2 Kj3WqRd8qoEKqwgJISDo3zLeAp5gTPKNmgKQ7C6ISr9pEqjDv1GWa5OGgWW2kHOv6v w7CBKbPYCe1cxgpIEm05z2wonhNYHAee3suBIhIUmYLUWttUq2Z0WDpv10f/5x9FUf NL7xP65tSfoxduXTGxC7i2eds8KRV1Z1MObAZ+rjv+Zix9NannXedaA1lePHR3dxYZ JsgKJlrI2R3ew== From: Kalle Valo To: Ping-Ke Shih Cc: Dmitry Antipov , "linux-wireless\@vger.kernel.org" , Dmitriy Antipov Subject: Re: [PATCH] wifi: rtlwifi: remove unused timer and related code References: <20230531143001.674220-1-dmantipov@yandex.ru> <20230601042352.7746-1-dmantipov@yandex.ru> <6c9982b9f48e41c4ba4f3528cb5489fd@realtek.com> Date: Thu, 01 Jun 2023 08:46:34 +0300 In-Reply-To: <6c9982b9f48e41c4ba4f3528cb5489fd@realtek.com> (Ping-Ke Shih's message of "Thu, 1 Jun 2023 05:10:36 +0000") Message-ID: <87leh3ka4l.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Ping-Ke Shih writes: >> -----Original Message----- >> From: Dmitry Antipov >> Sent: Thursday, June 1, 2023 12:24 PM >> To: Ping-Ke Shih >> Cc: Kalle Valo ; linux-wireless@vger.kernel.org; >> Dmitry Antipov ; >> Dmitriy Antipov >> Subject: [PATCH] wifi: rtlwifi: remove unused timer and related code > > Should increase version number such as v2, v3, ... for newer one. And also always include a changelog, see the wiki link below for more. > Checkpatch warns this patch: > > ERROR: Missing Signed-off-by: line by nominal patch author > 'Dmitry Antipov ' Yeah, From and s-o-b need to always match. > Maybe, you can adjust your s-o-b to e-mail address of "From". It's also possible to add a second From field to the body of the message. Here's an example how I do it when I use kernel.org to submit my patches: https://patchwork.kernel.org/project/linux-wireless/patch/20230530141813.29333-3-kvalo@kernel.org/ -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches