Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Minjie Du <duminjie@vivo.com>
To:     pkshih@realtek.com, kvalo@kernel.org
Cc:     linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
        Minjie Du <duminjie@vivo.com>
Subject: [PATCH v1] drivers: fix the parameter bin reference preceded by free
Date:   Thu,  1 Jun 2023 15:23:22 +0800
Message-Id: <20230601072322.486-1-duminjie@vivo.com>
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xuXRfkNGl0rRz5fegu+S03z4YFyxxloAXuuC4Xh8RPtD795BH98Fj20rR+T4?=
 =?us-ascii?Q?+MaL1ASYgfhQ2wFeYG2iHXsB3C4A/d4btYyVkPA8k2JpZgrFApJNbzTW/jTA?=
 =?us-ascii?Q?eicMJUIca9M5rJl69LTEN/h0ZwgTwGT9tl1hlwQNdKCvOoCkqzNri2TZyJ5k?=
 =?us-ascii?Q?v0/N+ASu46s4h+6CmW+M1u6F3nqgiSAVXqWSArZk8zKg0LxejmLn8227WEEI?=
 =?us-ascii?Q?mMihpBqxLx5RykPYe3uXhNLV1KrR3VXw6zgyvSB6DzdLW9cOFOOpISufYEFn?=
 =?us-ascii?Q?/eRq5GE7G37BcevVQYgwYxJcfZ0TKcugRzOlKNjsmgUJtlFj9d76fR2RQIBS?=
 =?us-ascii?Q?nQk50RGHaVhfqBZlyW1Puj+mq9ONkUso2fXZSTD7y4U0EmsNtxzt48T63NDj?=
 =?us-ascii?Q?lltaiaQSWewwb4YWVRvxEvZHya933+dRskVpYic18LbVWcMfDrazyXjiQEOj?=
 =?us-ascii?Q?8B2WMPBTPZzl+y7U8l9+a7jmI3nVQoFPfdGwyL/0NSlRpB0FYATPqMgi8EAp?=
 =?us-ascii?Q?tzlXhssKIDlqzTTZOQrZf6QqR2Uvqc27qtdzuqkNplUscQI6AW6AARLLpsZT?=
 =?us-ascii?Q?amhonDvT0v6byLkg6Pp6piwpaeWZbI2+YI8K/CyForVUAiBPysBpebKPd3EQ?=
 =?us-ascii?Q?JB06CFRHkJohrVjEDPwwGf9lcMOVqey63Z82azalX1OGFBziQOGujfjDgusZ?=
 =?us-ascii?Q?bdqQ9bXa4uHCBm3ZqECWiAULrKJjhYz4kyQg7ffc2g9u3nrnir8B6g5itxdE?=
 =?us-ascii?Q?QN639nYcnW18WqKsvUkQeOqPR6nb+CUehVma2tYLXcv4u3f8EocrLRzuurbX?=
 =?us-ascii?Q?OjjvrEGCZWb0FFvQbdXWMP94O396frYy96sjKRhihjeFzh2Xr4mqGASWgpn5?=
 =?us-ascii?Q?vJ8eFZuLcI3U1f77PiQXDwtSTcL+CpU5vZVS1yU9vMp/xRWghBFYPUabNQgr?=
 =?us-ascii?Q?PiZ3x74Gjt8nE+6DjcBevLneHJf9S2Kk0k+sywyJNoV797uutkhwUBBYRf4C?=
 =?us-ascii?Q?Ned/jJY3iC75nlc9iIMs+zUDFfWIvJie8Dg1NZDkjChSQJcYC9dBy1sLqbVq?=
 =?us-ascii?Q?veyzybrE6AN/Cdwaof1971CX2XziabwBHMzlbi2HL1jTn+qWMl+QPQWPl3Xw?=
 =?us-ascii?Q?64cYmlWqT/BOXUXaRHoSRPkPiP07KN2QqedfmdRigRglkMf/yM4ynB78i7EZ?=
 =?us-ascii?Q?zBe0gACH8FaYHS/CYgDW/p/k9i7mx5QbAV26t6u6v3hiX3B5hWAZhgCbSb+x?=
 =?us-ascii?Q?VaU5gcU2R1KEsl1oyKV3fflOa99IytKrAmU3zk9TxuKGivh+BUZ6E3CEimdY?=
 =?us-ascii?Q?d6QioVLWaCvw2DdnZ6MI/83ajQK9Skrs2l0+jbTo+WI61pKgUDTzzn6+cmfk?=
 =?us-ascii?Q?Cna2tLAzvc4iOEdaaIV12cmveiJfkwt2m7bEqGFDLRWkKU1u2k8cZXOeSwXC?=
 =?us-ascii?Q?ca5/WCCEX8ByqMpxJgzGKZBzA9myJCF6bst30NmBr9rbJy3qaGHsPvVO6do0?=
 =?us-ascii?Q?GCyWgWb8CKgyHegMiskvUay9PUuiGzVZDXzJZvBNNXYoJ3vP8SA0Njfv1VZ+?=
 =?us-ascii?Q?nOMqDPQOoDYFqndtFP+PE6I30t6xRFUx+TtbOSXi?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3b6f9d59-5144-4eeb-1b16-08db62711b98
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB4111.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2023 07:23:33.9012
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8V7WKDa2tmdEyQrSeVMnnoU0WtJaYlgrjtHBSmsuEogi+CX4QV4qcLxbBm2SPSOtCdViCAV6XSqUG9Cl+qfr2g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: JH0PR06MB6344
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

We assign the variable bin to NULL,
fix variable bin reference preceded by free.

Signed-off-by: Minjie Du <duminjie@vivo.com>
---
 drivers/net/wireless/realtek/rtw89/debug.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/realtek/rtw89/debug.c b/drivers/net/wirel=
ess/realtek/rtw89/debug.c
index 6f418f14ec3f..4541b4d48e69 100644
--- a/drivers/net/wireless/realtek/rtw89/debug.c
+++ b/drivers/net/wireless/realtek/rtw89/debug.c
@@ -2982,6 +2982,7 @@ static u8 *rtw89_hex2bin_user(struct rtw89_dev *rtwde=
v,
        if (hex2bin(bin, buf, num)) {
                rtw89_info(rtwdev, "valid format: H1H2H3...\n");
                kfree(bin);
+               bin =3D NULL;
                err =3D -EINVAL;
        }

--
2.25.1


________________________________
=E6=9C=AC=E9=82=AE=E4=BB=B6=E5=8F=8A=E5=85=B6=E9=99=84=E4=BB=B6=E5=86=85=E5=
=AE=B9=E5=8F=AF=E8=83=BD=E5=90=AB=E6=9C=89=E6=9C=BA=E5=AF=86=E5=92=8C/=E6=
=88=96=E9=9A=90=E7=A7=81=E4=BF=A1=E6=81=AF=EF=BC=8C=E4=BB=85=E4=BE=9B=E6=8C=
=87=E5=AE=9A=E4=B8=AA=E4=BA=BA=E6=88=96=E6=9C=BA=E6=9E=84=E4=BD=BF=E7=94=A8=
=E3=80=82=E8=8B=A5=E6=82=A8=E9=9D=9E=E5=8F=91=E4=BB=B6=E4=BA=BA=E6=8C=87=E5=
=AE=9A=E6=94=B6=E4=BB=B6=E4=BA=BA=E6=88=96=E5=85=B6=E4=BB=A3=E7=90=86=E4=BA=
=BA=EF=BC=8C=E8=AF=B7=E5=8B=BF=E4=BD=BF=E7=94=A8=E3=80=81=E4=BC=A0=E6=92=AD=
=E3=80=81=E5=A4=8D=E5=88=B6=E6=88=96=E5=AD=98=E5=82=A8=E6=AD=A4=E9=82=AE=E4=
=BB=B6=E4=B9=8B=E4=BB=BB=E4=BD=95=E5=86=85=E5=AE=B9=E6=88=96=E5=85=B6=E9=99=
=84=E4=BB=B6=E3=80=82=E5=A6=82=E6=82=A8=E8=AF=AF=E6=94=B6=E6=9C=AC=E9=82=AE=
=E4=BB=B6=EF=BC=8C=E8=AF=B7=E5=8D=B3=E4=BB=A5=E5=9B=9E=E5=A4=8D=E6=88=96=E7=
=94=B5=E8=AF=9D=E6=96=B9=E5=BC=8F=E9=80=9A=E7=9F=A5=E5=8F=91=E4=BB=B6=E4=BA=
=BA=EF=BC=8C=E5=B9=B6=E5=B0=86=E5=8E=9F=E5=A7=8B=E9=82=AE=E4=BB=B6=E3=80=81=
=E9=99=84=E4=BB=B6=E5=8F=8A=E5=85=B6=E6=89=80=E6=9C=89=E5=A4=8D=E6=9C=AC=E5=
=88=A0=E9=99=A4=E3=80=82=E8=B0=A2=E8=B0=A2=E3=80=82
The contents of this message and any attachments may contain confidential a=
nd/or privileged information and are intended exclusively for the addressee=
(s). If you are not the intended recipient of this message or their agent, =
please note that any use, dissemination, copying, or storage of this messag=
e or its attachments is not allowed. If you receive this message in error, =
please notify the sender by reply the message or phone and delete this mess=
age, any attachments and any copies immediately.
Thank you