Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp409012rwd;
        Thu, 1 Jun 2023 01:49:23 -0700 (PDT)
X-Google-Smtp-Source: ACHHUZ6PHrPdh5IFMi5XrNno6Z5f/C/yXx61Z6qljfVbIZKD+nblq4FmCS9oIIWGLHFogQdbjWsv
X-Received: by 2002:a17:902:d481:b0:1a1:9020:f9c7 with SMTP id c1-20020a170902d48100b001a19020f9c7mr9107756plg.44.1685609362807;
        Thu, 01 Jun 2023 01:49:22 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1685609362; cv=none;
        d=google.com; s=arc-20160816;
        b=YPtKqVoXmKqMjfAdnr5WxWkTw045QWaVEYqVmAS7/UCotNMboog8jiDbhFfY/mavdl
         d8DJlJbAjCEf4a93X9ITw8ZKs8aqJ8cDhLXLoEjQox3cBQlhGtNFwCf6viXC8PpJisNQ
         7lnfgs4MrSY6Tjc8po3l3dbCmBIH8RQ9ppNfsA0EBL9BCjg90AiG6ay0hdvTIcZ/qKxJ
         2Q52ClrzbdnwuOqa1qTPNBpMt9+GVjQbSmANWUgTmJ/Obtf3PEgWXIay4xmegMTix1X7
         2VETx7C5ODfRDv1dl/RQvevbKRTA6/KtDMpIVjcSX+y+czpm58/gx4sDsQapID/7w3fJ
         fI5w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:mime-version:user-agent
         :content-transfer-encoding:references:in-reply-to:date:to:from
         :subject:message-id:dkim-signature;
        bh=iiCEvE7WPvwLnzqEnubMTOItfRP7CMsDeGL5KZqBD30=;
        b=IN/PeyVZis8RycazfTRlaKYMjHhzCKOcfWA4L7nAm80Uuupuab6cbyja6c9tHND6E9
         hujnn3CXu7xtv3AqOsIm3sy8/dYxdOnjdU5ckXHkmQEE56oZucecresbp6KZoq5x4lSr
         e4X2GINKndtFpFT4MnnrahkLSQtRs+MG+f5FHdI6Cw5gs74IfVgmGvoxO4KLmcmM9VZ1
         Kt592IPKuRqNyIwSy854bcB5rPOqXEGrwXZZ717imH18cr9Uj4Z1tO1CD/uvAATHtFOE
         len1AoUddqnm3939/cfngU7bQFQlvMArQHrWA7cXsIcxKVOy8JJxgMt1OKOeBpJrHgRI
         MiQQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@sipsolutions.net header.s=mail header.b=RSNqTe5h;
       spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net
Return-Path: <linux-wireless-owner@vger.kernel.org>
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
        by mx.google.com with ESMTP id j14-20020a170903024e00b001b075e2e994si476940plh.575.2023.06.01.01.49.14;
        Thu, 01 Jun 2023 01:49:22 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@sipsolutions.net header.s=mail header.b=RSNqTe5h;
       spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S232300AbjFAIhm (ORCPT <rfc822;zoranvukanac@gmail.com>
        + 64 others); Thu, 1 Jun 2023 04:37:42 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44574 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S232314AbjFAIhQ (ORCPT
        <rfc822;linux-wireless@vger.kernel.org>);
        Thu, 1 Jun 2023 04:37:16 -0400
Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 666491727
        for <linux-wireless@vger.kernel.org>; Thu,  1 Jun 2023 01:35:55 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding:
        Content-Type:References:In-Reply-To:Date:To:From:Subject:Message-ID:Sender:
        Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To:
        Resent-Cc:Resent-Message-ID; bh=iiCEvE7WPvwLnzqEnubMTOItfRP7CMsDeGL5KZqBD30=;
        t=1685608555; x=1686818155; b=RSNqTe5hbQORxnB+9R4GIVlml1f/u5Fj/CkcFZIIE42MfrX
        tY45zlYDD5WJWQtGqA/trQx6LAsfBPVFRLrcOUQ9joCbXr/fPa9EmXAkAzrvf9pvskGTJyUEiMR++
        EP1vwe4/V+bCNWldRnceDk5MSwCwxCVGkghG9g+IL3r8bB7sPyw6KR/3dvgrfGO6a/KjwymWevDAV
        7qSVMd0exMegKiAS/uuHe/QAfxlDDXCZWjLLL/EiaJAgur/H4u2jZ8VB2VRkw1/U7Q8KEib/lAjK5
        rcfGhzcvOU4eI/UZT39IrgRCq054+b40PdQQHBlGaQ8Ys6XSSwAQKfjD0/5owA6w==;
Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)
        (Exim 4.96)
        (envelope-from <johannes@sipsolutions.net>)
        id 1q4dmi-00ALAq-2S;
        Thu, 01 Jun 2023 10:35:52 +0200
Message-ID: <21f6e68474f248e3288ddb24696401ae0a3553e3.camel@sipsolutions.net>
Subject: Re: [PATCH] wifi: iwlwifi:  Add support for tx-override feature.
From:   Johannes Berg <johannes@sipsolutions.net>
To:     greearb@candelatech.com, linux-wireless@vger.kernel.org
Date:   Thu, 01 Jun 2023 10:35:51 +0200
In-Reply-To: <20230531231214.2694997-1-greearb@candelatech.com>
References: <20230531231214.2694997-1-greearb@candelatech.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) 
MIME-Version: 1.0
X-malware-bazaar: not-scanned
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org


>  	struct iwl_mvm_ethtool_stats ethtool_stats;
> +	struct iwl_txo_data txo_data;

Might be nicer to have this a pointer and be NULL if not active? that
way you can also use proper RCU protection for it when changing it.

johannes