Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Date:   Thu, 1 Jun 2023 07:33:02 -0700
From:   Guenter Roeck <linux@roeck-us.net>
To:     Gregory Greenman <gregory.greenman@intel.com>
Cc:     Johannes Berg <johannes.berg@intel.com>,
        Kalle Valo <kvalo@kernel.org>, linux-wireless@vger.kernel.org,
        inux-kernel@vger.kernel.org
Subject: Re: [PATCH] wifi: iwlwifi: bump FW API to 78 for AX devices
Message-ID: <f7e417e0-5277-4085-bb50-fb43bdc52f7a@roeck-us.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Precedence: bulk

Hi,

On Mon, Apr 17, 2023 at 11:41:34AM +0300, Gregory Greenman wrote:
> Start supporting API version 78 for AX devices.
> 

This patch sets the ucode version for a large number of devices
to 78, but ucode version 78 is not available for many of those
in linux-firmware. It seems that .78 was skipped for some devices
in linux-firmware, and the last version for several others is .77.

This causes problems when trying to validate if the firmware
listed in MODULE_FIRMWARE actually exists.

Is the missing firmware going to be available at some point,
is there a plan to fix the code to only list actually available
firmware, or is it a wrong assumption to expect that the
firmware listed in the kernel actually exists ?

Thanks,
Guenter

> Signed-off-by: Gregory Greenman <gregory.greenman@intel.com>
> Link: https://lore.kernel.org/r/20230417113648.5a4dcbf5a2c1.I125808566fe892ee0865e392bf1b1872daafe8ad@changeid
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
>  drivers/net/wireless/intel/iwlwifi/cfg/22000.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/intel/iwlwifi/cfg/22000.c b/drivers/net/wireless/intel/iwlwifi/cfg/22000.c
> index b98f0ff02362..532d14f61253 100644
> --- a/drivers/net/wireless/intel/iwlwifi/cfg/22000.c
> +++ b/drivers/net/wireless/intel/iwlwifi/cfg/22000.c
> @@ -10,7 +10,7 @@
>  #include "fw/api/txq.h"
>  
>  /* Highest firmware API version supported */
> -#define IWL_22000_UCODE_API_MAX	77
> +#define IWL_22000_UCODE_API_MAX	78
>  
>  /* Lowest firmware API version supported */
>  #define IWL_22000_UCODE_API_MIN	39
> -- 
> 2.39.2