Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 1 Jun 2023 18:16:58 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
Cc:     Kalle Valo <kvalo@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, ath10k@lists.infradead.org,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        kernel@pengutronix.de
Subject: Re: [PATCH net-next 1/4] ath10k: Drop cleaning of driver data from
 probe error path and remove
Message-ID: <ZHjEehXjebG9pxuK@corigine.com>
References: <20230601082556.2738446-1-u.kleine-koenig@pengutronix.de>
 <20230601082556.2738446-2-u.kleine-koenig@pengutronix.de>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230601082556.2738446-2-u.kleine-koenig@pengutronix.de>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b2JZRE15L29QZlhsOGRtS3BKbzdodEYrNVRqMzU3QzRsYU43QUFiWXQzeWhZ?=
 =?utf-8?B?TFRWMjVxM2lMZUlrZ1RzdE10eWJ1M0RhZlhZQzM5bGFoZ2tYNHdndEVVVVdz?=
 =?utf-8?B?MXRWRUVWSTdXQ3RoeVpaUWZ0QlNjbzFRb1VXVWhkTXMwaWVBSkwvYm1GRC92?=
 =?utf-8?B?cjZ4QnAzR0pNT2VtMmFkZ0xIVTR0azJtbVJGdWRLM1NQT1kvYnVoSEFFU2ZB?=
 =?utf-8?B?R1VpcWZuVzdzN2xoVUVRMTFkMkFoRTZRTVRNSG9uUUFKZ2tYQTZGMjhNMmxv?=
 =?utf-8?B?N1l0akxNd1U3NDJOWDAxKzZTcWhnSGRkVEVRQ2JkbkU0WlV2ZzdyaFNRQWda?=
 =?utf-8?B?dlBDeFBLWmN5N20wbGtlczdYNmplQUFyRUhRbUw2b01wSm8rTTNxUFV0SlRT?=
 =?utf-8?B?UlFQbCtIMHV1NlF1U0JlWC9IVkxMaFZRWGhBY0cvV3ZjNmZ2UW5nUU50eFd5?=
 =?utf-8?B?V2YwSmUyNUZpVE4vSjBKRWg5QTBxSlBkZFZqVDUwY0JaZkZ3dDFoc0lmRE42?=
 =?utf-8?B?RENUc0swSnNRdm55akxkMkVycllrUlVFeFBqOHR3UHhvNnpwNk94dkwrU0tU?=
 =?utf-8?B?V3crdmZmdXlXaDZYRlM2S3d5RVBtOUhaUWRHK1N5a0JrMW83bk9vejJiOFFB?=
 =?utf-8?B?SHNFbHVBYmUxT2NNTW1SME4rWWNaRW5xRDM5QmlIZklER3hvRHZsQ0JuYTlz?=
 =?utf-8?B?NndlK3F4RmExdjJvaW41R0ltUDhHYXVSRlJYYUc1WXdRRmszL2tGN0R1b2dH?=
 =?utf-8?B?TXJWeDdjcDQ0aUllLzMxQlFDemJkeElNdGkwTVB1N2tPTmw2NVVDdGxIenpX?=
 =?utf-8?B?ei9wQys3VGFPUHY5NzR0TTl4cVJONThuMHpVaDBQVnQzNEN3Zk9rWHVnZlU2?=
 =?utf-8?B?emlveFJMWXJ4bEk5RXl2Z29rRlkwNW9DZ2ZqRmZzNGs5SVBCS0FmWGMrV09s?=
 =?utf-8?B?ZXlFWEMxRDdQMmpKRmpHZkkwVWtjRHE2c0N3dEdBTnRPNCs1TmxBTit0YUZN?=
 =?utf-8?B?WGRyNlVnOUhqTjBBUllVUTlKV3NMdkJrQml0ZEpDblptRFo0eTNmcTJvenVN?=
 =?utf-8?B?ZkNseENTMDFhYUIwSEdnL2hJb0t5WlNVZ01hM1NxVm15OWZXL3VkM25iODVN?=
 =?utf-8?B?M0V1ZnlmcGdmZTZRSGpQd3dOYnFHbWowdS9UWUVtZDFpM2dCYVM2elc5WTdI?=
 =?utf-8?B?VnliaE0rZW12d080VjZBQzRvd014WXNmMWxBemRrN3VuLzA0dUl6WkJqbFBE?=
 =?utf-8?B?Q3RUbWFTWG0zeXVMdHIxdXlnb01vZzZpNUx3cE1ZVWZ6U3dWS0pLaEJxcFFp?=
 =?utf-8?B?N002c1E0Z1RFbDRMSExVdE5ReDVtcWpDcE1tZ21SRDZueTh2cHFiTndDUWt1?=
 =?utf-8?B?dEJwZkluL0RCM3U4cHlFVlNEWDQzR3BxY0dFSmp5eDduUGsxYVptcTI3TXJi?=
 =?utf-8?B?aGVSRDNGRmpHY1doeUUvZm9DeW84Mnh2YmRzemhMUUFmbHl2K0hIbVlEY3pM?=
 =?utf-8?B?d0VQTXpFUHdxK05SNUJDdEFKRE5QWWFCQ21qcTZHd25iRUlQSzE1ZW02RjF4?=
 =?utf-8?B?MzVPUHJNOERPV0ZJNm1lTU4zbkNXSjZPRmh5NTQ1UFA3V2szWlAxd2ozS0hq?=
 =?utf-8?B?OHp5c1NYTEUrZk5ROHVMdlE3ZGVyeWhXOXlpWkhHbVFKRHJoS2phVzM5bmVw?=
 =?utf-8?B?aW9ZS1Y5Z2VMZGpxSFVTZ3ZVR2lXZnI4UFQzMnBqTWNScXJ5T3c4MDBGaUd4?=
 =?utf-8?B?cFBPbVZFUm9kaEZSZWtxWDRQK0FiUjZrakhaaTdUam1YV0VsOTlUQk0vaisv?=
 =?utf-8?B?bEpwRzFvY3hwSnB3QjJoTzNpdjFEMHBJWFh5RldIS3VzdGpZeG1sK3o0Q3cv?=
 =?utf-8?B?MlBKWDBzVEZ3Nno0SXF0dFNvd3hnQnV1VE5BWWdLMG1tUTdWYnhma0ZSdnU1?=
 =?utf-8?B?NEV0QXJCT2N2cnhoSEwydEMrK0dUcHlxdmt2QlVJMW5CZTZPaTE4SlJLb2Ev?=
 =?utf-8?B?TFJqRnNyMU8zdytKaVAyOHFDWnJlMmtBOGFJWVdHUERLR2JmTnBVMkVyMUtM?=
 =?utf-8?B?dG9JelAvekJxNjdNT3pyMkhWWlNuY01ILzVPTkJoMEZqcHpMOVBTVUZmTkVj?=
 =?utf-8?B?NzIya0xiT0ZER2JCUTFMTlFieHlqeTI5dWdvZzliQTlJcFA5a3dWd2F1RnIz?=
 =?utf-8?B?TEE9PQ==?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9eacac8a-f8ca-440e-05d0-08db62bba4fd
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2023 16:17:07.0777
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: b5sUq3I2IY0W/fEK1O6oY/70q5bRLngFcJ+FduE5a+fX6Fi+U5/8z0sFZR/FW+mSW3eiIdBEzz7t+EPCJ270Zt9aju/fJZMCPhCOGoT4yTU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO3PR13MB5783
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Thu, Jun 01, 2023 at 10:25:53AM +0200, Uwe Kleine-König wrote:
> The driver core cares for resetting driver data if probe fails and after
> remove. So drop the explicit and duplicate cleanup in the driver's
> functions.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Reviewed-by: Simon Horman <simon.horman@corigine.com>