Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Message-ID: <7cc45ce0-e472-5953-bbab-d15cfd96d0fe@roeck-us.net>
Date:   Thu, 1 Jun 2023 10:40:22 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH] wifi: iwlwifi: bump FW API to 78 for AX devices
Content-Language: en-US
To:     "Greenman, Gregory" <gregory.greenman@intel.com>
Cc:     "kvalo@kernel.org" <kvalo@kernel.org>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "Berg, Johannes" <johannes.berg@intel.com>,
        "inux-kernel@vger.kernel.org" <inux-kernel@vger.kernel.org>
References: <f7e417e0-5277-4085-bb50-fb43bdc52f7a@roeck-us.net>
 <1ee34c4b93dc0acb5bd51556ce5f60062b78f970.camel@intel.com>
From:   Guenter Roeck <linux@roeck-us.net>
In-Reply-To: <1ee34c4b93dc0acb5bd51556ce5f60062b78f970.camel@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 6/1/23 09:00, Greenman, Gregory wrote:
> Hi,
> 
> On Thu, 2023-06-01 at 07:33 -0700, Guenter Roeck wrote:
>> Hi,
>>
>> On Mon, Apr 17, 2023 at 11:41:34AM +0300, Gregory Greenman wrote:
>>> Start supporting API version 78 for AX devices.
>>>
>>
>> This patch sets the ucode version for a large number of devices
>> to 78, but ucode version 78 is not available for many of those
>> in linux-firmware. It seems that .78 was skipped for some devices
>> in linux-firmware, and the last version for several others is .77.
>>
>> This causes problems when trying to validate if the firmware
>> listed in MODULE_FIRMWARE actually exists.
>>
>> Is the missing firmware going to be available at some point,
>> is there a plan to fix the code to only list actually available
>> firmware, or is it a wrong assumption to expect that the
>> firmware listed in the kernel actually exists ?
>>
>> Thanks,
>> Guenter
>>
>>> Signed-off-by: Gregory Greenman <gregory.greenman@intel.com>
>>> Link: https://lore.kernel.org/r/20230417113648.5a4dcbf5a2c1.I125808566fe892ee0865e392bf1b1872daafe8ad@changeid
>>> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
>>> ---
>>>   drivers/net/wireless/intel/iwlwifi/cfg/22000.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/wireless/intel/iwlwifi/cfg/22000.c b/drivers/net/wireless/intel/iwlwifi/cfg/22000.c
>>> index b98f0ff02362..532d14f61253 100644
>>> --- a/drivers/net/wireless/intel/iwlwifi/cfg/22000.c
>>> +++ b/drivers/net/wireless/intel/iwlwifi/cfg/22000.c
>>> @@ -10,7 +10,7 @@
>>>   #include "fw/api/txq.h"
>>>   
>>>   /* Highest firmware API version supported */
>>> -#define IWL_22000_UCODE_API_MAX        77
>>> +#define IWL_22000_UCODE_API_MAX        78
>>>   
>>>   /* Lowest firmware API version supported */
>>>   #define IWL_22000_UCODE_API_MIN        39
>>> -- 
>>> 2.39.2
> 
> Yes, I'll send it just in couple of days.
> 
Thanks!

Guenter