Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     Neal Sidhwaney <nealsid@gmail.com>
Cc:     linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com
Subject: Re: [PATCH v2] wifi: brcmfmac: Detect corner error case earlier with log
References: <20230601054034.43692-1-nealsid@gmail.com>
Date:   Fri, 02 Jun 2023 08:32:07 +0300
In-Reply-To: <20230601054034.43692-1-nealsid@gmail.com> (Neal Sidhwaney's
        message of "Thu, 1 Jun 2023 01:40:36 -0400")
Message-ID: <878rd2jup4.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Neal Sidhwaney <nealsid@gmail.com> writes:

> In some corner cases, an I/O read can fail and return -1, and this
> patch detects this slightly earlier than is done today and logs an
> appropriate message.
>
> Signed-off-by: Neal Sidhwaney <nealsid@gmail.com>

The formatting seems to be correct now, at least patchwork looks ok:

https://patchwork.kernel.org/project/linux-wireless/patch/20230601054034.43692-1-nealsid@gmail.com/

But the commit log should always answer to the question "why?". Is there
a specific reason why you want to do it earlier?

> @@ -980,6 +981,11 @@ static int brcmf_chip_recognition(struct brcmf_chip_priv *ci)
>  	 */
>  	regdata = ci->ops->read32(ci->ctx,
>  				  CORE_CC_REG(ci->pub.enum_base, chipid));
> +	if (regdata == READ_FAILED) {
> +	  brcmf_err("MMIO read failed: 0x%08x\n", regdata);
> +	  return -ENODEV;
> +	}

Indentation here does not look correct, did you run checkpatch?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches