Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230601054034.43692-1-nealsid@gmail.com> <878rd2jup4.fsf@kernel.org>
In-Reply-To: <878rd2jup4.fsf@kernel.org>
From:   Neal Sidhwaney <nealsid@gmail.com>
Date:   Sat, 3 Jun 2023 02:07:03 -0400
Message-ID: <CAJ4cxaRAvaVqu6n2x-Oq2Y=QZ8ry1WMczikKhj+8D0mde9=3fg@mail.gmail.com>
Subject: Re: [PATCH v2] wifi: brcmfmac: Detect corner error case earlier with log
To:     Kalle Valo <kvalo@kernel.org>
Cc:     linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Jun 2, 2023 at 1:32=E2=80=AFAM Kalle Valo <kvalo@kernel.org> wrote:
> But the commit log should always answer to the question "why?". Is there
> a specific reason why you want to do it earlier?

Added context & motivation to the commit log.

>
> Indentation here does not look correct, did you run checkpatch?

Sorry, my mistake again.  I ran checkpatch for this version of the
patch, but missed it in the docs the first time because it's in the
"large patches" paragraph, which is very much not the case with this
patch ;)

Thank you,

Neal