Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <74f52855912292d48ea80d76f4685998a1c3beec.camel@sipsolutions.net>
Subject: Re: [PATCH 09/11] wifi: cfg80211: Add null check for ie data
From:   Johannes Berg <johannes@sipsolutions.net>
To:     gregory.greenman@intel.com
Cc:     linux-wireless@vger.kernel.org,
        Mukesh Sisodiya <mukesh.sisodiya@intel.com>
Date:   Mon, 05 Jun 2023 13:38:34 +0200
In-Reply-To: <20230504134511.828474-10-gregory.greenman@intel.com>
References: <20230504134511.828474-1-gregory.greenman@intel.com>
         <20230504134511.828474-10-gregory.greenman@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.2 (3.48.2-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2023-05-04 at 16:45 +0300, gregory.greenman@intel.com wrote:
> From: Mukesh Sisodiya <mukesh.sisodiya@intel.com>
>=20
> It's valid to pass NULL "ies" pointer to cfg80211_sme_get_conn_ies().
> Add the corresponding NULL-check to avoid NULL pointer access.

Yes ... but it's not valid to do that when ies_len is 0, since you can't
have NULL ies with a length ...

So ... maybe we can do this patch but certainly the description is
bogus. Maybe you're trying to fix some static checker warnings or
something, which maybe is fine, but there was never any chance for an
NPD.

johannes