Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Jun 2023 11:03:31 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Paul Fertser <fercerpav@gmail.com>
Cc:     linux-wireless@vger.kernel.org, Felix Fietkau <nbd@nbd.name>,
        Lorenzo Bianconi <lorenzo@kernel.org>,
        Ryder Lee <ryder.lee@mediatek.com>,
        Shayne Chen <shayne.chen@mediatek.com>,
        Sean Wang <sean.wang@mediatek.com>,
        Kalle Valo <kvalo@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, Rani Hod <rani.hod@gmail.com>,
        stable@vger.kernel.org
Subject: Re: [PATCH] mt76: mt7615: do not advertise 5 GHz on first phy of
 MT7615D (DBDC)
Message-ID: <ZH72YwgpywPNxbd2@corigine.com>
References: <20230605073408.8699-1-fercerpav@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230605073408.8699-1-fercerpav@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ztEVLp+RRakxsPZNTVbGTgc7OWpXeRPSOI7E5SDIz5khooI2KOOrkIyk/NEm?=
 =?us-ascii?Q?PePFG3IzttXUjOespF5b2BVmGIwEI5++Lhvl+WPsyS1GrVJF+ZudnbKbC0qR?=
 =?us-ascii?Q?mr91M/OhtapnoAo17bfakdVzstu+1yFaIjfrA+EOOzThB7HojJuve6J5Y0+k?=
 =?us-ascii?Q?uWaCVChnTCdAifGQisLPBtoZ8fjDy+1gFiTeseWPPD7A2YbYD5ln14XzcJq0?=
 =?us-ascii?Q?PR2xMKRJDUdFENrKz+j4/MreN9/cBgPR8ZS/K6U90J7kF3M9WBbBbc9Brx4H?=
 =?us-ascii?Q?wV09YUr8u1bgAZJhrLEh47RKxccRB0R44iu+IWwwVEHQ6+rJRbRbxBk9wdN4?=
 =?us-ascii?Q?Z9odqUhqHQEzrxydqthm4G230T7Z/y6SymqJICc+DC+h1d5pGtoQIaLL8mWT?=
 =?us-ascii?Q?LNXTcitJyi7+RLPtcTedX/zkzF6nceW1/vuYs2slhwG404fHXY2/PbAZq1oj?=
 =?us-ascii?Q?cr/IaENxeM5dpIp3iC5T2AHjt2pAWMSoF6jvbOsJ1xkvhweiqNza02M+FUDC?=
 =?us-ascii?Q?+7ZRDFraYOvjkZYEv2UCmYI8z48QGcYqHHe9i0Mb3THA/z6mG+w3RUKSGfBd?=
 =?us-ascii?Q?n84AMGjLfpZsuCG124+YoeyU6MwQJ8yVKQSzBM1tETzXlYw9zhmG3ofST5xT?=
 =?us-ascii?Q?BCxkQBIf0D0GHsYy6Ql18LtU8lQUIOQPnR9Ns22YltgNqXDdKvq2utCuNh5S?=
 =?us-ascii?Q?eOOEbnTTC3PK7KcaKbSYlnc5JQMZvSaTp8KXSmmAAKL0hJrAfhJhYyVRFrkX?=
 =?us-ascii?Q?ZDOWumtRoy75yv0macrsbRVDdcoTLDkU+9KqDPfNNvk7S3hcFmeLzwklOaaT?=
 =?us-ascii?Q?vMVpWQlWENz2UJqnzJbFekswc5v7SUoJljrsX3QTjRnHXbRYa2P0xWFmJIkb?=
 =?us-ascii?Q?5hkYLgWhx4btvzbFVRkUe3mXswzU0M9HYa97wX4DK+0CKog125ZFeANDBmcj?=
 =?us-ascii?Q?vANL7UFkwd0/vfWyPcSzTnQ5wDlHkOBcdh8h5keSgA68wH8e3NNEFutWnfgS?=
 =?us-ascii?Q?1AsGoqNxWPkoia8zJzYTIUe6kGXikBoUIbIB+QOCUklmjUF20XnbVng4q/PM?=
 =?us-ascii?Q?2KfimcBlruQUn7e1wuwYf7n77Qeundof53R7cwd4hRPQRcIMLLUJeQnRr1Gt?=
 =?us-ascii?Q?+6YCz/Qw5Tdu3GoDbGgf2/+cNt9kgjKQyju+HeGfYz5fvxj/Kp5Ap8K+Q72R?=
 =?us-ascii?Q?KcBcgwAKqO1rI6iseDnL/gid8EMTw6P9ECLNojwGhcrjSnyB4/bRHNcxqCMT?=
 =?us-ascii?Q?intWGsLzCHNhsFQuszVoaZVF9E6mVqUxHTfNtM2I8ib/ysV8noLOLIrF3Yr9?=
 =?us-ascii?Q?5Dx2Rd7qNVdeHPLsHXwId97LUMHT+4JUD3afGqteEKo8IdS/llR1zVblcr1I?=
 =?us-ascii?Q?ahj4R9ueiXTRXNrV8XKT0Z4Pys8PhD26TxV6MFXNQ0pnVf+EnoLlUVYPQOa3?=
 =?us-ascii?Q?zHWqsbBlWEOgTB7k5/4e8lP1ZA/xdViQg7gtfQuDgvM94vsoNPZEAziNSrxw?=
 =?us-ascii?Q?nCNlgP1ghw7P59Dx+3eaNgk2ZrStRKfS32J85EmZ2bxB/psYonyB6DYXsWWi?=
 =?us-ascii?Q?7j5SH2C/DZ7fBTf+1E9QThu4noS4ZzqUpGPMhlEVR62HoCNeCv+us5KhJ0V3?=
 =?us-ascii?Q?iY2xPwkTcCb1IEFSl7+yxMiboi9CT7lH1ac2YrwVXVL3KDl6MnVFJUg3hBVr?=
 =?us-ascii?Q?DeBpuQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 26cc7868-b010-46fc-6977-08db666ceb25
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2023 09:03:39.2199
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ivYV1jnjasOgO/+FCQ2pnmw8iV9E6e7iFknJnQUwdRZDB2XwwLDDr4aSWHRccwriP7QXh2j+CtiAh/ePwHECEf+FgoSsIk5cDhHNn/zSWNI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR13MB3895
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Mon, Jun 05, 2023 at 10:34:07AM +0300, Paul Fertser wrote:
> On DBDC devices the first (internal) phy is only capable of using
> 2.4 GHz band, and the 5 GHz band is exposed via a separate phy object,
> so avoid the false advertising.

Hi Paul,

Can I clarify that the second object won't hit the logic change
below and thus be limited to 2GHz?

> Reported-by: Rani Hod <rani.hod@gmail.com>
> Closes: https://github.com/openwrt/openwrt/pull/12361
> Fixes: 7660a1bd0c22 ("mt76: mt7615: register ext_phy if DBDC is detected")
> Cc: stable@vger.kernel.org
> Signed-off-by: Paul Fertser <fercerpav@gmail.com>
> ---
>  drivers/net/wireless/mediatek/mt76/mt7615/eeprom.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/eeprom.c b/drivers/net/wireless/mediatek/mt76/mt7615/eeprom.c
> index 68e88224b8b1..ccedea7e8a50 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7615/eeprom.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7615/eeprom.c
> @@ -128,12 +128,12 @@ mt7615_eeprom_parse_hw_band_cap(struct mt7615_dev *dev)
>  	case MT_EE_5GHZ:
>  		dev->mphy.cap.has_5ghz = true;
>  		break;
> -	case MT_EE_2GHZ:
> -		dev->mphy.cap.has_2ghz = true;
> -		break;
>  	case MT_EE_DBDC:
>  		dev->dbdc_support = true;
>  		fallthrough;
> +	case MT_EE_2GHZ:
> +		dev->mphy.cap.has_2ghz = true;
> +		break;
>  	default:
>  		dev->mphy.cap.has_2ghz = true;
>  		dev->mphy.cap.has_5ghz = true;
> -- 
> 2.34.1
> 
>