Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Jun 2023 11:16:26 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Paul Fertser <fercerpav@gmail.com>
Cc:     linux-wireless@vger.kernel.org, Felix Fietkau <nbd@nbd.name>,
        Lorenzo Bianconi <lorenzo@kernel.org>,
        Ryder Lee <ryder.lee@mediatek.com>,
        Shayne Chen <shayne.chen@mediatek.com>,
        Sean Wang <sean.wang@mediatek.com>,
        Kalle Valo <kvalo@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, Rani Hod <rani.hod@gmail.com>,
        stable@vger.kernel.org
Subject: Re: [PATCH] mt76: mt7615: do not advertise 5 GHz on first phy of
 MT7615D (DBDC)
Message-ID: <ZH75apdT19WDrwS2@corigine.com>
References: <20230605073408.8699-1-fercerpav@gmail.com>
 <ZH72YwgpywPNxbd2@corigine.com>
 <ZH74kw4M15qjDbTz@home.paul.comp>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZH74kw4M15qjDbTz@home.paul.comp>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?S3xnnuW5GL0osBAqZNmyod4gQGv8AA9m3V8/MhWK5qPUublK1G9QFEqJ+9Ag?=
 =?us-ascii?Q?wBtWdTLj3oVBSBSdqoVVDyyZ4775huYMG1o8FLOKxIbXdZ+4JWg2QzYXKyb4?=
 =?us-ascii?Q?BBhLMtRC+90iC6t2FsDkPlmpHj0F/oM9Y9zwbLt34SFBoIdr6wytoatxYWPY?=
 =?us-ascii?Q?E9IOllte5ZHWa4V2lGSUQNR9vQkOcJ/I/PxK0w0tfR7EQjIwONpKf4f/sgKZ?=
 =?us-ascii?Q?Sg3Fn1ppkU3nBg4hAPgWjThwugHsq4rfqjUJlGm9RVaqLlW9GKpn8wmq/f/7?=
 =?us-ascii?Q?eKPMbDiDNbzQ9DCxXKH23Aknw7F15DrFe9gN6yV6VKNxUGNYvQsVlHDHmvnA?=
 =?us-ascii?Q?ZTSBtquHWHuS/vA4p1DhFov8SJyHXpO6Q8SsfcQJaoTOqiMY5l3e+6xY2cLQ?=
 =?us-ascii?Q?aAf0wd5+AlZngUEBYtwTkOamBGeqty6YYJBRFAyvAe2/FJVQjIdE251bU0vl?=
 =?us-ascii?Q?+u2s6cTo1s4W3fWHG8Jzk6vy1S5oAU7tnkNhWPjQ65W8xoZIP3eXWhSVPhgL?=
 =?us-ascii?Q?DW4By5IPGP9zc8ZXk1sPDXxcxkbBFbDazOQwVUuenFNrJyzWjVtG2bdKNShM?=
 =?us-ascii?Q?2vnX+/A9P365dFOCdIGZFCRXvsQJEKgLri0JzmXTBuwX8IyNsVTsRGHNS9Ht?=
 =?us-ascii?Q?ieffh3eSxW8EuQi3lljPROJuHPMsHzREB7aDFBM5OAqYlWiq0y+Rum9GadZv?=
 =?us-ascii?Q?mMIFUk0B61u9JrBO6TLxJ6+MHmE5vdOE3VXtD+Kmv6594mxf+AUQaMdkK73V?=
 =?us-ascii?Q?ykI9JRon0x8Qhh1Pyj3AJ2sibm7tv9cpnya/lbJatMXicazvauI+v4fxOYOv?=
 =?us-ascii?Q?ZAYjbs0ZwZHdmqMD3XJ1rBSXZ8CZ1cNOHtCK8edYI8goBiKztY84r7qzxUlR?=
 =?us-ascii?Q?49ekZMwrulcra5BRU0/39aP1xQh5gQLyHvMcCwHk/YL9gakmFVhDDT0rBMGH?=
 =?us-ascii?Q?PLDu7B8KqkcgVJ1bSOraBmj56w7bX/O9G0GNYI1OCQcxWkRuAiMcmrAdpztH?=
 =?us-ascii?Q?fEWglg0TeIsZ8l+5no8mG65cQxS/ps/8iWruesLn+JHx6Nf8/bR10nYr3rVY?=
 =?us-ascii?Q?w16WGLEOBpahbe/rgFWguSsaXT9E+8WiSNvQ3tK9t7tMvmce2ZQOt/7trTRe?=
 =?us-ascii?Q?mys1hcQfaVtG0wrHMbtI0cAvippyivldCdI9LYFQI/5aeg8lPa1iwm0v9TxA?=
 =?us-ascii?Q?ZuL1Txvm2FFWMZTc8kT3iV4JDpyAgWk2LSNP6hjJWM49PN5WVPe7V3G65qM9?=
 =?us-ascii?Q?jTOPhXdOCpueeRBTis8DqNg5pjcrZyGcsRbKt2cHoMTUzpHBtiWejTr9PFW8?=
 =?us-ascii?Q?OqzT1L2GvhaGV5Gy2M0jY0ndeOMY0tRnva+85af7kZNAGY6WnHoNnwBcknoh?=
 =?us-ascii?Q?iTaJ5V+lpL4ydTv2vZRZr2aSrAac8Xuxc/j0QCUzoiDk14OdGWv6fdNt8OcP?=
 =?us-ascii?Q?ENTuxVmedZFd3+QwxD9Uoovxovek5og8orjV8+2TQr2T+jjleivc7g0EZppC?=
 =?us-ascii?Q?jLR1Kuy9yw+UQhN91SOSFH7hwYZMaZUyw5ykSrUcZVhw1zDNRFHMmdSgHCHE?=
 =?us-ascii?Q?ilpqkEhp+g6Fncz82wlJEHzPGswgc/RtutPJiV6uDQLxeH+q77vmssEgRpLW?=
 =?us-ascii?Q?3yBixuj6LDqu8oxZFovpOSf5f+R6LV9MFwy3SxrAABTOwprxN1615k4FVA9v?=
 =?us-ascii?Q?u5uuiw=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ed23e329-6d84-4001-06c0-08db666eb939
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2023 09:16:34.4050
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6cAaxU2xVsu2rcQlu9/lx7Wb4ImZWiqd8HiFcMUHD/4Vic2eNir1CoqJYQEWVfzk6gYcJl3U9FPYZx84gjPGDpNED1JJ9HKGQpSxwUNa2PI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR13MB6397
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Tue, Jun 06, 2023 at 12:12:51PM +0300, Paul Fertser wrote:
> Hi Simon,
> 
> On Tue, Jun 06, 2023 at 11:03:31AM +0200, Simon Horman wrote:
> > On Mon, Jun 05, 2023 at 10:34:07AM +0300, Paul Fertser wrote:
> > > On DBDC devices the first (internal) phy is only capable of using
> > > 2.4 GHz band, and the 5 GHz band is exposed via a separate phy object,
> > > so avoid the false advertising.
> > 
> > Can I clarify that the second object won't hit the logic change
> > below and thus be limited to 2GHz?
> 
> The second object (external 5 GHz phy) doesn't have an EEPROM of its
> own, and is created explicitly with just this band enabled:
> 
> https://elixir.bootlin.com/linux/latest/source/drivers/net/wireless/mediatek/mt76/mt7615/pci_init.c#L104
> https://elixir.bootlin.com/linux/latest/source/drivers/net/wireless/mediatek/mt76/mt7615/init.c#L573
> 
> So it won't hit the logic change and it will be limited to 5 GHz.

Thanks Paul,

in that case this patch looks good to me.

Reviewed-by: Simon Horman <simon.horman@corigine.com>