Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp492525rwd; Thu, 8 Jun 2023 03:52:41 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4jTzJ+vK0q4173RX1XRRQoB9t/lg0gJffvyqptQqSefMZ+rvkkoERDyuLzeuxd6PwKL+DW X-Received: by 2002:a92:d48b:0:b0:32f:80a1:2e44 with SMTP id p11-20020a92d48b000000b0032f80a12e44mr10264121ilg.9.1686221560991; Thu, 08 Jun 2023 03:52:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686221560; cv=none; d=google.com; s=arc-20160816; b=VoyzCraaOXtqfZUJrea6meGDx9ObIv2Xb18xL3EzgRsWXQQaPIps18Wmpf8G06BoxZ WrppZx2GZ2rRgBdsBvzk7LK3RJwXv8J78cYrruhLfwUm6rOv1TFvgMG1QASd9BTHYBcj ICbVjHxRYxb3vfV0r8KnZ1snWqe7j9JZOEnf0Z+r0uE1ci6aPHzSQxj1nDvMO7ihOnG+ fXZaUG6FfQDB2n0UshXN7M7Hlhq0+TI4tCPoSDhT5pWWFWCyd5EGQghm51WFTy2MG/SI 5Msm9lfurLxx21noW8v1SnPGSWjMJw+AKR2eb8nymKG8hW8W3D/azlAziU1ccUtzcQ2K BMog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=sXR/KTOVzWTPEE33qcIo/B5p7AYPQ5VgOxwa6AMawWo=; b=KD2h0OUdMa/bG0GBOIBEZfFBInnxx0R6573MWul598yDKYHAgDdeJ4S4h0RInJ2dc5 VPV+LA9eK7Jjjdz8pLhN/TYXPqu2dSS9McoK2rJbOmZkTLh9esIZuvWUOqKoW+BXqP6s b/2vdZ17hwgpn4LG4t5Sq/aKfRXkG31wSDsCfXFAOX2F0ucWVfhJaTEFFhxTNfnrtg8V YBVAJYRKzc0kWwJiUlgDYC88prhFOcbZr3z94XevwHgW+Kmapjr96GLa0JT3a8Iuegnb wLg/F717qMtqxN+OGXKXyRkGBO9C2IOdT6aop6AsNYaclLAQHbdaieLmFZsqzWQc4Wyt SesA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=cwhFFbEN; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a192-20020a6390c9000000b005362a6e5395si875270pge.229.2023.06.08.03.52.28; Thu, 08 Jun 2023 03:52:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=cwhFFbEN; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235662AbjFHKpO (ORCPT + 61 others); Thu, 8 Jun 2023 06:45:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236168AbjFHKpI (ORCPT ); Thu, 8 Jun 2023 06:45:08 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83D162710 for ; Thu, 8 Jun 2023 03:45:07 -0700 (PDT) Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 358AVfvC010297; Thu, 8 Jun 2023 10:45:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=qcppdkim1; bh=sXR/KTOVzWTPEE33qcIo/B5p7AYPQ5VgOxwa6AMawWo=; b=cwhFFbEN4sYVLLLa5Im5UYMY1IoCFGfIZwl48gNyOBH0NpHSdHHjzTenbrj6cVyydsRi +NPvNltvqx0fZvC7ZG0plC2jvjlUOwM1PSaOmSoxPP+20cwkAA/Ic/lPhPsRVLzrNAue 8Wra7K3kCBHU6Cm2WDWZ7aNuNy3IlALru0an/krujqij9Q9LuNTy76A7qH+Sdp8/IJTt 4Oyxep07NL3bGXt5NBLtj6xVsdeeRSbte7ZeNOpf0FdQo6byjvsBFpvtv4lDAuuY3piQ mjkowiRIN4IdKB6Rs0fABeSRagijgl2h852+YuDpBgIVAwAUnLd5gJPcMKjDM0LqFlha Ng== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3r38rbrk2k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 08 Jun 2023 10:45:00 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 358AixY9010195 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 8 Jun 2023 10:44:59 GMT Received: from wgong-HP3-Z230-SFF-Workstation.qca.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Thu, 8 Jun 2023 03:44:58 -0700 From: Wen Gong To: CC: , Subject: [PATCH] wifi: ath12k: fix conf_mutex in ath12k_mac_op_unassign_vif_chanctx() Date: Thu, 8 Jun 2023 06:44:44 -0400 Message-ID: <20230608104444.3134-1-quic_wgong@quicinc.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: K0U76srNi_rSLr4Xr_4MTTho5NsvIoJ2 X-Proofpoint-ORIG-GUID: K0U76srNi_rSLr4Xr_4MTTho5NsvIoJ2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-06-08_07,2023-06-08_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 mlxscore=0 clxscore=1011 mlxlogscore=795 priorityscore=1501 lowpriorityscore=0 spamscore=0 bulkscore=0 impostorscore=0 adultscore=0 phishscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306080091 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org "mutex_unlock(&ar->conf_mutex);" is always called at end of function ath12k_mac_op_unassign_vif_chanctx(), so delete this unlock to make sure lock/unlock is paired. Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0-03427-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.15378.4 Signed-off-by: Wen Gong --- drivers/net/wireless/ath/ath12k/mac.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath12k/mac.c b/drivers/net/wireless/ath/ath12k/mac.c index ee792822b411..e65f5337d8f5 100644 --- a/drivers/net/wireless/ath/ath12k/mac.c +++ b/drivers/net/wireless/ath/ath12k/mac.c @@ -5910,7 +5910,6 @@ ath12k_mac_op_unassign_vif_chanctx(struct ieee80211_hw *hw, } arvif->is_started = false; - mutex_unlock(&ar->conf_mutex); } ret = ath12k_mac_vdev_stop(arvif); base-commit: 0a00db612b6df1fad80485e3642529d1f28ea084 -- 2.40.1