Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp903605rwd; Thu, 8 Jun 2023 09:12:54 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5vjtvwI/uKDjp+PK/sUHxZ4gkVtX3FJfb1WBjQb60xyQsDd60DcA0TxK+tcbiFWDnDDjvH X-Received: by 2002:a05:6a00:a10:b0:636:f5f4:5308 with SMTP id p16-20020a056a000a1000b00636f5f45308mr11545679pfh.7.1686240774391; Thu, 08 Jun 2023 09:12:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686240774; cv=none; d=google.com; s=arc-20160816; b=D55wWHEPiuPaxBsUwCahUztUobmf81F4tSxjdVNevA6IUnRULc9KyYHFeaZCmOmESB OTZEnMWTyZkfS/hXJ8dtMLKtsNUu24d+G3xxnhdQGhsmhgGUxDNd7wgMvb4BAzgVOYh3 aElGNcd/NPGjRkUegg1ywbrj8HQKyVpWkKzmV2yhbOOABw/T3XbRsHhTiKqBkct27zCV xFzN3xlyRZHnrHxrkyEJ/0i28kpDJgMqSuyhuJ860i4cusYcvQ1ODZGf/sXtLpal2ysD 0s4n7PH4IfQzaTkQdp96cBIR1q+0oYSWIpDi/cGOBKJ2vqyQju9iV7jR6vI4oq9C0hu0 ze0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=C1MrUTzOvTjnYOBXWRVisrsu2ZAPm7LkIwYSrpHI/AA=; b=iLLKqBr3fcro59C0ZE3Gn3mnsjWObD1isnbKc4bpmREWmZd8Uf+oanWBj7I03mVniX 8QPrZ//TEkGWirxiZJ3zwdb++J9e4mvsx+GyFlS5yLS8QvwEy+QPsLsxATSb3GHleG/p WeIN575DBhHqHpJuziZah0++e4KB9qBnFYwMTxnkyP5LxRD0qtRnfn7owa1zUVxaGDzg f2AlQ2YON8NxQsaoY/8s/u8fwzZ3lPJBtGLh8Sk5WM/KbVtLGKolqS5oUTO95gCkJiGR OIJLGvXtjYQGPhA+M6KBFlg6ZrrV9WcYiXPqrlrwpmFsvUDgQPv1/7Ax8D3aoKlLQwyU 45yg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cv4XJmPu; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p29-20020aa79e9d000000b006636be3bc45si324737pfq.120.2023.06.08.09.12.43; Thu, 08 Jun 2023 09:12:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cv4XJmPu; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229775AbjFHQCx (ORCPT + 61 others); Thu, 8 Jun 2023 12:02:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231963AbjFHQC1 (ORCPT ); Thu, 8 Jun 2023 12:02:27 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12F701702 for ; Thu, 8 Jun 2023 09:02:26 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8C52564814 for ; Thu, 8 Jun 2023 16:02:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1744BC433D2; Thu, 8 Jun 2023 16:02:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686240145; bh=3wFt8CGVTKC+TV3zZFmR8UtSu/tv1yh19COQfQNVFV4=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=cv4XJmPuQhkV96OOPDNq0lLupc7lCsqeokuA03XXvMGRry4tK26h71egDKttjmlnL DwMaDWPJV/j7vzhRobwpIdZoNkRGJSyuJbyxE2mhAYGWbITyJwaPSCE6wU5E4fNnXz Nw0DOhHHAD+hOw6rzL3BtXn+VzlSGfQYay923C8EbCOWpIkHlCviuPpbDbQcGKwro3 Q2juei7vt2k8ERpdiDLbSAoSA9Y8mLw8pAuiSUse37u3XeBD8E+IPO0hRj/1GdkxoM xvOV9mUyFjO5aECHAK0HAYz9tvX7B8Kv5JIX5GThzyPdkbT/YrjW3k60Bi4CuqorrU UvwSHk7DprqNA== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: rsi: Do not set MMC_PM_KEEP_POWER in shutdown From: Kalle Valo In-Reply-To: <20230527222859.273768-1-marex@denx.de> References: <20230527222859.273768-1-marex@denx.de> To: Marek Vasut Cc: linux-wireless@vger.kernel.org, Marek Vasut , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Jilin Yuan , Paolo Abeni , netdev@vger.kernel.org User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <168624014117.5828.4271353370998823332.kvalo@kernel.org> Date: Thu, 8 Jun 2023 16:02:22 +0000 (UTC) X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Marek Vasut wrote: > It makes no sense to set MMC_PM_KEEP_POWER in shutdown. The flag > indicates to the MMC subsystem to keep the slot powered on during > suspend, but in shutdown the slot should actually be powered off. > Drop this call. > > Fixes: 063848c3e155 ("rsi: sdio: Add WOWLAN support for S5 shutdown state") > Signed-off-by: Marek Vasut > Reviewed-by: Simon Horman Patch applied to wireless-next.git, thanks. e74f562328b0 wifi: rsi: Do not set MMC_PM_KEEP_POWER in shutdown -- https://patchwork.kernel.org/project/linux-wireless/patch/20230527222859.273768-1-marex@denx.de/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches