Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp2009701rwd; Fri, 9 Jun 2023 05:34:43 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4GnlZgY8wOeJ7qVpxA/7YRx7Xtb5qybmyYuy8jAfaHFraIQZ5HkzOgnhFZ+kBYlZXjxygO X-Received: by 2002:a05:6a21:329b:b0:110:2064:ecb with SMTP id yt27-20020a056a21329b00b0011020640ecbmr5957422pzb.15.1686314083159; Fri, 09 Jun 2023 05:34:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686314083; cv=none; d=google.com; s=arc-20160816; b=Mc31S0okyuQYEW3K0i9gyRV6ue/Y/+9P6yHBdFKXlO9W/MJVAVv7U/Li/Hrsv1XFgJ fEjYa9qs/fTPVxWzJNKUw2t/OzTPkw/2u1KszEfbVYkIR6CPv862f2IRPCf8/kgsIU7N uOvqAjAHllJNkE5B/l6+hCCY2PzBncFnepAptcvWYVFzEFnCd0Uo3dTd85NQzq12RKrW oP+F/G/o/5sSdA8sfM9YnKBcaLCHT747jUioC1KAEPm3tRt5CR81wV2mHkcukKAPbfLn VPmBj47SH7/1kMbfoOIM1ldgn/ihizHbrbMNT2tXAxb1qGqjLhEgazk2aLzwwAbMHzHO 7dXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=7HcsDgPu2MYSvpNp5qaPtuhK+BLJDkPZljoZuRsxMHM=; b=YJxwHqle4lR5Fe4VTc2MKapuOb7ojiGN5KTUI1EbthiKBhx2MwfyCJ5pbNv3hb5EIk h6foxV7nNzERXh8iRUGpIdVNXUkyWNoIp8o81USb6dtGhQ4V0aIvobxTGOdkuEyNka10 5upYx7hd3Msd0vhfTkbinNEaUt51iY6GworhyQj/6+js4Yqg4Wye4U5TSXFDYWauFgdS /qyiC6Jc2TADUhU7PVA6poN1At8GhJda+Gbkv81jtfa6/pfpebSxxdNtL9lRsluK1OTj 1wt8RTe4XmfepPgmlvj3z2k/lVXfR3GM4TthI/HSb+k3AmPIt9101XlbLHPlrisGWwyb bXNQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FL6vxUbs; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id az9-20020a056a02004900b0050b8a7635dfsi2598290pgb.295.2023.06.09.05.34.35; Fri, 09 Jun 2023 05:34:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FL6vxUbs; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236215AbjFIMae (ORCPT + 61 others); Fri, 9 Jun 2023 08:30:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241247AbjFIMaR (ORCPT ); Fri, 9 Jun 2023 08:30:17 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5055D3AA4 for ; Fri, 9 Jun 2023 05:29:41 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6174C65713 for ; Fri, 9 Jun 2023 12:28:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2611C433EF; Fri, 9 Jun 2023 12:28:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686313695; bh=xmQbsGpjE1ohlx+uMchWdzhzKFcj0m+A3jS6YKTfnMc=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=FL6vxUbsONT2hmbK18cIHVPbawKYk8VAgSBj7WFBSxWl84GGO7zXCfzioco6I1PZJ MN/Z6rw9uCQXfMbp1nk7tfPcNnZalT0T6gChLEBvoUlSJYyavNR6wGHxYXnuARdVit AoMqqTiNPeI1MVVqEdP3a6VW6h/TT2lYUjp9MnHwoeJYAF+0NmOlBwSAz0NE6z827c pK7zCS6feJV+Q4YfAtvrbXXTa+XfO98X7EdtRWZfcQpliA46HtsM4t5Gt8eh+xXFtj T0m7H+YgSqvAUt3opAf31cVx8jyPV0GIlCjjxvMAJhbPo3lbLDZJMNGYD4VwWTHPoL PtmdyD9WbIHaQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net-next 1/4] ath10k: Drop cleaning of driver data from probe error path and remove From: Kalle Valo In-Reply-To: <20230601082556.2738446-2-u.kleine-koenig@pengutronix.de> References: <20230601082556.2738446-2-u.kleine-koenig@pengutronix.de> To: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, kernel@pengutronix.de User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <168631369188.10496.13768584046079083634.kvalo@kernel.org> Date: Fri, 9 Jun 2023 12:28:13 +0000 (UTC) X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Uwe Kleine-König wrote: > The driver core cares for resetting driver data if probe fails and after > remove. So drop the explicit and duplicate cleanup in the driver's > functions. > > Signed-off-by: Uwe Kleine-König > Signed-off-by: Kalle Valo 4 patches applied to ath-next branch of ath.git, thanks. ec3b1ce2ca34 wifi: ath10k: Drop cleaning of driver data from probe error path and remove fad5ac80dfa5 wifi: ath10k: Drop checks that are always false d457bff27633 wifi: ath10k: Convert to platform remove callback returning void 6358b1037157 wifi: atk10k: Don't opencode ath10k_pci_priv() in ath10k_ahb_priv() -- https://patchwork.kernel.org/project/linux-wireless/patch/20230601082556.2738446-2-u.kleine-koenig@pengutronix.de/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches