Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp2092229rwd; Fri, 9 Jun 2023 06:37:55 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4fnIi6Au9Yh9Lhtqm37rRhNwknFBDCpVZAcDF1mB0MzCV6m2jq19F/jf3RzCuA83emufDH X-Received: by 2002:a05:6358:e9d:b0:129:b903:9304 with SMTP id 29-20020a0563580e9d00b00129b9039304mr1201333rwg.26.1686317875483; Fri, 09 Jun 2023 06:37:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686317875; cv=none; d=google.com; s=arc-20160816; b=BjVuhX/Zbcx+rpqCa5kMaF39AWHCaPTzrUDSnKzouiIf1y5Eif+DiN6DWVMaoVa8WY Edqf3mDj3d7WX20L5Bs09LEsRJeeUqfJZpOXvPWjQZBnFeqpTjweQ/kSe2lha2xMDZqN qsgSNKXXDd7DU/9pNAkcKJ9R1r+vxIxyjHNALoAqy6sfYGC2Ba6kEiMZLwPI1wswX9hk J3cqwEgQG+4vROR6RmuHBEo17QUiK9W+qpLdxdTsxQEyMQUob3vTJnODCd4LZh2W0scC 0lRQtxV9ctQx+efSZZcyMlAFaZLke1srdlVnoUN3ipaD0abPyahSGflsdE2eJ9T9FZEx caCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=kK7WHypbo8GMRfjqLdNRXHbYQKGZ9KP3Dl5aZv/9eUY=; b=bcHDq6JdfmJQHKjSbH740Q2lSgaMAICdkt6sRJTx423MJCwMCBvh1t6689kiqFb8OI J3nogrTDBDd/hYqqKgg8/dnAAPgZV5XWkV195wDhq3ZP8CaQ9RC4Ekphe1PyBp4Bc/65 F85Le6qyg1zj+54hXywWAQ/zlNn3R7b3Gt7pWVe7WARIQU1K5X+qT+k6mH87Ihd5iW2N VjgYw+3lPw19vXRo+Dxv/9KX11aNUncy/p/oc7cz325Wj7Z2b/EDHguqFIYS0ar9C1HP dd7s8oVKONLdMSBwo5Ci2+S8IYoXbTWa3tyo906WMewzT4FRevmgbV4yxb1ridzPTDoO acUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dRtqaGI9; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y185-20020a638ac2000000b0053fa2f589aesi2511986pgd.884.2023.06.09.06.37.46; Fri, 09 Jun 2023 06:37:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dRtqaGI9; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236166AbjFINdQ (ORCPT + 61 others); Fri, 9 Jun 2023 09:33:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233272AbjFINdP (ORCPT ); Fri, 9 Jun 2023 09:33:15 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17EB42D48 for ; Fri, 9 Jun 2023 06:33:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A941865674 for ; Fri, 9 Jun 2023 13:33:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F1CB9C433EF; Fri, 9 Jun 2023 13:33:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686317594; bh=7BwFbeazrEVoJL4FmncCiczT3/uCanGLr7VBtUGZT1Y=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=dRtqaGI9SFaRhiwDihIPHXVkljRYdS4Ar+76dpUAejON5DOIgCHZDk38PWkBehEwg ++XEeO3J8ue/Tog6CiIrvngZv912JqPStruqF1C3JD3RQftV3/SQP1dU+OsxcAio8y XXeQklV9B7yERGR6rdSoKtz3iksnPOzejqCqxTIeXNCVxtm6QORmY0BtBRWboGnvbK q/sxosiGmNft2u22bkpaR89932ux9uZMw3Dr03U9zipV7JE3ZljZ3klTpSB6Z5cnRT hnRcw25lAkfso++29pnZpP5c1idLEMnxrnRBAKDYQLL34qlQxexqhzCF8J7A8FeduI hVHnBOwBe8mhw== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: ath12k: delete the timer rx_replenish_retry during rmmod From: Kalle Valo In-Reply-To: <1685355238-3282-1-git-send-email-quic_haric@quicinc.com> References: <1685355238-3282-1-git-send-email-quic_haric@quicinc.com> To: Hari Chandrakanthan Cc: , , , Hari Chandrakanthan User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <168631759075.7235.15045413984427960673.kvalo@kernel.org> Date: Fri, 9 Jun 2023 13:33:12 +0000 (UTC) X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Hari Chandrakanthan wrote: > The rx_replenish_retry timer is initialized in ath12k_core_alloc() when ath12k > module is loaded. But rx_replenish_retry timer is not deleted anywhere in the > code. It is supposed to be deleted when ath12k module is removed/unloaded. > > Delete the timer rx_replenish_retry in ath12k_core_free(). > > Found during code review. > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0-02903-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Hari Chandrakanthan > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. e2d1f005d3fb wifi: ath12k: delete the timer rx_replenish_retry during rmmod -- https://patchwork.kernel.org/project/linux-wireless/patch/1685355238-3282-1-git-send-email-quic_haric@quicinc.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches