Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp2099971rwd; Fri, 9 Jun 2023 06:44:30 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5NBfBAa/37xnU/JEzHnGLerZV8WM6bPBMUIV2SOigzh4n1TJ+NilcSb1bSdOTKpKdmD81Q X-Received: by 2002:a05:6358:9f94:b0:129:c564:63e0 with SMTP id fy20-20020a0563589f9400b00129c56463e0mr1112035rwb.23.1686318270008; Fri, 09 Jun 2023 06:44:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686318269; cv=none; d=google.com; s=arc-20160816; b=pqUbvpafKG0isPVwhHVobF9nzBrayTHlLQy5hDEOIZSnqRs5wRcOWn81Z93ZnbBz6S irMOignh6kH0rk16ATFF1aIaMkHs7jT0YAty1EOTiuSxY9x00vydV02/0b6ROSkTrX4S MdJ9y/X4+FKnSUmlZPKtDYhlxV4Rp5I6z+WGIab8/2pLgdeCD5voaRn9oiTrD7mArNSV bKPt87/isF+yIh1/1wOZED4f0GbfR94/8rnvu4na07LtS5qXThDRrHyw1+0gNK4eec4o 2d4o1V+C6dw3/YXRAoacC4g8kPlSeDL0yic7Er4UE7ltvZ8L+fjZ0I5XhEhJVZcO0l+9 kSdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=Sj6LyBA4HMzZfn2fHD8dm1ywn0V+FzYcn+vwd4D4OvE=; b=e9Q5FcaElygHX3L7zGYm+GIZXjnNBiEBnASAJKyvcjnUCyI0qsGsz6z2e6LEBX0qTr jADQY/Uu4Z81lmB/6TmIcpeKQSE5uDIbNbYf9Dr1DBVs/Zq9tVtEs3Q5QJhEIZ7UTEMO na6sCmYEx0dT3JsxjdBIzM1iHC3807zSm+IRnw+VS03OrGJ+ZZdt+dOZOflmt6ISZKsS eXWfvVxneudxcy8O0p/KI0wVGCivLaj4EtdnLOVmGamKk8Il89Au5PTRfu5sQqWU1hJw 8W/E30AiwJ9a0D97+SErOJw5Bo93Q494xnLnWx/9MUNl/gwa+Kc7xnnscBS0HiSejKyO GdaQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Agdjl8Fd; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v5-20020a637a05000000b0050309caf60esi2645254pgc.750.2023.06.09.06.44.20; Fri, 09 Jun 2023 06:44:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Agdjl8Fd; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239546AbjFINcE (ORCPT + 61 others); Fri, 9 Jun 2023 09:32:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232403AbjFINcE (ORCPT ); Fri, 9 Jun 2023 09:32:04 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B232A3 for ; Fri, 9 Jun 2023 06:32:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D6EB4657A4 for ; Fri, 9 Jun 2023 13:32:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 528E9C433D2; Fri, 9 Jun 2023 13:32:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686317522; bh=Rw3dAMIdjdiaMCdDJYrhk/RgPHgoQhkwsP1VueIBGOg=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=Agdjl8FdSMrhueNuwn7Cch6xWahUS1ArVpQRVWQUhRa0UQFV1HJ7NBhZUGiAO3/pp gJlh421wysxOQiRXMsBrXrtJluqcrX2l5/iQmkMYNPuB0ebs98428bkEaeelojJ4vm gITf6unjME5FOfSnAO3AuoJQqsZkI1oNQaYRJIzq5+tO9AstfDkcqqusaabV3ceii4 gXRT45rTkZGQsVwniZhN6fqrBBwkJtDv76JHN6CMBjuAJmsE332gXil5hq1v5sMFbv TKapFjCil8f0di8toqMk9u2bqsZC0ouZgGBEocPTJ4KwpxgbfnJOBWR5v9bMhKRAu6 eboGFz0wKr40A== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: ath12k: Avoid NULL pointer access during management transmit cleanup From: Kalle Valo In-Reply-To: <20230518071046.14337-1-quic_bselvara@quicinc.com> References: <20230518071046.14337-1-quic_bselvara@quicinc.com> To: Balamurugan S Cc: , , Balamurugan S User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <168631751914.7235.13826635338122633209.kvalo@kernel.org> Date: Fri, 9 Jun 2023 13:32:01 +0000 (UTC) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Balamurugan S wrote: > Currently 'ar' reference is not added in skb_cb. > Though this is generally not used during transmit completion > callbacks, on interface removal the remaining idr cleanup callback > uses the ar pointer from skb_cb from management txmgmt_idr. Hence fill them > during transmit call for proper usage to avoid NULL pointer dereference. > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Balamurugan S > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 054b5580a36e wifi: ath12k: Avoid NULL pointer access during management transmit cleanup -- https://patchwork.kernel.org/project/linux-wireless/patch/20230518071046.14337-1-quic_bselvara@quicinc.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches