Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <cca9caf4-df21-eff5-ed21-562535163451@denx.de>
Date:   Sat, 10 Jun 2023 14:32:41 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v3] MAINTAINERS: Add new maintainers to Redpine driver
Content-Language: en-US
To:     Angus Ainslie <angus@akkea.ca>,
        =?UTF-8?B?SsOpcsO0bWUgUG91aWxsZXI=?= <jerome.pouiller@silabs.com>
Cc:     Kalle Valo <kvalo@kernel.org>,
        Ganapathi Kondraju <ganapathi.kondraju@silabs.com>,
        linux-wireless@vger.kernel.org,
        Amitkumar Karwar <amitkarwar@gmail.com>,
        Amol Hanwate <amol.hanwate@silabs.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Johannes Berg <johannes@sipsolutions.net>,
        Martin Fuzzey <martin.fuzzey@flowbird.group>,
        Martin Kepplinger <martink@posteo.de>,
        Narasimha Anumolu <narasimha.anumolu@silabs.com>,
        Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>,
        Shivanadam Gude <shivanadam.gude@silabs.com>,
        Siva Rebbagondla <siva8118@gmail.com>,
        Srinivas Chappidi <srinivas.chappidi@silabs.com>,
        netdev@vger.kernel.org
References: <1675433281-6132-1-git-send-email-ganapathi.kondraju@silabs.com>
 <112376890.nniJfEyVGO@pc-42> <dd9a86af-e41a-3450-5e52-6473561a3e18@denx.de>
 <3166282.5fSG56mABF@pc-42> <50ab38c7104b99277bca512ba8f59255@akkea.ca>
From:   Marek Vasut <marex@denx.de>
In-Reply-To: <50ab38c7104b99277bca512ba8f59255@akkea.ca>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 6/9/23 17:46, Angus Ainslie wrote:
> Hi Jérôme,
> 
> On 2023-06-09 08:10, Jérôme Pouiller wrote:
>>
>> You are talking about this driver[1] I assume?
>>
>> [1]: https://github.com/SiliconLabs/RS911X-nLink-OSD
>>
>> [...]
>>> In the meantime, since RSI neglected this driver for years, what would
>>> be the suggestion for people who are stuck with the RSI WiFi hardware?
>>
>> Unfortunately, my only suggestion is to use the downstream driver we
>> mentioned above.
> 
> That driver isn't really a solution as it rarely applies cleanly to 
> recent kernels.
> 
> The lack of proper commit messages also makes the changes opaque.

Worse, that repo is just massive dump of unreviewed, unreviewable, 
obfuscated goo. That is something I would never dare to put into any 
serious deployment.

To make it clear, the aforementioned suggestion is NOT an option.