Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authenticated-By: 
From:   Ping-Ke Shih <pkshih@realtek.com>
To:     Kevin Lo <kevlo@kevlo.org>
CC:     "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH] wifi: rtw89: use the correct bit in the R_AX_PLE_INI_STATUS register
Thread-Topic: [PATCH] wifi: rtw89: use the correct bit in the
 R_AX_PLE_INI_STATUS register
Thread-Index: AQHZmqVjsIXsIWMjREWpyKsynom8xq+GVpMg
Date:   Mon, 12 Jun 2023 00:38:41 +0000
Message-ID: <b630340d34224c2a8d66ccb344f060ad@realtek.com>
References: <ZILW8Uct7yUjsVyh@ns.kevlo.org>
In-Reply-To: <ZILW8Uct7yUjsVyh@ns.kevlo.org>
Accept-Language: en-US, zh-TW
Content-Language: zh-TW
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Precedence: bulk


> -----Original Message-----
> From: Kevin Lo <kevlo@kevlo.org>
> Sent: Friday, June 9, 2023 3:38 PM
> To: Ping-Ke Shih <pkshih@realtek.com>
> Cc: linux-wireless@vger.kernel.org
> Subject: [PATCH] wifi: rtw89: use the correct bit in the R_AX_PLE_INI_STATUS register
> 
> Use the PLE_MGN_INI_RDY bit rather than WDE_MGN_INI_RDY to check if
> PLE cfg ready runs into a timeout.
> 
> Signed-off-by: Kevin Lo <kevlo@kevlo.org>

Acked-by: Ping-Ke Shih <pkshih@realtek.com>

> ---
> diff --git a/drivers/net/wireless/realtek/rtw89/mac.c b/drivers/net/wireless/realtek/rtw89/mac.c
> index 512de491a064..4e0cec7c59a2 100644
> --- a/drivers/net/wireless/realtek/rtw89/mac.c
> +++ b/drivers/net/wireless/realtek/rtw89/mac.c
> @@ -1814,7 +1814,7 @@ static int dle_init(struct rtw89_dev *rtwdev, enum rtw89_qta_mode mode,
>         }
> 
>         ret = read_poll_timeout(rtw89_read32, ini,
> -                               (ini & WDE_MGN_INI_RDY) == WDE_MGN_INI_RDY, 1,
> +                               (ini & PLE_MGN_INI_RDY) == PLE_MGN_INI_RDY, 1,

Luckily, definitions of WDE_MGN_INI_RDY and PLE_MGN_INI_RDY are the same, so
I don't really need to verify it.

>                                 2000, false, rtwdev, R_AX_PLE_INI_STATUS);
>         if (ret) {
>                 rtw89_err(rtwdev, "[ERR]PLE cfg ready\n");
> 
> 
> ------Please consider the environment before printing this e-mail.