Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
Date:   Mon, 12 Jun 2023 20:23:26 +0200
From:   =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= <rafal@milecki.pl>
To:     Christian Lamparter <chunkeey@gmail.com>
Cc:     devicetree@vger.kernel.org, linux-wireless@vger.kernel.org,
        bcm-kernel-feedback-list@broadcom.com, kvalo@kernel.org,
        f.fainelli@gmail.com, conor+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org
Subject: Re: [PATCH v1] dt-bindings: net: wireless: bcm4329-fmac: add
 ieee80211-freq-limit property
In-Reply-To: <288fc9a0db6c292bc132e828611c41785b075078.1686486461.git.chunkeey@gmail.com>
References: <288fc9a0db6c292bc132e828611c41785b075078.1686486461.git.chunkeey@gmail.com>
User-Agent: Roundcube Webmail/1.4.13
Message-ID: <f19c93cc90d6fa92e7e0430a12ec838b@milecki.pl>
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2023-06-11 14:37, Christian Lamparter wrote:
> This is an existing optional property that ieee80211.yaml/cfg80211
> provides. It's useful to further restrict supported frequencies
> for a specified device through device-tree.
> 
> The driver supported this since ~2017 by
> commit 0f83ff697356 ("brcmfmac: use wiphy_read_of_freq_limits to
> respect limits from DT")
> 
> This property is already being used by:
> arch/arm/dts/bcm4709-netgear-r8000.dts
> 
> Signed-off-by: Christian Lamparter <chunkeey@gmail.com>

I've already submitted patch for that:
https://patchwork.kernel.org/project/linux-wireless/patch/20230602135925.14143-2-zajec5@gmail.com/

This patch isn't needed anymore.


> ---
>  .../devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml  | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git
> a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
> b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
> index fec1cc9b9a08..44e5f6677289 100644
> --- 
> a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
> +++ 
> b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
> @@ -15,6 +15,9 @@ description:
>    These chips also have a Bluetooth portion described in a separate
>    binding.
> 
> +allOf:
> +  - $ref: ieee80211.yaml#

FWIW:
This isn't enough without changing additionalProperties to 
unevaluatedProperties.


>  properties:
>    compatible:
>      oneOf:
> @@ -63,6 +66,8 @@ properties:
>      description: Name for the OOB IRQ, this must be set to 
> "host-wake".
>      const: host-wake
> 
> +  ieee80211-freq-limit: true

FWIW:
You don't need it here with allOf.


>    brcm,drive-strength:
>      $ref: /schemas/types.yaml#/definitions/uint32
>      description: Drive strength used for the SDIO pins on the device 
> in mA.