Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp887491rwd; Tue, 13 Jun 2023 01:32:58 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7Nz74K7MI8yRU5mBCpOVhRCZ4IrSHgBvQ8lyb7cPP7xNdQYWlj0wE/xodhnhgDF8SVI7JU X-Received: by 2002:a17:90b:1e4b:b0:259:bf40:b571 with SMTP id pi11-20020a17090b1e4b00b00259bf40b571mr10924799pjb.45.1686645177975; Tue, 13 Jun 2023 01:32:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686645177; cv=none; d=google.com; s=arc-20160816; b=GITGHgSjKgBpBWcTNhVmP+bWDsc9ZPb36Y2pfF+qZK0o2uVgjuzFp3gmIhCVTBbbgs yOovb2o8ZteJf/3kxRWWCMGGBfWFmAUKDQX6oWLmU1YB0t3ZPJS1o3KGRCVboCHVxjqt ptpHPFPy54CY94fPFSO3bYwl7R+/FBIgYWkuo94wyrIP4422uFbL1xfRfl3ZYXSioMou zYs5V3kWzBUraabfbNGUqx9jR0j66hKm68XxK4czhSQhRGUyed7DPVbeR4cEDTrVYcDA kfwr1HKmIX7G/JE8t3OzgXXgchVAdJ4pxfJ5/5d5LTdiytGTSdSLWRXISoeSgWy8b8Q7 thjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=/xczcHHgbgLjmDPZRsQQOR4rr11L/FIuVk3Q44mpf2E=; b=c02hSUe1giVb+HjO9XVJAMUCXY0U6mKGWV1xBts1JZWv9W96xiJOE2ScD3I6aog/yg DAPEiTlNrq7lal5HQytE4Aqj/HxmGGmnshK0vA8dSaCu5ZZMEoXvW/8qJ3Vm88vVjWij 37ytzir45Xro1UKXz7uKGS59rPU7k54gNvFI93tN/LiwVp9+20DWIO2mRIKZ3x9L29Si h2tUKPlw0vjxdm9g67xWvAU87CH0PuFpuWQDrn7zmXIr4gvsHM1NN6dh+ktVFO6TulM+ R5hrJyvLYECS6S4Bm9ygxEc4JCLvE/XTai06VUHxqImeOFWDPUTA14jzpzv81wC12SmC T8/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=l6kSonhl; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r14-20020a638f4e000000b00545a181d157si8464857pgn.51.2023.06.13.01.32.50; Tue, 13 Jun 2023 01:32:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=l6kSonhl; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239031AbjFMISb (ORCPT + 61 others); Tue, 13 Jun 2023 04:18:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234523AbjFMISa (ORCPT ); Tue, 13 Jun 2023 04:18:30 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C2A2EA for ; Tue, 13 Jun 2023 01:18:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9CE336109A for ; Tue, 13 Jun 2023 08:18:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 46EC6C433D2; Tue, 13 Jun 2023 08:18:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686644309; bh=2CT0RsKHdy9H78RC79+0zcuBYFt+2jfocKa7673XWVs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=l6kSonhl+du/a9J/VsYEER8jwFuZDaZDwm3Y2JJ4YAvPGTrDrmrI83k3C/UlcIoqi mOJZMtgVQeeD+a6Xwntb5knTOyqLpunKBVtJZpgrS5onld1h4wWnRQYwZs/WL7ViXt cNZlG3b9RQ3CEePaZmmGKg2WkAi5Z9+ERDW31eqjGn5sSs3GvBpzak3dxaZfzFRv+U KM6e/lyfTdO2L+9g+DF6FdPQ/cGzKAsRmZkrgUAxkRlo2rciVWFbhRigF+XuRRDaFI uWbBH70hK6SNP3Azq3KktMoxJRfiPXC2SzaT/k5Ula6i8vLta4Uf78qbQPLyobWyXB cnNRM4KeOQ4Zg== From: Kalle Valo To: Dmitry Antipov Cc: Ping-Ke Shih , linux-wireless@vger.kernel.org Subject: Re: [PATCH] rtlwifi: rtl8188ee: mark RTX_POWER_{BEFORE,AFTER}_IQK_A reads as unused References: <20230601105215.27013-1-dmantipov@yandex.ru> Date: Tue, 13 Jun 2023 11:18:25 +0300 In-Reply-To: <20230601105215.27013-1-dmantipov@yandex.ru> (Dmitry Antipov's message of "Thu, 1 Jun 2023 13:52:15 +0300") Message-ID: <87edmfepwu.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Dmitry Antipov writes: > According to Ping-Ke Shih, it may be unsafe to remove BB register reads > even if we don't interested in their values. OTOH such a reads may confuse > compilers (when the most strictness warning options are enabled) and/or > static analysis tools. So it may be helpful to convert related calls of > 'rtl_get_bbreg()' to 'void' and mark such a cases with special comment > just to make them easier to find and maybe even fix in the future. > > This is generally inspired by 6c75eab0417b9e5b05a18dbfc373e27a8ef876d8. > > Suggested-by: Ping-Ke Shih > Signed-off-by: Dmitry Antipov "wifi:" missing from the title, see the wiki link below for more info. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches