Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp891355rwd; Tue, 13 Jun 2023 01:36:58 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4EK1ql/5QZ+5XfkjCHKZs/OjhBanGGhQXhmIR2D3adBMXeg1I6Xm4OJP+8R2f3OY+msrEI X-Received: by 2002:a05:6808:d8:b0:39c:7a71:961 with SMTP id t24-20020a05680800d800b0039c7a710961mr6133090oic.30.1686645418700; Tue, 13 Jun 2023 01:36:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686645418; cv=none; d=google.com; s=arc-20160816; b=Tsh8MqJLWVc14+NsFkiBzi4z8iaH14nhF9fV2h394g4Ezhk7uR3gZl792szf2U95BT zNDoegc7YU9D+vpr3sJwJ0it/Kn8K45LiusCrV8UMhsVTqH/1eV8eJpPCBbaIc6oXno6 UqAwOo4w4axTESYO277KC7RCZYgbXn3K8K2EZyJ18fIG/Vo+9z+VqXPN4pjNf0EX+Ior KAi+2cXlguS5arMlpOblSnsEjk6kivGIngAYTAfFwuQyi0somO7/sSROOE9fdqNfabOf Uuc4BG0R4GlVYj9sPi+PUSMEAg3UCOgaqDT/zXtSiWCrcL2BGUFgnEm4O3G4AhW9n6ui TW9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=+3wySrTq9ZYBL4ogWnBL6nkyOP9e8Go2rEZ91BMDevg=; b=qUd2YPt0Ifjo8S1gaKM6qgUaBovBN45ARs8b5/T+GOHU4I8CwOm4L3LIM25Vd5sQCc BNN97EYokcJgSqouWdR1ZTZMQ2R+ppzqfmjm8SSByureeh9UzjPM8NuN0YMjmN92SMO3 QuYVWoGdm7R7G2e2XaIJiJJcgfhbHtyl++tMVtTaJxEGlZ8GdMTY+aR8Y/aoVdYv2BU8 1lL7UEVJ9BOiEThv62+/LgJNSTzjvpnBs1JzXw9W1lawB+ilAKWCk2QZCPIXdHL2yjG4 iwiUded/2duMfn/cs2HfePpPtyoGWyEAnfRdBnKXlK0jmXv+EQrei1DR3XAzdqWiZAOY aVIQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PMt9XpXe; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p7-20020a17090a868700b0024df8757367si4492730pjn.87.2023.06.13.01.36.51; Tue, 13 Jun 2023 01:36:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PMt9XpXe; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239717AbjFMIXa (ORCPT + 62 others); Tue, 13 Jun 2023 04:23:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239516AbjFMIX2 (ORCPT ); Tue, 13 Jun 2023 04:23:28 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1FD4B126 for ; Tue, 13 Jun 2023 01:23:28 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AC6FE60EFC for ; Tue, 13 Jun 2023 08:23:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 38038C433D2; Tue, 13 Jun 2023 08:23:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686644607; bh=YZn6aZMRUoNN+2U/WmirBvC+cUcO4KaiQjVh4B+C0lU=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=PMt9XpXeijEE06eV6MT09r4SvUY0gqBJvG7VWP9B4JI3XiIE4s7zsx/IoAAXw5ebl jLLfSk6UyV2LUd5sGmlp5kS9Pxi+qUkIjpnA6b880yFjfRWchcIIMulFR15NubUBTG e29sleIe7wUZd1UPTdxF4blgZorXzLlAPOzT1glh846Q33qTIED8r0EPntki9DRH0i 8+eqIKNnuk6nNUVBWfuCTj75O4YYk+1lMwgk2mzLzJeTFNnzzBoL2Ztn52YiyojQ+p gcbnJLH3w7sGMgIYtnmMsiQS22Q1YcUkmIBvR8V7AOpoYB+YYv8WA2SsOcoUYWoPOx F8KL9vtJ1KVsQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH 2/2] [v3] wifi: rtw89: cleanup rtw89_iqk_info and related code From: Kalle Valo In-Reply-To: <20230608082457.36020-2-dmantipov@yandex.ru> References: <20230608082457.36020-2-dmantipov@yandex.ru> To: Dmitry Antipov Cc: Ping-Ke Shih , linux-wireless@vger.kernel.org, Dmitry Antipov User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <168664460436.24637.2320483612539806164.kvalo@kernel.org> Date: Tue, 13 Jun 2023 08:23:26 +0000 (UTC) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Dmitry Antipov wrote: > Drop useless '_iqk_track()' and 'rtw8852a_iqk_track()' (they > just change 'thermal_rek_en' field which is set but unused > and so removed as well) functions, set but unused 'kcount' > field of 'struct rtw89_iqk_info', convert 'thermal' to local > variables where appropriate (it doesn't need to have longer > storage duration because it is actually used for debugging > purposes only), fix typos. > > Signed-off-by: Dmitry Antipov > Acked-by: Ping-Ke Shih In the future please fix typos in a separate patch. One logical change per patch, please. No need to resend because of this. -- https://patchwork.kernel.org/project/linux-wireless/patch/20230608082457.36020-2-dmantipov@yandex.ru/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches